DIALIN-DEN-4308-1 DIALIN-DEN-4308_HD Valve Control (1 of 2)

closed on 19 Oct 20

Author

Moderator

Reviewers

DIALIN-DEN-4308_HD Valve Control (1 of 2)

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 39

dialin 0
- Folder dialin 0
  - Folder common 0
    - File msg_defs.py 0 Remove
  - Folder dg 0
    - File accelerometer.py 0 Remove
    - File dialysate_generator.py 0 Remove
    - File drain_pump.py 0 Remove
    - File hd_proxy.py 0 Remove
    - File heaters.py 0 Remove
    - File load_cells.py 0 Remove
    - File ro_pump.py 0 Remove
    - File temperature_sensors.py 0 Remove
    - File valves.py 0 Remove
  - Folder hd 0
    - File accelerometer.py 0 Remove
    - File air_trap.py 0 Remove
    - File alarms.py 0 Remove
    - File blood_flow.py 0 Remove
    - File constants.py 0 Remove
    - File dialysate_inlet_flow.py 0 Remove
    - File dialysate_outlet_flow.py 0 Remove
    - File hemodialysis_device.py 0 Remove
    - File rtc.py 0 Remove
    - File treatment.py 0 Remove
    - File ui_proxy.py 0 Remove
    - File valves.py 25 Remove
  - Folder squish 0
    - File crc.py 0 Remove
    - File denaliMessages.py 38 Remove
    - File globals.py 0 Remove
    - File messageBuilder.py 3 Remove
    - File unittests.py 0 Remove
    - File utils.py 0 Remove
- Folder tests 0
  - File air_trap_levels.py 0 Remove
  - File dg_heatdisinfect.py 0 Remove
  - File hd_test_pumps_open_loop.py 0 Remove
  - File hd_test_script.py 0 Remove
  - File hd_valves_test.py 6 Remove
  - File set_RTCs.py 0 Remove
  - File set_accels_cal.py 0 Remove
  - File set_flow_sensors_cal.py 0 Remove
  - File test_hd.py 0 Remove
  - File test_uf.py 0 Remove
  - File uf_test.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Dara Navaei	Author & Moderator	1h 40m	25	I removed try and except and added has_value method.
Sean Nash	Reviewer - Complete	26m	6	RESOLVED.
plucia (deleted user)	Reviewer - Complete	37m	13	RESOLVED
pmontazemi (deleted user)	Reviewer - 18% reviewed	54m	28	RESOLVED.
Total		3h 39m	72

Linked issues
- DEN-4308

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-DEN-4308-1

DIALIN-DEN-4308_HD Valve Control (1 of 2)

DIALIN-DEN-4308-1 72

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DIALIN-DEN-4308_HD Valve Control (1 of 2)

DIALIN-DEN-4308-1 72

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time