Fisheye on hdfirmware/firmware/App/Services/WatchdogMgmt.c https://devapps.diality.us/changelog/~br%3DDEN-9906-hd_dev-flow-measurement-changes/hdfirmware/firmware/App/Services/WatchdogMgmt.c Recent activity in "hdfirmware" under directory /firmware/App/Services/WatchdogMgmt.c HD-DEN-16693-1: closed by Dara Navaei Fri, 08 Mar 2024 15:42:16 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1 https://devapps.diality.us/cru/HD-DEN-16693-1 Dara Navaei Closed HD-DEN-16693-1 ]]> HD-DEN-16693-1: reviewers finished Fri, 08 Mar 2024 15:42:00 -0800 https://devapps.diality.us/cru/HD-DEN-16693-1 https://devapps.diality.us/cru/HD-DEN-16693-1 Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16693-1 HD-DEN-16693_Institutional Settings Implementation ]]> HD-DEN-16693-1: comment by pvedantam "RESOLVED IN CODE WALKTHGROUGH" Fri, 08 Mar 2024 15:33:10 -0800 pvedantam https://devapps.diality.us/cru/HD-DEN-16693-1/#c19597 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19597 pvedantam  (deleted user) replied to pvedantam  (deleted user) in HD-DEN-16693-1

RESOLVED IN CODE WALKTHGROUGH

]]> HD-DEN-16693-1: comment by pvedantam "We did not check for the upper limit in the pas..." Fri, 08 Mar 2024 15:16:10 -0800 pvedantam https://devapps.diality.us/cru/HD-DEN-16693-1/#c19596 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19596 pvedantam  (deleted user) commented on HD-DEN-16693-1

We did not check for the upper limit in the past, does this add new rejection scenarios

]]> HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 07 Mar 2024 15:13:57 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19589 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19589 Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16693-1: comment by Dara Navaei "Done" Thu, 07 Mar 2024 15:02:02 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1/#c19588 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19588 Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

]]> HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 07 Mar 2024 14:59:10 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19587 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19587 Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16693-1: comment by Sean Nash "Add minimum check here too." Thu, 07 Mar 2024 14:58:16 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19586 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19586 Sean Nash commented on HD-DEN-16693-1

Add minimum check here too.

]]> HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 07 Mar 2024 14:56:47 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19585 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19585 Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16693-1: comment by Dara Navaei "Done" Thu, 07 Mar 2024 14:46:22 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1/#c19584 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19584 Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

]]> HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 07 Mar 2024 14:41:12 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19583 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19583 Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16693-1: comment by Dara Navaei "Done" Thu, 07 Mar 2024 14:38:48 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1/#c19582 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19582 Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

]]> HD-DEN-16693-1: comment by Sean Nash "Do we need to add check for minimum treatment d..." Thu, 07 Mar 2024 14:35:48 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19581 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19581 Sean Nash commented on HD-DEN-16693-1

Do we need to add check for minimum treatment duration?

]]> HD-DEN-16693-1: comment by Sean Nash "Cast constant as (F32) as before." Thu, 07 Mar 2024 14:32:54 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19580 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19580 Sean Nash commented on HD-DEN-16693-1

Cast constant as (F32) as before.

]]> HD-DEN-16693-1: comment by Dara Navaei "Done" Thu, 07 Mar 2024 14:14:14 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1/#c19579 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19579 Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

]]> HD-DEN-16693-1: comment by Sean Nash "dialVolume is a volume (not a flow). Use const..." Thu, 07 Mar 2024 14:10:47 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19578 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19578 Sean Nash commented on HD-DEN-16693-1

dialVolume is a volume (not a flow). Use constant (as before) for dialVolume check.

]]> HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 05 Mar 2024 10:14:39 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19556 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19556 Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16693-1: comment by Dara Navaei "Done" Mon, 04 Mar 2024 12:55:19 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1/#c19554 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19554 Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

]]> HD-DEN-16693-1: comment by Sean Nash "This alarm should be restored." Fri, 01 Mar 2024 10:18:22 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19549 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19549 Sean Nash commented on HD-DEN-16693-1

This alarm should be restored.

]]> HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 29 Feb 2024 10:24:27 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19527 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19527 Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 29 Feb 2024 10:23:45 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19526 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19526 Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16693-1: comment by Dara Navaei "I check these against result since it is result..." Thu, 29 Feb 2024 09:26:07 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1/#c19525 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19525 Dara Navaei replied to Sean Nash in HD-DEN-16693-1

I check these against result since it is result &= ().

]]> HD-DEN-16693-1: comment by Dara Navaei "Done" Thu, 29 Feb 2024 09:25:09 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1/#c19524 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19524 Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

]]> HD-DEN-16693-1: reviewers added to HD-DEN-16693_Institutional Settings Implementation Thu, 29 Feb 2024 09:23:19 -0800 https://devapps.diality.us/cru/HD-DEN-16693-1 https://devapps.diality.us/cru/HD-DEN-16693-1 Dara Navaei added pvedantam  (deleted user) to HD-DEN-16693-1 HD-DEN-16693_Institutional Settings Implementation ]]> HD-DEN-16693-1: comment by Sean Nash "Remove blank line." Tue, 27 Feb 2024 16:08:25 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19519 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19519 Sean Nash commented on HD-DEN-16693-1

Remove blank line.

]]> HD-DEN-16693-1: comment by Sean Nash "All of these ternaries should say ... ? result ..." Tue, 27 Feb 2024 16:06:47 -0800 Sean Nash https://devapps.diality.us/cru/HD-DEN-16693-1/#c19518 https://devapps.diality.us/cru/HD-DEN-16693-1/#c19518 Sean Nash commented on HD-DEN-16693-1

All of these ternaries should say ... ? result : FALSE );

]]> HD-DEN-16693-1: started by Dara Navaei Sun, 25 Feb 2024 13:20:43 -0800 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16693-1 https://devapps.diality.us/cru/HD-DEN-16693-1 Dara Navaei started review HD-DEN-16693-1 ]]> HD-DEN-11750-2: closed by Dara Navaei Thu, 19 Oct 2023 09:48:02 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2 https://devapps.diality.us/cru/HD-DEN-11750-2 Dara Navaei Closed HD-DEN-11750-2 ]]> HD-DEN-11750-2: started by Dara Navaei Thu, 19 Oct 2023 09:43:27 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2 https://devapps.diality.us/cru/HD-DEN-11750-2 Dara Navaei started review HD-DEN-11750-2 ]]> HD-DEN-11750-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 09:40:54 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-11750-2/#c19140 https://devapps.diality.us/cru/HD-DEN-11750-2/#c19140 Dara Navaei replied to Michael Garthwaite in HD-DEN-11750-2

RESOLVED in CODE WALKTHROUGH

]]>