Fisheye on dgfirmware/

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-112 updated the VectorCAST test cases

Dara Navaei — Thu, 19 Oct 2023 13:34:05 -0700

Dara Navaei committed 7f5049d on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

DENBUG-112 updated the VectorCAST test cases

· /results/Build_Status_Report.csv

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-112 updated the VectorCAST test cases

Dara Navaei — Thu, 19 Oct 2023 11:12:41 -0700

Dara Navaei committed 60e256a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

DENBUG-112 updated the VectorCAST test cases

· /results/Build_Status_Report.csv	(-79, +5)	\| History	\| Source	\| Diff
· /results/VectorCAST.log	(-38897, +0)	\| History	\| Source	\| Diff
· /results/cppcheck.log	(-77, +86)	\| History	\| Source	\| Diff
· /results/cppcheckError.csv	(-78, +104)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-112 changed the tare alarm limit in heat disinfect active cool mode

Dara Navaei — Tue, 17 Oct 2023 14:10:38 -0700

Dara Navaei committed f7c6956 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

DENBUG-112 changed the tare alarm limit in heat disinfect active cool mode

· /firmware/App/Controllers/LoadCell.c

(-1, +5)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Tue, 17 Oct 2023 10:32:23 -0700

Dara Navaei committed 6216d19 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 17 Oct 2023 10:32:13 -0700

Dara Navaei committed 4950894 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged DEN-16446 to staging.

Sean Nash — Tue, 17 Oct 2023 10:29:54 -0700

Sean Nash committed 2424156 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

Merged DEN-16446 to staging.

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'DEN-16446-dg-dev-test-clean-up-vectorcast' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-16446-dg-dev-t...

Sean Nash — Mon, 16 Oct 2023 10:27:01 -0700

Sean Nash committed 854a074 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

Merge branch 'DEN-16446-dg-dev-test-clean-up-vectorcast' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-16446-dg-dev-test-clean-up-vectorcast

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446: Address DENBUG-105 to reset concentrate volume used when priming conc lines.

Sean Nash — Mon, 16 Oct 2023 10:26:58 -0700

Sean Nash committed 506f3f5 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

DEN-16446: Address DENBUG-105 to reset concentrate volume used when priming conc lines.

· /firmware/App/Modes/ModeFill.c

(-0, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-76 added code to not check the temperature sensors drift until a couple of minutes into R1 to R2

Dara Navaei — Sat, 14 Oct 2023 17:17:03 -0700

Dara Navaei committed 77f5c03 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

DENBUG-76 added code to not check the temperature sensors drift until a couple of minutes into R1 to R2

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +10)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged staging to DEN-16446.

Sean Nash — Thu, 12 Oct 2023 21:37:04 -0700

Sean Nash committed 473f9ad on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

Merged staging to DEN-16446.

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Thu, 12 Oct 2023 10:39:31 -0700

Dara Navaei committed 2185f5a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 11 Oct 2023 22:33:08 -0700

Dara Navaei committed b27441d on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 11 Oct 2023 22:32:58 -0700

Dara Navaei committed ba9d98d on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeGenIdle.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged DENBUG-96 to staging.

Sean Nash — Wed, 11 Oct 2023 22:30:37 -0700

Sean Nash committed 5c45cae on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 53 more in dgfirmware

Merged DENBUG-96 to staging.

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-96: Addressed DENBUG-97.

Sean Nash — Wed, 11 Oct 2023 12:36:08 -0700

Sean Nash committed e6e0513 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DENBUG-96: Addressed DENBUG-97.

· /firmware/App/Modes/ModeGenIdle.c	(-0, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-96: Addressed DENBUG-98.

Sean Nash — Wed, 11 Oct 2023 12:22:01 -0700

Sean Nash committed 6243741 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DENBUG-96: Addressed DENBUG-98.

· /firmware/App/Modes/ModeStandby.c

(-0, +7)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Tue, 10 Oct 2023 15:59:36 -0700

Dara Navaei committed 8f8582c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 10 Oct 2023 15:59:22 -0700

Dara Navaei committed 3024adb on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemCommMessages.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged DEN-16487

Dara Navaei — Tue, 10 Oct 2023 15:57:52 -0700

Dara Navaei committed 8396fe2 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Merged DEN-16487

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16487 added code to set the dialin expiration time stamp once the user has logged in until the first checkin from di...

Dara Navaei — Tue, 10 Oct 2023 09:09:23 -0700

Dara Navaei committed 46dc653 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16487 added code to set the dialin expiration time stamp once the user has logged in until the first checkin from dialin is received

· /firmware/App/Services/SystemCommMessages.c

(-0, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 09 Oct 2023 11:24:15 -0700

Dara Navaei committed 0b9c7e1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 09 Oct 2023 11:23:57 -0700

Dara Navaei committed d32f890 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged DEN-16446

Dara Navaei — Mon, 09 Oct 2023 11:09:56 -0700

Dara Navaei committed 02e8e56 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Merged DEN-16446

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

Dara Navaei — Mon, 09 Oct 2023 10:03:56 -0700

Dara Navaei committed 66bf871 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 addressed the code review comments

Dara Navaei — Mon, 09 Oct 2023 09:21:11 -0700

Dara Navaei committed 4c992d2 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16446 addressed the code review comments

· /firmware/App/Services/SystemCommMessages.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 09 Oct 2023 09:19:06 -0700

Dara Navaei committed 5fe44a7 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 09 Oct 2023 09:18:53 -0700

Dara Navaei committed dd5df16 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/TemperatureSensors.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'DEN-16475-please-add-average-tdi-tro-delta' into staging

Michael Garthwaite — Mon, 09 Oct 2023 08:59:17 -0700

Michael Garthwaite committed 3725ad2 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Merge branch 'DEN-16475-please-add-average-tdi-tro-delta' into staging

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 merged from remote

Vinayakam Mani — Mon, 09 Oct 2023 08:58:52 -0700

Vinayakam Mani committed bccd8ee on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16446 merged from remote

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16475: code review comments

Michael Garthwaite — Mon, 09 Oct 2023 08:57:32 -0700

Michael Garthwaite committed 630cc5c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 55 more in dgfirmware

DEN-16475: code review comments

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff