Fisheye on hdfirmware/firmware/App/Controllers/DialOutFlow.c

HD-DENBUG-104-1: closed by Sean Nash

Sean Nash — Mon, 26 Feb 2024 15:44:42 -0800

Sean Nash Closed HD-DENBUG-104-1

HD-DENBUG-104-2: closed by Sean Nash

Sean Nash — Mon, 26 Feb 2024 15:44:32 -0800

Sean Nash Closed HD-DENBUG-104-2

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 26 Feb 2024 15:20:53 -0800

Dara Navaei committed ae2af75 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16672-air-trap-level-control-changes and 45 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DialInFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-2, +2)	\| History	\| Source	\| Diff

HD-DENBUG-104-2: reviewers finished

Mon, 26 Feb 2024 15:13:16 -0800

Michael Garthwaite and Vinayakam Mani finished reviewing HD-DENBUG-104-2

HD-DENBUG-104_Alarm 38 HD Fault Dpi Rotor T

HD-DENBUG-104-1: reviewers finished

Mon, 26 Feb 2024 15:12:51 -0800

Michael Garthwaite and Vinayakam Mani finished reviewing HD-DENBUG-104-1

HD-DENBUG-104_Alarm 38 HD Fault Dpi Rotor T

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DENBUG-104: Fixed errors in bug fix.

Sean Nash — Mon, 26 Feb 2024 13:02:48 -0800

Sean Nash committed 7a16f63 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16672-air-trap-level-control-changes and 46 more in hdfirmware

DENBUG-104: Fixed errors in bug fix.

· /firmware/App/Controllers/DialInFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DENBUG-104: restored max dialysate pump speed to 4000 RPM. Apply reduced lower rotor speed tolerance only to commanded ...

Sean Nash — Mon, 26 Feb 2024 10:27:40 -0800

Sean Nash committed 1eb4e75 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16672-air-trap-level-control-changes and 46 more in hdfirmware

DENBUG-104: restored max dialysate pump speed to 4000 RPM. Apply reduced lower rotor speed tolerance only to commanded speeds > 3200 RPM.

· /firmware/App/Controllers/DialInFlow.c	(-5, +6)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-5, +6)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DENBUG-104: Increased max dialysate pump speed from 3400 to 3600 RPM. Reduced lower rotor speed tolerance from -5 RPM o...

Sean Nash — Mon, 26 Feb 2024 10:01:45 -0800

Sean Nash committed fc5e455 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16672-air-trap-level-control-changes and 46 more in hdfirmware

DENBUG-104: Increased max dialysate pump speed from 3400 to 3600 RPM. Reduced lower rotor speed tolerance from -5 RPM or -15% (whichever is bigger) to -60%.

· /firmware/App/Controllers/DialInFlow.c	(-4, +6)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-4, +6)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DENBUG-104: Allow for dialin pwm set cmd to go to full speed.

Sean Nash — Fri, 23 Feb 2024 15:05:05 -0800

Sean Nash committed 8477ca1 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16672-air-trap-level-control-changes and 46 more in hdfirmware

DENBUG-104: Allow for dialin pwm set cmd to go to full speed.

· /firmware/App/Controllers/DialInFlow.c	(-3, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-3, +4)	\| History	\| Source	\| Diff

HD-DENBUG-104-2: started by Dara Navaei

Dara Navaei — Fri, 23 Feb 2024 14:50:28 -0800

Dara Navaei started review HD-DENBUG-104-2

HD-DENBUG-104-1: started by Dara Navaei

Dara Navaei — Fri, 23 Feb 2024 14:50:19 -0800

Dara Navaei started review HD-DENBUG-104-1

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DENBUG-104: Cap dialysate pump speed to 3,400 RPM to prevent rotor speed errors.

Sean Nash — Fri, 23 Feb 2024 14:37:27 -0800

Sean Nash committed 20207f5 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16672-air-trap-level-control-changes and 46 more in hdfirmware

DENBUG-104: Cap dialysate pump speed to 3,400 RPM to prevent rotor speed errors.

· /firmware/App/Controllers/DialInFlow.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.c	(-1, +1)	\| History	\| Source	\| Diff

HD-DEN-16518-2: closed by Vinayakam Mani

Vinayakam Mani — Tue, 16 Jan 2024 16:29:34 -0800

Vinayakam Mani Closed HD-DEN-16518-2

HD-DEN-16518-2: reviewers finished

Mon, 15 Jan 2024 16:16:01 -0800

Sean Nash and Michael Garthwaite finished reviewing HD-DEN-16518-2

HD-DEN-16518_Alarm 41 Triggered ON Dvt 014 AT The Beginning OF Treatment

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 15 Jan 2024 12:25:32 -0800

Dara Navaei committed 27a88fe on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 55 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DialOutFlow.c

(-1, +1)

| History

| Source

| Diff

HD-DEN-16518-1: closed by Vinayakam Mani

Vinayakam Mani — Mon, 15 Jan 2024 12:05:25 -0800

Vinayakam Mani Closed HD-DEN-16518-1

HD-DEN-16518-2: started by Dara Navaei

Dara Navaei — Mon, 15 Jan 2024 12:00:36 -0800

Dara Navaei started review HD-DEN-16518-2

HD-DEN-16518-1: reviewers finished

Mon, 15 Jan 2024 11:10:23 -0800

Michael Garthwaite and Sean Nash finished reviewing HD-DEN-16518-1

HD-DEN-16518_Alarm 41 Triggered ON Dvt 014 AT The Beginning OF Treatment

HD-DEN-16518-1: comment by Michael Garthwaite "RESOLVED IN CODE WALKTHROUGH."

Michael Garthwaite — Mon, 15 Jan 2024 11:10:04 -0800

Michael Garthwaite replied to Vinayakam Mani in HD-DEN-16518-1

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-16518-1: comment by Vinayakam Mani "Updated code changes. Open loop still maintains..."

Vinayakam Mani — Mon, 15 Jan 2024 11:04:07 -0800

Vinayakam Mani replied to Vinayakam Mani in HD-DEN-16518-1

Updated code changes. Open loop still maintains the minimum PWM duty cycle as 10%.

HD-DEN-16518-1: comment by Vinayakam Mani "Updated code changes. Open loop still maintains..."

Vinayakam Mani — Mon, 15 Jan 2024 11:01:44 -0800

Vinayakam Mani replied to Michael Garthwaite in HD-DEN-16518-1

Updated code changes. Open loop still maintains the minimum PWM duty cycle as 10%.

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16518 code review changes

Vinayakam Mani — Mon, 15 Jan 2024 10:59:04 -0800

Vinayakam Mani committed 3f5b29a on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 56 more in hdfirmware

DEN-16518 code review changes

· /firmware/App/Controllers/DialOutFlow.c

(-1, +1)

| History

| Source

| Diff

HD-DEN-16518-1: comment by Sean Nash "Do we want to have the 11% minimum here? I tho..."

Sean Nash — Mon, 15 Jan 2024 10:42:25 -0800

Sean Nash replied to Michael Garthwaite in HD-DEN-16518-1

Do we want to have the 11% minimum here? I thought it was just for closed loop control.

HD-DEN-16518-1: comment by Michael Garthwaite "This will cause open loop control mode to have ..."

Michael Garthwaite — Mon, 15 Jan 2024 10:25:37 -0800

Michael Garthwaite commented on HD-DEN-16518-1

This will cause open loop control mode to have a minimum of 11% instead of 10%. For open loop, pwmDC is assigned a value at line 295. Do we still need the #define for the 10% pwm lower limit?

HD-DEN-16518-1: started by Dara Navaei

Dara Navaei — Wed, 03 Jan 2024 12:00:58 -0800

Dara Navaei started review HD-DEN-16518-1

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16518-alarm-41-triggered-on-dvt-014-at-the-beginning-of-treatment

Vinayakam Mani — Wed, 03 Jan 2024 10:31:13 -0800

Vinayakam Mani committed 12b35c5 on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 56 more in hdfirmware

DEN-16518-alarm-41-triggered-on-dvt-014-at-the-beginning-of-treatment

· /firmware/App/Controllers/DialOutFlow.c

(-2, +3)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 02 Jan 2024 10:53:49 -0800

Dara Navaei committed 736cc5b on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 56 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-3, +3)

| History

| Source

| Diff

… 102 more files in changeset.

HD-DEN-16512-2: closed by Vinayakam Mani

Vinayakam Mani — Mon, 18 Dec 2023 10:24:33 -0800

Vinayakam Mani Closed HD-DEN-16512-2

HD-DEN-16512-2: reviewers finished

Mon, 18 Dec 2023 09:51:51 -0800

Sean Nash and Dara Navaei finished reviewing HD-DEN-16512-2

HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 18 Dec 2023 09:43:23 -0800

Dara Navaei committed 8c7e0b5 on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 57 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DialOutFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-1, +1)	\| History	\| Source	\| Diff