Fisheye on hdfirmware/firmware/App/Controllers/DialOutFlow.h

HD-DEN-16499-2: closed by Dara Navaei

Dara Navaei — Tue, 06 Feb 2024 13:21:41 -0800

Dara Navaei Closed HD-DEN-16499-2

HD-DEN-16499-2: reviewers finished

Tue, 06 Feb 2024 13:05:34 -0800

Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16499-2

HD-DEN-16499_FW Message List Testing Issues 2

HD-DEN-16499-2: started by Dara Navaei

Dara Navaei — Tue, 06 Feb 2024 10:16:23 -0800

Dara Navaei started review HD-DEN-16499-2

HD-DEN-16499-1: closed by Dara Navaei

Dara Navaei — Fri, 02 Feb 2024 14:07:43 -0800

Dara Navaei Closed HD-DEN-16499-1

HD-DEN-16499-1: reviewers finished

Fri, 02 Feb 2024 14:07:13 -0800

Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16499-1

HD-DEN-16499_FW Message List Testing Issues

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 02 Feb 2024 13:59:48 -0800

Dara Navaei committed 20d0c02 on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16563-venous-pressure-readings-were-below-20mmhg-for-1.5-minutes-before-low-venous and 52 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BloodLeak.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/HDCommon.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/BloodPrime.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

HD-DEN-16499-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 02 Feb 2024 09:31:10 -0800

Sean Nash replied to Dara Navaei in HD-DEN-16499-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16499-1: comment by Dara Navaei "Fixed the code."

Dara Navaei — Fri, 02 Feb 2024 08:45:21 -0800

Dara Navaei replied to Sean Nash in HD-DEN-16499-1

Fixed the code.

HD-DEN-16499-1: comment by Sean Nash "This looks wrong."

Sean Nash — Thu, 25 Jan 2024 08:56:55 -0800

Sean Nash commented on HD-DEN-16499-1

This looks wrong.

HD-DEN-16499-1: started by Dara Navaei

Dara Navaei — Tue, 23 Jan 2024 15:13:40 -0800

Dara Navaei started review HD-DEN-16499-1

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16499 added doxygen comments for the structures

Dara Navaei — Tue, 23 Jan 2024 12:50:12 -0800

Dara Navaei committed 43b7870 on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 53 more in hdfirmware

DEN-16499 added doxygen comments for the structures

· /firmware/App/Controllers/BloodFlow.h	(-10, +10)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialInFlow.h	(-10, +10)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.h	(-14, +14)	\| History	\| Source	\| Diff
· /firmware/App/HDCommon.h	(-33, +33)	\| History	\| Source	\| Diff
· /firmware/App/Modes/BloodPrime.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.h	(-3, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.h	(-28, +28)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.h	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 02 Jan 2024 10:53:49 -0800

Dara Navaei committed 736cc5b on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 56 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-3, +3)

| History

| Source

| Diff

… 102 more files in changeset.

HD-DEN-16512-2: closed by Vinayakam Mani

Vinayakam Mani — Mon, 18 Dec 2023 10:24:33 -0800

Vinayakam Mani Closed HD-DEN-16512-2

HD-DEN-16512-2: reviewers finished

Mon, 18 Dec 2023 09:51:51 -0800

Sean Nash and Dara Navaei finished reviewing HD-DEN-16512-2

HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 18 Dec 2023 09:43:23 -0800

Dara Navaei committed 8c7e0b5 on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 57 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DialOutFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DialOutFlow.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-1, +1)	\| History	\| Source	\| Diff

HD-DEN-16512-1: closed by Dara Navaei

Dara Navaei — Sun, 17 Dec 2023 15:54:13 -0800

Dara Navaei Closed HD-DEN-16512-1

HD-DEN-16512-2: started by Dara Navaei

Dara Navaei — Fri, 15 Dec 2023 11:55:51 -0800

Dara Navaei started review HD-DEN-16512-2

HD-DEN-16512-1: reviewers finished

Thu, 14 Dec 2023 13:10:40 -0800

Dara Navaei finished reviewing HD-DEN-16512-1

HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate

HD-DEN-16512-1: reviewers finished

Thu, 07 Dec 2023 09:44:37 -0800

Sean Nash finished reviewing HD-DEN-16512-1

HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate

HD-DEN-16512-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 07 Dec 2023 09:41:09 -0800

Sean Nash replied to Vinayakam Mani in HD-DEN-16512-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16512-1: comment by Vinayakam Mani "Done."

Vinayakam Mani — Wed, 06 Dec 2023 16:05:03 -0800

Vinayakam Mani replied to Sean Nash in HD-DEN-16512-1

Done.

HD-DEN-16512-1: reviewers resumed

Wed, 06 Dec 2023 15:42:53 -0800

jtaylor (deleted user) resumed reviewing HD-DEN-16512-1

HD-DEN-16512_Dpo Stops During Treatment After Reconfirming Dialysate Flow Rate

HD-DEN-16512-1: comment by Sean Nash "Consider splitting this if and the setDialysisP..."

Sean Nash — Mon, 04 Dec 2023 14:22:47 -0800

Sean Nash commented on HD-DEN-16512-1

Consider splitting this if and the setDialysisParams() function into two: 1) blood flow rate changed and 2) dialysate flow rate changed.

HD-DEN-16512-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 28 Nov 2023 09:25:29 -0800

Sean Nash replied to Vinayakam Mani in HD-DEN-16512-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16512-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 28 Nov 2023 09:24:08 -0800

Sean Nash replied to Vinayakam Mani in HD-DEN-16512-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16512-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 28 Nov 2023 09:23:58 -0800

Sean Nash replied to Vinayakam Mani in HD-DEN-16512-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16512-1: comment by Vinayakam Mani "Done."

Vinayakam Mani — Mon, 27 Nov 2023 13:35:09 -0800

Vinayakam Mani replied to Sean Nash in HD-DEN-16512-1

Done.

HD-DEN-16512-1: comment by Vinayakam Mani "Done."

Vinayakam Mani — Mon, 27 Nov 2023 13:34:58 -0800

Vinayakam Mani replied to Sean Nash in HD-DEN-16512-1

Done.

HD-DEN-16512-1: comment by Vinayakam Mani "Done."

Vinayakam Mani — Mon, 27 Nov 2023 13:34:49 -0800

Vinayakam Mani replied to Sean Nash in HD-DEN-16512-1

Done.

HD-DEN-16512-1: comment by Sean Nash "5% seems like a reasonable max step. I don't t..."

Sean Nash — Mon, 27 Nov 2023 09:26:15 -0800

Sean Nash commented on HD-DEN-16512-1

5% seems like a reasonable max step. I don't think we want to go to ramp up/down states if > 5% change. I think we just want to limit the change to max 5% for a single control interval.