Fisheye on hdfirmware/firmware

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DENBUG-232 user stack memory update

Vinayakam Mani — Thu, 11 Apr 2024 17:25:10 -0700

Vinayakam Mani committed 2277da2 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 38 more in hdfirmware

DENBUG-232 user stack memory update

· /firmware/HD.dil	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/include/sys_core.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/source/sys_core.asm	(-6, +6)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DENBUG-232 set the heating parameters during rinseback start state

Vinayakam Mani — Wed, 10 Apr 2024 15:14:52 -0700

Vinayakam Mani committed 8d744da on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 38 more in hdfirmware

DENBUG-232 set the heating parameters during rinseback start state

· /firmware/App/Controllers/Voltages.c	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-0, +15)	\| History	\| Source	\| Diff
· /firmware/source/sys_link.cmd	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DENBUG-232 alarm 139 persistance clear update

Vinayakam Mani — Wed, 10 Apr 2024 10:28:30 -0700

Vinayakam Mani committed b178e71 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 38 more in hdfirmware

DENBUG-232 alarm 139 persistance clear update

· /firmware/App/Controllers/Voltages.c

(-0, +6)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DENBUG-232-alarm persistence clearchanges

Vinayakam Mani — Tue, 09 Apr 2024 17:31:42 -0700

Vinayakam Mani committed 44b8dfa on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 38 more in hdfirmware

DENBUG-232-alarm persistence clearchanges

· /firmware/App/Controllers/Voltages.c

(-0, +3)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DENBUG-232-unable-to-clear-communication

Vinayakam Mani — Tue, 09 Apr 2024 11:01:35 -0700

Vinayakam Mani committed f11ec49 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 38 more in hdfirmware

DENBUG-232-unable-to-clear-communication

· /firmware/App/Controllers/Voltages.c

(-2, +2)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DENBUG-232-unable-to-clear-communication

Vinayakam Mani — Mon, 08 Apr 2024 17:51:18 -0700

Vinayakam Mani committed 3a35ddc on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 38 more in hdfirmware

DENBUG-232-unable-to-clear-communication

· /firmware/App/Controllers/Voltages.c

(-1, +2)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Mon, 08 Apr 2024 10:08:59 -0700

Dara Navaei committed 0b5ba9b on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 38 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 08 Apr 2024 10:08:35 -0700

Dara Navaei committed f8278ff on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 38 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/SyringePump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DENBUG-216: Addressed potential issues with clearing of alarm persistence.

Sean Nash — Fri, 05 Apr 2024 17:21:48 -0700

Sean Nash committed 8d4bc50 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware

DENBUG-216: Addressed potential issues with clearing of alarm persistence.

· /firmware/App/Controllers/SyringePump.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-0, +6)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Fri, 05 Apr 2024 16:44:20 -0700

Dara Navaei committed 5647ef2 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 05 Apr 2024 16:43:54 -0700

Dara Navaei committed 79cee95 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirTrap.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Voltages.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16782 clearing AC power lost in treatment alarm when DG is not in POST mode

Vinayakam Mani — Fri, 05 Apr 2024 14:22:44 -0700

Vinayakam Mani committed 027e4f8 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware

DEN-16782 clearing AC power lost in treatment alarm when DG is not in POST mode

· /firmware/App/Controllers/AirTrap.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Voltages.c	(-1, +7)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Fri, 05 Apr 2024 09:29:28 -0700

Dara Navaei committed a7a3f06 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 05 Apr 2024 09:29:02 -0700

Dara Navaei committed e8edb83 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DGInterface.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-2, +2)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16782-unable-to-clear-communication-error-alarm-65-during-power-loss

Vinayakam Mani — Tue, 02 Apr 2024 11:28:32 -0700

Vinayakam Mani committed 9747ea0 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware

DEN-16782-unable-to-clear-communication-error-alarm-65-during-power-loss

· /firmware/App/Controllers/DGInterface.h

(-1, +2)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16782 addressing code review comments

Vinayakam Mani — Tue, 02 Apr 2024 11:21:36 -0700

Vinayakam Mani committed f373b6c on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware

DEN-16782 addressing code review comments

· /firmware/App/Controllers/DGInterface.c	(-25, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.h	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-27, +26)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.h	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-4, +8)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16782-unable-to-clear-communication-error-alarm-65-during-power-loss

Vinayakam Mani — Mon, 01 Apr 2024 17:13:21 -0700

Vinayakam Mani committed a5b84c0 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware

DEN-16782-unable-to-clear-communication-error-alarm-65-during-power-loss

· /firmware/App/Controllers/DGInterface.c	(-0, +25)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.h	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-0, +11)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +2)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Wed, 20 Mar 2024 17:40:50 -0700

Dara Navaei committed 7c80cb1 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 20 Mar 2024 17:39:49 -0700

Dara Navaei committed da7db7c on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/SelfTests.c

(-1, +1)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16779 added two breaks per cppcheck warning

Dara Navaei — Wed, 20 Mar 2024 16:47:06 -0700

Dara Navaei committed 67fae75 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16779 added two breaks per cppcheck warning

· /firmware/App/Modes/SelfTests.c

(-0, +2)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Dara Navaei — Tue, 19 Mar 2024 16:49:19 -0700

Dara Navaei committed a00328e on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

· /firmware/App/HDCommon.h

(-1, +1)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 19 Mar 2024 16:48:56 -0700

Dara Navaei committed c3043e7 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16773 added enable chemical disinfect institutional record range check

Dara Navaei — Tue, 19 Mar 2024 13:36:41 -0700

Dara Navaei committed e9f0b99 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16773 added enable chemical disinfect institutional record range check

· /firmware/App/Modes/ModeTreatmentParams.c

(-0, +2)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16773 added another check upon receiving the institutional record to make sure the minimum set is less than maximum ...

Dara Navaei — Tue, 19 Mar 2024 13:27:40 -0700

Dara Navaei committed ba102c1 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16773 added another check upon receiving the institutional record to make sure the minimum set is less than maximum set value

· /firmware/App/Modes/ModeTreatmentParams.c

(-0, +12)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16773 addressed the code review comments

Dara Navaei — Tue, 19 Mar 2024 09:30:17 -0700

Dara Navaei committed 410a693 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16773 addressed the code review comments

· /firmware/App/Modes/ModeStandby.c

(-6, +8)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16773 fixed a typo

Dara Navaei — Mon, 18 Mar 2024 18:45:46 -0700

Dara Navaei committed ba722a0 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16773 fixed a typo

· /firmware/App/Modes/ModeStandby.c	(-6, +12)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16773 removed unused code in the airpump.c

Dara Navaei — Mon, 18 Mar 2024 16:57:58 -0700

Dara Navaei committed faf39c8 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16773 removed unused code in the airpump.c

· /firmware/App/Controllers/AirPump.c

(-13, +0)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16773 addressed a code review comment

Dara Navaei — Mon, 18 Mar 2024 15:32:50 -0700

Dara Navaei committed d165e40 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16773 addressed a code review comment

· /firmware/App/Controllers/AirPump.c

(-7, +6)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16773 added code to check the status of the chemical disinfect enable/disable in institutional record in NV data man...

Dara Navaei — Mon, 18 Mar 2024 15:28:53 -0700

Dara Navaei committed 14be630 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16773 added code to check the status of the chemical disinfect enable/disable in institutional record in NV data management

· /firmware/App/Modes/ModeStandby.c

(-4, +11)

| History

| Source

| Diff

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16773 removed alarm 318

Dara Navaei — Mon, 18 Mar 2024 14:38:46 -0700

Dara Navaei committed b1ad59a on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

DEN-16773 removed alarm 318

· /firmware/App/Controllers/AirPump.c

(-24, +0)

| History

| Source

| Diff