Fisheye on hdfirmware/firmware/App/Controllers/Buttons.c

HD-DEN-16693-2: closed by Dara Navaei

Dara Navaei — Fri, 15 Mar 2024 08:57:33 -0700

Dara Navaei Closed HD-DEN-16693-2

HD-DEN-16693-2: reviewers finished

Thu, 14 Mar 2024 17:25:52 -0700

Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16693-2

HD-DEN-16693_Institutional Settings Implementation

HD-DEN-16693-2: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH."

Vinayakam Mani — Thu, 14 Mar 2024 17:24:43 -0700

Vinayakam Mani replied to Dara Navaei in HD-DEN-16693-2

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-16693-2: comment by Vinayakam Mani "RESOLVED IN CODEWALKTHROUGH"

Vinayakam Mani — Thu, 14 Mar 2024 17:23:07 -0700

Vinayakam Mani replied to Dara Navaei in HD-DEN-16693-2

RESOLVED IN CODEWALKTHROUGH

HD-DEN-16693-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 14 Mar 2024 17:20:08 -0700

Sean Nash replied to Dara Navaei in HD-DEN-16693-2

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-2: comment by Dara Navaei "Done"

Dara Navaei — Thu, 14 Mar 2024 17:17:42 -0700

Dara Navaei replied to Vinayakam Mani in HD-DEN-16693-2

Done

HD-DEN-16693-2: comment by Dara Navaei "This is in a different function. I can remove."

Dara Navaei — Thu, 14 Mar 2024 17:17:08 -0700

Dara Navaei replied to Sean Nash in HD-DEN-16693-2

This is in a different function. I can remove.

HD-DEN-16693-2: comment by Dara Navaei "Done"

Dara Navaei — Thu, 14 Mar 2024 17:16:22 -0700

Dara Navaei replied to Vinayakam Mani in HD-DEN-16693-2

Done

HD-DEN-16693-2: comment by Sean Nash "I thought we weren't going to do this anymore?"

Sean Nash — Thu, 14 Mar 2024 17:16:04 -0700

Sean Nash commented on HD-DEN-16693-2

I thought we weren't going to do this anymore?

HD-DEN-16693-2: comment by Vinayakam Mani "Let's keep "///" 3 line comment for doxygen gen..."

Vinayakam Mani — Thu, 14 Mar 2024 17:08:51 -0700

Vinayakam Mani commented on HD-DEN-16693-2

Let's keep "///" 3 line comment for doxygen generation.

HD-DEN-16693-2: comment by Vinayakam Mani "lets keep "///" comment for doxygen generation."

Vinayakam Mani — Thu, 14 Mar 2024 17:06:30 -0700

Vinayakam Mani commented on HD-DEN-16693-2

lets keep "///" comment for doxygen generation.

HD-DEN-16693-2: started by Dara Navaei

Dara Navaei — Thu, 14 Mar 2024 14:11:34 -0700

Dara Navaei started review HD-DEN-16693-2

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 08 Mar 2024 16:16:11 -0800

Dara Navaei committed f5d4fec on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BloodFlow.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Buttons.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Switches.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

HD-DEN-16693-1: closed by Dara Navaei

Dara Navaei — Fri, 08 Mar 2024 15:42:16 -0800

Dara Navaei Closed HD-DEN-16693-1

HD-DEN-16693-1: reviewers finished

Fri, 08 Mar 2024 15:42:00 -0800

Vinayakam Mani and Sean Nash finished reviewing HD-DEN-16693-1

HD-DEN-16693_Institutional Settings Implementation

HD-DEN-16693-1: comment by pvedantam "RESOLVED IN CODE WALKTHGROUGH"

pvedantam — Fri, 08 Mar 2024 15:33:10 -0800

pvedantam (deleted user) replied to pvedantam (deleted user) in HD-DEN-16693-1

RESOLVED IN CODE WALKTHGROUGH

HD-DEN-16693-1: comment by pvedantam "We did not check for the upper limit in the pas..."

pvedantam — Fri, 08 Mar 2024 15:16:10 -0800

pvedantam (deleted user) commented on HD-DEN-16693-1

We did not check for the upper limit in the past, does this add new rejection scenarios

HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 07 Mar 2024 15:13:57 -0800

Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1: comment by Dara Navaei "Done"

Dara Navaei — Thu, 07 Mar 2024 15:02:02 -0800

Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 07 Mar 2024 14:59:10 -0800

Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1: comment by Sean Nash "Add minimum check here too."

Sean Nash — Thu, 07 Mar 2024 14:58:16 -0800

Sean Nash commented on HD-DEN-16693-1

Add minimum check here too.

HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 07 Mar 2024 14:56:47 -0800

Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1: comment by Dara Navaei "Done"

Dara Navaei — Thu, 07 Mar 2024 14:46:22 -0800

Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

HD-DEN-16693-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 07 Mar 2024 14:41:12 -0800

Sean Nash replied to Dara Navaei in HD-DEN-16693-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1: comment by Dara Navaei "Done"

Dara Navaei — Thu, 07 Mar 2024 14:38:48 -0800

Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

HD-DEN-16693-1: comment by Sean Nash "Do we need to add check for minimum treatment d..."

Sean Nash — Thu, 07 Mar 2024 14:35:48 -0800

Sean Nash commented on HD-DEN-16693-1

Do we need to add check for minimum treatment duration?

HD-DEN-16693-1: comment by Sean Nash "Cast constant as (F32) as before."

Sean Nash — Thu, 07 Mar 2024 14:32:54 -0800

Sean Nash commented on HD-DEN-16693-1

Cast constant as (F32) as before.

HD-DEN-16693-1: comment by Dara Navaei "Done"

Dara Navaei — Thu, 07 Mar 2024 14:14:14 -0800

Dara Navaei replied to Sean Nash in HD-DEN-16693-1

Done

HD-DEN-16693-1: comment by Sean Nash "dialVolume is a volume (not a flow). Use const..."

Sean Nash — Thu, 07 Mar 2024 14:10:47 -0800

Sean Nash commented on HD-DEN-16693-1

dialVolume is a volume (not a flow). Use constant (as before) for dialVolume check.

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16693 removed the events in the treatment events list that are not mentioned in the PRS

Dara Navaei — Tue, 05 Mar 2024 15:22:45 -0800

Dara Navaei committed 580a23d on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 41 more in hdfirmware

DEN-16693 removed the events in the treatment events list that are not mentioned in the PRS

· /firmware/App/Controllers/Buttons.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Switches.c	(-11, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SyringePump.c	(-5, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-4, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +0)	\| History	\| Source	\| Diff