Fisheye on hdfirmware/firmware/App/Modes/ModePreTreat.h

HD-DEN-16782-2: closed by Dara Navaei

Dara Navaei — Mon, 08 Apr 2024 14:31:28 -0700

Dara Navaei Closed HD-DEN-16782-2

HD-DEN-16782-2: reviewers finished

Mon, 08 Apr 2024 14:17:14 -0700

Sean Nash and Vinayakam Mani finished reviewing HD-DEN-16782-2

HD-DEN-16782_Unable TO Clear Communication Error Alarm 65 During Power Loss

HD-DEN-16782-2: reviewers added to HD-DEN-16782_Unable TO Clear Communication Error A...

Mon, 08 Apr 2024 11:58:37 -0700

Dara Navaei added Vinayakam Mani to HD-DEN-16782-2

HD-DEN-16782_Unable TO Clear Communication Error Alarm 65 During Power Loss

HD-DEN-16782-2: reviewers left HD-DEN-16782_Unable TO Clear Communication Error A...

Mon, 08 Apr 2024 11:58:37 -0700

Dara Navaei left HD-DEN-16782-2

HD-DEN-16782_Unable TO Clear Communication Error Alarm 65 During Power Loss

HD-DEN-16782-2: started by Dara Navaei

Dara Navaei — Fri, 05 Apr 2024 09:44:06 -0700

Dara Navaei started review HD-DEN-16782-2

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 05 Apr 2024 09:29:02 -0700

Dara Navaei committed e8edb83 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DGInterface.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-2, +2)	\| History	\| Source	\| Diff

HD-DEN-16782-1: closed by Vinayakam Mani

Vinayakam Mani — Fri, 05 Apr 2024 09:27:34 -0700

Vinayakam Mani Closed HD-DEN-16782-1

HD-DEN-16782-1: reviewers finished

Fri, 05 Apr 2024 09:24:16 -0700

Dara Navaei finished reviewing HD-DEN-16782-1

HD-DEN-16782_Unable TO Clear Communication Error Alarm 65 During Power Loss

HD-DEN-16782-1: reviewers finished

Thu, 04 Apr 2024 17:33:23 -0700

Sean Nash finished reviewing HD-DEN-16782-1

HD-DEN-16782_Unable TO Clear Communication Error Alarm 65 During Power Loss

HD-DEN-16782-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 04 Apr 2024 17:31:03 -0700

Sean Nash replied to Vinayakam Mani in HD-DEN-16782-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16782-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 04 Apr 2024 17:30:46 -0700

Sean Nash replied to Vinayakam Mani in HD-DEN-16782-1

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16782-1: comment by Vinayakam Mani "Done."

Vinayakam Mani — Tue, 02 Apr 2024 11:31:54 -0700

Vinayakam Mani replied to Sean Nash in HD-DEN-16782-1

Done.

HD-DEN-16782-1: comment by Vinayakam Mani "Done."

Vinayakam Mani — Tue, 02 Apr 2024 11:31:27 -0700

Vinayakam Mani replied to Sean Nash in HD-DEN-16782-1

Done.

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): DEN-16782 addressing code review comments

Vinayakam Mani — Tue, 02 Apr 2024 11:21:36 -0700

Vinayakam Mani committed f373b6c on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 39 more in hdfirmware

DEN-16782 addressing code review comments

· /firmware/App/Controllers/DGInterface.c	(-25, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DGInterface.h	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.c	(-27, +26)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModePreTreat.h	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-4, +8)	\| History	\| Source	\| Diff

HD-DEN-16782-1: comment by Sean Nash "Does this need to be public?"

Sean Nash — Tue, 02 Apr 2024 09:12:32 -0700

Sean Nash commented on HD-DEN-16782-1

Does this need to be public?

HD-DEN-16782-1: comment by Sean Nash "There is already a function similar to this in ..."

Sean Nash — Tue, 02 Apr 2024 09:10:42 -0700

Sean Nash commented on HD-DEN-16782-1

There is already a function similar to this in pre-treatment mode module. Do we need both?

HD-DEN-16782-1: started by Dara Navaei

Dara Navaei — Mon, 01 Apr 2024 15:22:32 -0700

Dara Navaei started review HD-DEN-16782-1

hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 02 Jan 2024 10:53:49 -0800

Dara Navaei committed 736cc5b on branch DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2, DEN-16499-fw-message-list-testing-issues and 56 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodLeak.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Bubble.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Buttons.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DGInterface.c

(-3, +3)

| History

| Source

| Diff

… 102 more files in changeset.

HD-DEN-13460-2: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 09:43:10 -0700

Dara Navaei Closed HD-DEN-13460-2

HD-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 09:42:55 -0700

Dara Navaei replied to Dara Navaei in HD-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

HD-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 09:42:47 -0700

Dara Navaei replied to wbracken (deleted user) in HD-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

HD-DEN-13460-2: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 09:41:49 -0700

Dara Navaei started review HD-DEN-13460-2

HD-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 09:22:19 -0700

Dara Navaei replied to Dara Navaei in HD-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

HD-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 09:20:09 -0700

Dara Navaei replied to Dara Navaei in HD-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

HD-DEN-13801-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 09:16:12 -0700

Dara Navaei Closed HD-DEN-13801-1

HD-DEN-13801-1: reviewers finished

Thu, 19 Oct 2023 09:16:06 -0700

Dara Navaei finished reviewing HD-DEN-13801-1

HD-DEN-13801_SW Dev Sprint 79 MG

HD-DEN-13801-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Thu, 19 Oct 2023 09:15:52 -0700

Dara Navaei replied to Sean Nash in HD-DEN-13801-1

RESOLVED in CODE WALKTHROUGH

HD-DEN-13801-1: started by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 09:15:21 -0700

Dara Navaei started review HD-DEN-13801-1

HD-DEN-14561-1: closed by Dara Navaei

Dara Navaei — Thu, 19 Oct 2023 09:07:33 -0700

Dara Navaei Closed HD-DEN-14561-1

HD-DEN-14561-1: reviewers finished

Thu, 19 Oct 2023 09:07:25 -0700

Dara Navaei finished reviewing HD-DEN-14561-1

HD-DEN-14561_Release Preprocessor Flag Specifies Code That Conflicts With SW Config Debug