Fisheye on hdfirmware/firmware/App/Modes/ModeStandby.h https://devapps.diality.us/changelog/~br%3DDENBUG-241-dialysate-flow-rate-cannot-be/hdfirmware/firmware/App/Modes/ModeStandby.h Recent activity in "hdfirmware" under directory /firmware/App/Modes/ModeStandby.h HD-DEN-16680-2: closed by Dara Navaei Wed, 09 Oct 2024 11:12:20 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16680-2 https://devapps.diality.us/cru/HD-DEN-16680-2 Dara Navaei Closed HD-DEN-16680-2 ]]> HD-DEN-16680-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH on behalf of [~sna..." Wed, 09 Oct 2024 11:12:10 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16680-2/#c20443 https://devapps.diality.us/cru/HD-DEN-16680-2/#c20443 Dara Navaei replied to Dara Navaei in HD-DEN-16680-2

RESOLVED in CODE WALKTHROUGH on behalf of Sean Nash

]]> HD-DEN-16680-2: started by Dara Navaei Wed, 09 Oct 2024 11:11:31 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16680-2 https://devapps.diality.us/cru/HD-DEN-16680-2 Dara Navaei started review HD-DEN-16680-2 ]]> HD-DEN-17053-1: closed by Dara Navaei Fri, 20 Sep 2024 16:40:04 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-17053-1 https://devapps.diality.us/cru/HD-DEN-17053-1 Dara Navaei Closed HD-DEN-17053-1 ]]> HD-DEN-17053-1: reviewers finished Fri, 20 Sep 2024 14:35:58 -0700 https://devapps.diality.us/cru/HD-DEN-17053-1 https://devapps.diality.us/cru/HD-DEN-17053-1 Sean Nash , Vinayakam Mani and Michael Garthwaite finished reviewing HD-DEN-17053-1 HD-DEN-17053_Release 17 Firmware Update ]]> HD-DEN-17053-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Mon, 16 Sep 2024 11:11:03 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-17053-1/#c20215 https://devapps.diality.us/cru/HD-DEN-17053-1/#c20215 Sean Nash replied to Dara Navaei in HD-DEN-17053-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-17053-1: comment by Dara Navaei "Done" Fri, 13 Sep 2024 12:15:14 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-17053-1/#c20207 https://devapps.diality.us/cru/HD-DEN-17053-1/#c20207 Dara Navaei replied to Sean Nash in HD-DEN-17053-1

Done

]]> HD-DEN-17053-1: comment by Sean Nash "Remove extra blank line." Fri, 13 Sep 2024 11:46:11 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-17053-1/#c20203 https://devapps.diality.us/cru/HD-DEN-17053-1/#c20203 Sean Nash commented on HD-DEN-17053-1

Remove extra blank line.

]]> HD-DEN-17053-1: started by Dara Navaei Fri, 13 Sep 2024 10:22:22 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-17053-1 https://devapps.diality.us/cru/HD-DEN-17053-1 Dara Navaei started review HD-DEN-17053-1 ]]> HD-DEN-16680-2: reviewers finished Wed, 28 Aug 2024 08:33:16 -0700 https://devapps.diality.us/cru/HD-DEN-16680-2 https://devapps.diality.us/cru/HD-DEN-16680-2 Sean Nash finished reviewing HD-DEN-16680-2 HD-DEN-16680_P1B Inlet Water Shutdown During Heat Disinfect Staging ]]> HD-DEN-16680-2: reviewers finished Tue, 27 Aug 2024 16:23:58 -0700 https://devapps.diality.us/cru/HD-DEN-16680-2 https://devapps.diality.us/cru/HD-DEN-16680-2 Vinayakam Mani finished reviewing HD-DEN-16680-2 HD-DEN-16680_P1B Inlet Water Shutdown During Heat Disinfect Staging ]]> HD-DEN-16680-2: comment by Dara Navaei "Done" Tue, 27 Aug 2024 10:05:54 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16680-2/#c19854 https://devapps.diality.us/cru/HD-DEN-16680-2/#c19854 Dara Navaei replied to Sean Nash in HD-DEN-16680-2

Done

]]> HD-DEN-16680-2: comment by Sean Nash "Param is wrong." Tue, 27 Aug 2024 09:56:19 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16680-2/#c19849 https://devapps.diality.us/cru/HD-DEN-16680-2/#c19849 Sean Nash commented on HD-DEN-16680-2

Param is wrong.

]]> HD-DEN-16680-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 27 Aug 2024 09:53:09 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16680-2/#c19848 https://devapps.diality.us/cru/HD-DEN-16680-2/#c19848 Sean Nash replied to Dara Navaei in HD-DEN-16680-2

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16680-2: comment by Dara Navaei "This is just the active cool mode by itself." Mon, 15 Jul 2024 10:46:58 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16680-2/#c19812 https://devapps.diality.us/cru/HD-DEN-16680-2/#c19812 Dara Navaei replied to Sean Nash in HD-DEN-16680-2

This is just the active cool mode by itself.

]]> HD-DEN-16680-2: comment by Sean Nash "We didn't have this before?" Mon, 01 Jul 2024 16:45:39 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16680-2/#c19799 https://devapps.diality.us/cru/HD-DEN-16680-2/#c19799 Sean Nash commented on HD-DEN-16680-2

We didn't have this before?

]]> HD-DEN-16773-2: closed by Dara Navaei Tue, 19 Mar 2024 19:07:45 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-2 https://devapps.diality.us/cru/HD-DEN-16773-2 Dara Navaei Closed HD-DEN-16773-2 ]]> HD-DEN-16773-2: reviewers finished Tue, 19 Mar 2024 18:13:56 -0700 https://devapps.diality.us/cru/HD-DEN-16773-2 https://devapps.diality.us/cru/HD-DEN-16773-2 Sean Nash and Vinayakam Mani finished reviewing HD-DEN-16773-2 HD-DEN-16773_Add Chemical Disinfect Enable Institutional Record 2 ]]> HD-DEN-16773-2: reviewers added to HD-DEN-16773_Add Chemical Disinfect Enable Institu... Tue, 19 Mar 2024 17:26:54 -0700 https://devapps.diality.us/cru/HD-DEN-16773-2 https://devapps.diality.us/cru/HD-DEN-16773-2 Dara Navaei added pvedantam  (deleted user) to HD-DEN-16773-2 HD-DEN-16773_Add Chemical Disinfect Enable Institutional Record 2 ]]> hdfirmware (DENBUG-285-alarm-141-air-trap-fill-timeout-end-tx-back-p1b-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Tue, 19 Mar 2024 16:48:56 -0700 Dara Navaei https://devapps.diality.us/changelog/hdfirmware?cs=c3043e70dbb4f955d76510073f739d53d61707fe https://devapps.diality.us/changelog/hdfirmware?cs=c3043e70dbb4f955d76510073f739d53d61707fe Dara Navaei committed c3043e7 on branch DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise, DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging and 40 more in hdfirmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeTreatmentParams.c (-1, +1) | History | Source | Diff
· /firmware/App/Services/SystemCommMessages.c (-1, +1) | History | Source | Diff
]]> HD-DEN-16773-1: closed by Dara Navaei Tue, 19 Mar 2024 16:26:22 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-1 https://devapps.diality.us/cru/HD-DEN-16773-1 Dara Navaei Closed HD-DEN-16773-1 ]]> HD-DEN-16773-1: reviewers finished Tue, 19 Mar 2024 16:23:26 -0700 https://devapps.diality.us/cru/HD-DEN-16773-1 https://devapps.diality.us/cru/HD-DEN-16773-1 pvedantam  (deleted user) , Sean Nash and Vinayakam Mani finished reviewing HD-DEN-16773-1 HD-DEN-16773_Add Chemical Disinfect Enable TO The Institutional Record ]]> HD-DEN-16773-2: started by Dara Navaei Tue, 19 Mar 2024 16:11:23 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-2 https://devapps.diality.us/cru/HD-DEN-16773-2 Dara Navaei started review HD-DEN-16773-2 ]]> HD-DEN-16773-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 19 Mar 2024 10:03:56 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16773-1/#c19645 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19645 Sean Nash replied to Dara Navaei in HD-DEN-16773-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16773-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 19 Mar 2024 10:03:34 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16773-1/#c19644 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19644 Sean Nash replied to Dara Navaei in HD-DEN-16773-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16773-1: comment by Dara Navaei "Done" Tue, 19 Mar 2024 09:29:59 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-1/#c19643 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19643 Dara Navaei replied to Sean Nash in HD-DEN-16773-1

Done

]]> HD-DEN-16773-1: comment by Dara Navaei "Done" Tue, 19 Mar 2024 09:29:52 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-1/#c19642 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19642 Dara Navaei replied to Sean Nash in HD-DEN-16773-1

Done

]]> HD-DEN-16773-1: comment by Sean Nash "It's 1 line of code either way. Just on top or..." Tue, 19 Mar 2024 08:55:11 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16773-1/#c19641 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19641 Sean Nash replied to Dara Navaei in HD-DEN-16773-1

It's 1 line of code either way. Just on top or below in an else. Vectorcast will see as a branch you need to test either way.
If you put it in an else, the processor does less work and I think it's a lot easier to read.

]]> HD-DEN-16773-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Tue, 19 Mar 2024 08:54:00 -0700 Sean Nash https://devapps.diality.us/cru/HD-DEN-16773-1/#c19640 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19640 Sean Nash replied to Dara Navaei in HD-DEN-16773-1

RESOLVED in CODE WALKTHROUGH.

]]> HD-DEN-16773-1: comment by Dara Navaei "I thought about having an else below but this w..." Tue, 19 Mar 2024 08:28:07 -0700 Dara Navaei https://devapps.diality.us/cru/HD-DEN-16773-1/#c19639 https://devapps.diality.us/cru/HD-DEN-16773-1/#c19639 Dara Navaei replied to Sean Nash in HD-DEN-16773-1

I thought about having an else below but this way we write less code. I have done similar in the past.

]]>