Fisheye on dgfirmware/firmware/App/Controllers/ConcentratePumps.c

DG-DENBUG-298-1: closed by Dara Navaei

Dara Navaei — Thu, 10 Apr 2025 15:09:27 -0700

Dara Navaei Closed DG-DENBUG-298-1

DG-DENBUG-298-1: reviewers finished

Wed, 09 Apr 2025 16:43:33 -0700

Michael Garthwaite and Sean Nash finished reviewing DG-DENBUG-298-1

DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging

DG-DENBUG-298-1: started by Dara Navaei

Dara Navaei — Tue, 08 Apr 2025 14:25:08 -0700

Dara Navaei started review DG-DENBUG-298-1

dgfirmware (DEN-17298-release_22_vc-staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 04 Apr 2025 15:46:58 -0700

Dara Navaei committed 8a89e04 on branch DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff

DG-DENBUG-307-1: closed by Dara Navaei

Dara Navaei — Fri, 04 Apr 2025 15:04:50 -0700

Dara Navaei Closed DG-DENBUG-307-1

DG-DENBUG-307-1: reviewers finished

Fri, 04 Apr 2025 11:00:43 -0700

Michael Garthwaite finished reviewing DG-DENBUG-307-1

DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging

DG-DENBUG-307-1: reviewers finished

Wed, 02 Apr 2025 11:14:02 -0700

Sean Nash finished reviewing DG-DENBUG-307-1

DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging

DG-DENBUG-307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 02 Apr 2025 11:13:55 -0700

Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

RESOLVED in CODE WALKTHROUGH.

DG-DENBUG-307-1: comment by Sean Nash "Not needed, but benign. RESOLVED in CODE WALKT..."

Sean Nash — Wed, 02 Apr 2025 11:13:43 -0700

Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

DG-DENBUG-307-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 02 Apr 2025 11:13:11 -0700

Sean Nash replied to Dara Navaei in DG-DENBUG-307-1

RESOLVED in CODE WALKTHROUGH.

dgfirmware (DENBUG-327-baro-sensor-data-refresh-staging): DEN-17263 addressed the code review comments

Dara Navaei — Wed, 02 Apr 2025 10:45:09 -0700

Dara Navaei committed e764f4a on branch DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 5 more in dgfirmware

DEN-17263 addressed the code review comments

· /firmware/App/Controllers/ConcentratePumps.c

(-22, +7)

| History

| Source

| Diff

DG-DENBUG-307-1: comment by Dara Navaei "Done"

Dara Navaei — Wed, 02 Apr 2025 10:28:52 -0700

Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

Done

DG-DENBUG-307-1: comment by Dara Navaei "Done"

Dara Navaei — Wed, 02 Apr 2025 10:27:50 -0700

Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

Done

DG-DENBUG-307-1: comment by Dara Navaei "I used fabs so all are positive when monitoring..."

Dara Navaei — Wed, 02 Apr 2025 10:26:21 -0700

Dara Navaei replied to Sean Nash in DG-DENBUG-307-1

I used fabs so all are positive when monitoring is started.

DG-DENBUG-307-1: comment by Sean Nash "This check doesn't make sense to me. Measured ..."

Sean Nash — Tue, 01 Apr 2025 09:03:02 -0700

Sean Nash commented on DG-DENBUG-307-1

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

DG-DENBUG-307-1: comment by Sean Nash "Aren't speeds (commanded and measured) always p..."

Sean Nash — Tue, 01 Apr 2025 09:01:22 -0700

Sean Nash commented on DG-DENBUG-307-1

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

DG-DENBUG-307-1: comment by Sean Nash "Measured speed (whether real or override) shoul..."

Sean Nash — Tue, 01 Apr 2025 08:59:42 -0700

Sean Nash commented on DG-DENBUG-307-1

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

dgfirmware (DENBUG-327-baro-sensor-data-refresh-staging): DENBUG-314 added more comment

Dara Navaei — Tue, 25 Mar 2025 15:25:32 -0700

Dara Navaei committed b85e597 on branch DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 5 more in dgfirmware

DENBUG-314 added more comment

· /firmware/App/Controllers/ConcentratePumps.c

(-0, +1)

| History

| Source

| Diff

dgfirmware (DENBUG-327-baro-sensor-data-refresh-staging): DEN-17263 fixed the code to check the direction of the concentrate pumps and then decide based on that whether the measu...

Dara Navaei — Mon, 24 Mar 2025 13:55:02 -0700

Dara Navaei committed 32e90c9 on branch DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 5 more in dgfirmware

DEN-17263 fixed the code to check the direction of the concentrate pumps and then decide based on that whether the measured speed values being negative or positive is correct or not

· /firmware/App/Controllers/ConcentratePumps.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DENBUG-327-baro-sensor-data-refresh-staging): DEN-17263 added code to check the concentrate pumps speed direction

Dara Navaei — Mon, 24 Mar 2025 11:15:43 -0700

Dara Navaei committed 4a55794 on branch DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 5 more in dgfirmware

DEN-17263 added code to check the concentrate pumps speed direction

· /firmware/App/Controllers/ConcentratePumps.c

(-0, +11)

| History

| Source

| Diff

dgfirmware (DENBUG-327-baro-sensor-data-refresh-staging): DENBUG-307 added code to broadcast the concentrate pumps speed the way they are regardless of the direction of the pump

Dara Navaei — Mon, 24 Mar 2025 09:52:37 -0700

Dara Navaei committed 7d4008c on branch DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 5 more in dgfirmware

DENBUG-307 added code to broadcast the concentrate pumps speed the way they are regardless of the direction of the pump

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +7)

| History

| Source

| Diff

dgfirmware (DENBUG-327-baro-sensor-data-refresh-staging): DENBUG-307 made the concentrate pumps speed check all absolute to be able to check both positive and negative targets an...

Dara Navaei — Mon, 24 Mar 2025 09:41:14 -0700

Dara Navaei committed 7d6cf3f on branch DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 5 more in dgfirmware

DENBUG-307 made the concentrate pumps speed check all absolute to be able to check both positive and negative targets and measured speeds

· /firmware/App/Controllers/ConcentratePumps.c

(-5, +6)

| History

| Source

| Diff

dgfirmware (DENBUG-327-baro-sensor-data-refresh-staging): DEN-17263 change the concentrate pumps speed check to not use fabs for the measured values. The target speed is checked ...

Dara Navaei — Fri, 21 Mar 2025 13:49:27 -0700

Dara Navaei committed c20dacd on branch DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 5 more in dgfirmware

DEN-17263 change the concentrate pumps speed check to not use fabs for the measured values. The target speed is checked in fabs to cover the negative target speeds

· /firmware/App/Controllers/ConcentratePumps.c

(-3, +4)

| History

| Source

| Diff

dgfirmware (DENBUG-327-baro-sensor-data-refresh-staging): DENBUG-309 added mode flush to the 5% tolerance of the concentrate pumps speed check

Dara Navaei — Tue, 18 Mar 2025 15:40:53 -0700

Dara Navaei committed df0df23 on branch DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 5 more in dgfirmware

DENBUG-309 added mode flush to the 5% tolerance of the concentrate pumps speed check

· /firmware/App/Controllers/ConcentratePumps.c

(-3, +8)

| History

| Source

| Diff

dgfirmware (DENBUG-327-baro-sensor-data-refresh-staging): DENBUG-309 changed the concnetrate pumps speed monitor to 5% in heat disinfect

Dara Navaei — Fri, 07 Mar 2025 14:49:39 -0800

Dara Navaei committed d5fb5e8 on branch DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 5 more in dgfirmware

DENBUG-309 changed the concnetrate pumps speed monitor to 5% in heat disinfect

· /firmware/App/Controllers/ConcentratePumps.c

(-6, +9)

| History

| Source

| Diff

DG-DENBUG-307-1: started by Dara Navaei

Dara Navaei — Fri, 07 Mar 2025 11:32:56 -0800

Dara Navaei started review DG-DENBUG-307-1

DG-DEN-17220-1: closed by Dara Navaei

Dara Navaei — Fri, 07 Feb 2025 16:12:39 -0800

Dara Navaei Closed DG-DEN-17220-1

DG-DEN-17220-1: reviewers finished

Fri, 07 Feb 2025 10:03:27 -0800

jpaguio (deleted user) and Sean Nash finished reviewing DG-DEN-17220-1

DG-DEN-17220_Release 20 P1B Staging

DG-DEN-17220-1: started by Dara Navaei

Dara Navaei — Thu, 06 Feb 2025 14:19:30 -0800

Dara Navaei started review DG-DEN-17220-1

DG-DEN-17135-1: closed by Dara Navaei

Dara Navaei — Fri, 31 Jan 2025 16:57:30 -0800

Dara Navaei Closed DG-DEN-17135-1