Fisheye on hdfirmware/firmware/App/Services/SystemCommMessages.h

BOOTLOADER-DEN-14892-3: started by Dara Navaei

Dara Navaei — Sun, 11 Jan 2026 17:23:59 -0800

Dara Navaei started review BOOTLOADER-DEN-14892-3

BOOTLOADER-DEN-14892-2: started by Dara Navaei

Dara Navaei — Sun, 11 Jan 2026 17:11:25 -0800

Dara Navaei started review BOOTLOADER-DEN-14892-2

BOOTLOADER-DEN-14892-3: Needs Fixing by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:42:18 -0800

Dara Navaei Needs Fixing BOOTLOADER-DEN-14892-3

BOOTLOADER-DEN-14892-3: Abandoned by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:42:14 -0800

Dara Navaei Abandoned BOOTLOADER-DEN-14892-3

BOOTLOADER-DEN-14892-2: Needs Fixing by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:39:18 -0800

Dara Navaei Needs Fixing BOOTLOADER-DEN-14892-2

BOOTLOADER-DEN-14892-2: Abandoned by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:39:14 -0800

Dara Navaei Abandoned BOOTLOADER-DEN-14892-2

HD-DEN-17299-1: closed by Dara Navaei

Dara Navaei — Mon, 16 Jun 2025 16:26:27 -0700

Dara Navaei Closed HD-DEN-17299-1

HD-DEN-17299-1: reviewers finished

Mon, 16 Jun 2025 15:24:34 -0700

Michael Garthwaite finished reviewing HD-DEN-17299-1

HD-DEN-17299_Release 22 P1B Staging

HD-DEN-17299-1: reviewers finished

Fri, 13 Jun 2025 14:34:14 -0700

Sean Nash finished reviewing HD-DEN-17299-1

HD-DEN-17299_Release 22 P1B Staging

HD-DEN-17299-1: started by Dara Navaei

Dara Navaei — Fri, 13 Jun 2025 09:12:21 -0700

Dara Navaei started review HD-DEN-17299-1

hdfirmware (DENBUG-328-venous-pressure-alarm-did-not-trigger-alarm-215-STAGING): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 12 Jun 2025 15:21:22 -0700

Dara Navaei committed 592af09 on branch DENBUG-326-syringe-switch-detection-failure_staging, DENBUG-328-venous-pressure-alarm-did-not-trigger-alarm-215-STAGING and 4 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DGInterface.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

HD-DENBUG-318-1: closed by Dara Navaei

Dara Navaei — Thu, 12 Jun 2025 15:01:25 -0700

Dara Navaei Closed HD-DENBUG-318-1

HD-DENBUG-318-1: reviewers finished

Mon, 09 Jun 2025 09:34:07 -0700

Michael Garthwaite finished reviewing HD-DENBUG-318-1

HD-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging

HD-DENBUG-318-1: reviewers finished

Thu, 29 May 2025 16:12:33 -0700

Sean Nash finished reviewing HD-DENBUG-318-1

HD-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging

hdfirmware (DENBUG-328-venous-pressure-alarm-did-not-trigger-alarm-215-STAGING): DENBUG-318 updated the code to include all the DG institutional values upon requesting from DG in HD

Dara Navaei — Thu, 22 May 2025 17:37:17 -0700

Dara Navaei committed a6822e8 on branch DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging, DENBUG-326-syringe-switch-detection-failure_staging and 5 more in hdfirmware

DENBUG-318 updated the code to include all the DG institutional values upon requesting from DG in HD

· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-7, +9)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

HD-DENBUG-318-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH"

Sean Nash — Wed, 21 May 2025 09:04:44 -0700

Sean Nash replied to Dara Navaei in HD-DENBUG-318-1

RESOLVED in CODE WALKTHROUGH

HD-DENBUG-318-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 20 May 2025 16:04:40 -0700

Dara Navaei replied to Sean Nash in HD-DENBUG-318-1

Done

hdfirmware (DENBUG-328-venous-pressure-alarm-did-not-trigger-alarm-215-STAGING): DENBUG-320 added the word max to the RO rejection ratio

Dara Navaei — Tue, 20 May 2025 14:03:39 -0700

Dara Navaei committed aef3220 on branch DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging, DENBUG-326-syringe-switch-detection-failure_staging and 5 more in hdfirmware

DENBUG-320 added the word max to the RO rejection ratio

· /firmware/App/Controllers/DGInterface.c	(-6, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-6, +6)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

HD-DENBUG-318-1: comment by Sean Nash "This is not really a rej ratio - it's a maximum..."

Sean Nash — Tue, 20 May 2025 10:45:59 -0700

Sean Nash commented on HD-DENBUG-318-1

This is not really a rej ratio - it's a maximum reg ratio. We should make that clear in naming #defines, field names, etc...

hdfirmware (DENBUG-328-venous-pressure-alarm-did-not-trigger-alarm-215-STAGING): DENBUG-318 added code to range check the RO rejection ratio in HD institutional record and send it to DG upon request fr...

Dara Navaei — Mon, 19 May 2025 10:30:00 -0700

Dara Navaei committed e42bc54 on branch DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging, DENBUG-326-syringe-switch-detection-failure_staging and 5 more in hdfirmware

DENBUG-318 added code to range check the RO rejection ratio in HD institutional record and send it to DG upon request from DG

· /firmware/App/Modes/ModeTreatmentParams.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +29)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

HD-DENBUG-318-1: started by Dara Navaei

Dara Navaei — Fri, 16 May 2025 14:41:40 -0700

Dara Navaei started review HD-DENBUG-318-1

HD-DENBUG-298-2: closed by Dara Navaei

Dara Navaei — Thu, 10 Apr 2025 15:01:07 -0700

Dara Navaei Closed HD-DENBUG-298-2

HD-DENBUG-298-2: reviewers finished

Wed, 09 Apr 2025 16:45:04 -0700

Michael Garthwaite and Sean Nash finished reviewing HD-DENBUG-298-2

HD-DENBUG-298_User Unable TO Deliver Saline P1B Staging

HD-DENBUG-298-2: started by Dara Navaei

Dara Navaei — Tue, 08 Apr 2025 14:25:29 -0700

Dara Navaei started review HD-DENBUG-298-2

hdfirmware (DEN-17273-release_21_cpp_check_fix_staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 04 Apr 2025 15:01:21 -0700

Dara Navaei committed 371355c on branch DEN-17271-saline-bolus-doxygen-update, DEN-17273-release_21_cpp_check_fix_staging and 7 more in hdfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DialInFlow.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/DialInFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/Dialysis.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/Dialysis.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModePostTreat.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeStandby.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatment.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeTreatment.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/OperationModes.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/Prime.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/Rinseback.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/SalineBolus.c

(-0, +16)

| History

| Source

| Diff

· /firmware/App/Modes/SalineBolus.h

(-0, +16)

| History

| Source

| Diff

· /firmware/App/Modes/TreatmentRecirc.c

(-2, +2)

| History

| Source

| Diff

… 5 more files in changeset.

HD-DENBUG-298-1: closed by Dara Navaei

Dara Navaei — Fri, 04 Apr 2025 14:57:54 -0700

Dara Navaei Closed HD-DENBUG-298-1

HD-DENBUG-298-1: reviewers finished

Fri, 04 Apr 2025 13:56:36 -0700

Michael Garthwaite and Sean Nash finished reviewing HD-DENBUG-298-1

HD-DENBUG-298_User Unable TO Deliver Saline Bolus During Alarm Conditions Where The Blood Pump IS Recirculating

HD-DENBUG-298-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Fri, 04 Apr 2025 12:50:09 -0700

Sean Nash replied to Dara Navaei in HD-DENBUG-298-1

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1: comment by Dara Navaei "Done"

Dara Navaei — Fri, 04 Apr 2025 12:47:27 -0700

Dara Navaei replied to Sean Nash in HD-DENBUG-298-1

Done

HD-DENBUG-298-1: comment by Sean Nash "Bad practice to have two calls to same function..."

Sean Nash — Fri, 04 Apr 2025 12:37:00 -0700

Sean Nash commented on HD-DENBUG-298-1

Bad practice to have two calls to same function here. Possible that 2nd call will return different result.
Should call function once to assign value to a local var prior to if statement and then reference the local var in the if statement.