Fisheye on fwcommon/Integrity.c

fwcommon (staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 11 May 2026 10:13:52 -0700

Dara Navaei committed d5da2d8 on branch DENBUG-335-air-trap-fill-design-improvem, staging in fwcommon

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /Accel.c

(-1, +1)

| History

| Source

| Diff

· /Accel.h

(-1, +1)

| History

| Source

| Diff

· /Common.h

(-1, +1)

| History

| Source

| Diff

· /Integrity.c

(-1, +1)

| History

| Source

| Diff

· /Integrity.h

(-1, +1)

| History

| Source

| Diff

· /MessageSupport.c

(-1, +1)

| History

| Source

| Diff

· /MessageSupport.h

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmt.c

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmt.h

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmtDGRecords.h

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmtHDRecords.h

(-1, +1)

| History

| Source

| Diff

· /PersistentAlarm.c

(-1, +1)

| History

| Source

| Diff

· /PersistentAlarm.h

(-1, +1)

| History

| Source

| Diff

· /RTC.c

(-1, +1)

| History

| Source

| Diff

· /RTC.h

(-1, +1)

| History

| Source

| Diff

… 7 more files in changeset.

BOOTLOADER-DEN-14892-2: started by Dara Navaei

Dara Navaei — Sun, 11 Jan 2026 17:11:25 -0800

Dara Navaei started review BOOTLOADER-DEN-14892-2

BOOTLOADER-DEN-14892-2: Needs Fixing by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:39:18 -0800

Dara Navaei Needs Fixing BOOTLOADER-DEN-14892-2

BOOTLOADER-DEN-14892-2: Abandoned by Dara Navaei

Dara Navaei — Tue, 23 Dec 2025 18:39:14 -0800

Dara Navaei Abandoned BOOTLOADER-DEN-14892-2

fwcommon (DENBUG-335-air-trap-fill-design-improvem): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 29 Jan 2025 18:08:46 -0800

Dara Navaei committed 60705e2 on branch DEN-17234-alarm_68_fix_in_expedite_pretreatment, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more in fwcommon

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /Accel.c

(-1, +1)

| History

| Source

| Diff

· /Accel.h

(-1, +1)

| History

| Source

| Diff

· /Common.h

(-1, +1)

| History

| Source

| Diff

· /Integrity.c

(-1, +1)

| History

| Source

| Diff

· /Integrity.h

(-1, +1)

| History

| Source

| Diff

· /MessageSupport.c

(-1, +1)

| History

| Source

| Diff

· /MessageSupport.h

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmt.c

(-2, +2)

| History

| Source

| Diff

· /NVDataMgmt.h

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmtDGRecords.h

(-2, +2)

| History

| Source

| Diff

· /NVDataMgmtHDRecords.h

(-1, +1)

| History

| Source

| Diff

· /PersistentAlarm.c

(-1, +1)

| History

| Source

| Diff

· /PersistentAlarm.h

(-1, +1)

| History

| Source

| Diff

· /RTC.c

(-1, +1)

| History

| Source

| Diff

· /RTC.h

(-1, +1)

| History

| Source

| Diff

… 7 more files in changeset.

DG-DEN-16565-1: closed by Dara Navaei

Dara Navaei — Fri, 15 Nov 2024 12:58:01 -0800

Dara Navaei Closed DG-DEN-16565-1

HD-DEN-14892-3: closed by Dara Navaei

Dara Navaei — Fri, 15 Nov 2024 12:53:48 -0800

Dara Navaei Closed HD-DEN-14892-3

DG-DEN-16565-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 06 Jun 2024 10:48:28 -0700

Sean Nash replied to Sean Nash in DG-DEN-16565-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16565-1: comment by Sean Nash "Can we get by with just 1 msg? Add doxygen com..."

Sean Nash — Thu, 06 Jun 2024 10:46:24 -0700

Sean Nash commented on DG-DEN-16565-1

Can we get by with just 1 msg? Add doxygen comments.

DG-DEN-16565-1: comment by Vinayakam Mani "we need to take care of existing stack size whi..."

Vinayakam Mani — Fri, 24 May 2024 11:59:33 -0700

Vinayakam Mani commented on DG-DEN-16565-1

we need to take care of existing stack size while we merge the bootloader changes. the current stack size is 0x3400, not 0x4C00.

DG-DEN-16565-1: comment by Sean Nash "Is bootloader going to use fwcommon code? Is #..."

Sean Nash — Tue, 02 Jan 2024 14:15:55 -0800

Sean Nash commented on DG-DEN-16565-1

Is bootloader going to use fwcommon code? Is #ifdef #else backwards?

DG-DEN-16565-1: comment by Sean Nash "Needed?"

Sean Nash — Tue, 02 Jan 2024 14:14:57 -0800

Sean Nash commented on DG-DEN-16565-1

Needed?

DG-DEN-16565-1: comment by Sean Nash "This is not user code. Next regen will restore..."

Sean Nash — Tue, 02 Jan 2024 14:13:25 -0800

Sean Nash commented on DG-DEN-16565-1

This is not user code. Next regen will restore this code. Do we really need to disable ECC test code?

DG-DEN-16565-1: comment by Sean Nash "This is not user code. Next regen will restore..."

Sean Nash — Tue, 02 Jan 2024 14:12:25 -0800

Sean Nash commented on DG-DEN-16565-1

This is not user code. Next regen will restore this code. Do we really need to remove this code?

DG-DEN-16565-1: comment by Sean Nash "What is this code doing? Why no comments? Is ..."

Sean Nash — Tue, 02 Jan 2024 14:11:49 -0800

Sean Nash commented on DG-DEN-16565-1

What is this code doing? Why no comments? Is it necessary?

DG-DEN-16565-1: comment by Sean Nash "#if 1 and #endif appear to be unnecessary. Rem..."

Sean Nash — Tue, 02 Jan 2024 14:11:05 -0800

Sean Nash commented on DG-DEN-16565-1

#if 1 and #endif appear to be unnecessary. Remove.

DG-DEN-16565-1: comment by Sean Nash "Remove duplicate user code start comment."

Sean Nash — Tue, 02 Jan 2024 14:10:15 -0800

Sean Nash commented on DG-DEN-16565-1

Remove duplicate user code start comment.

DG-DEN-16565-1: comment by Sean Nash "This is not user code. Next regen will restore..."

Sean Nash — Tue, 02 Jan 2024 14:09:15 -0800

Sean Nash commented on DG-DEN-16565-1

This is not user code. Next regen will restore this code. Do we really need to disable ECC error handling?

DG-DEN-16565-1: comment by Sean Nash "This is not user code. Next regen will restore..."

Sean Nash — Tue, 02 Jan 2024 14:08:15 -0800

Sean Nash commented on DG-DEN-16565-1

This is not user code. Next regen will restore this code. Do we really need to disable this?

DG-DEN-16565-1: comment by Sean Nash "Why one handler for 3 commands?"

Sean Nash — Tue, 02 Jan 2024 14:07:07 -0800

Sean Nash commented on DG-DEN-16565-1

Why one handler for 3 commands?

fwcommon (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 02 Jan 2024 10:53:47 -0800

Dara Navaei committed ed0b0d9 on branch master, DEN-16499-fw-message-list-testing-issues and 25 more in fwcommon

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /Accel.c

(-1, +1)

| History

| Source

| Diff

· /Accel.h

(-1, +1)

| History

| Source

| Diff

· /Common.h

(-1, +1)

| History

| Source

| Diff

· /Integrity.c

(-1, +1)

| History

| Source

| Diff

· /Integrity.h

(-1, +1)

| History

| Source

| Diff

· /MessageSupport.c

(-1, +1)

| History

| Source

| Diff

· /MessageSupport.h

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmt.c

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmt.h

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmtDGRecords.h

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmtHDRecords.h

(-1, +1)

| History

| Source

| Diff

· /PersistentAlarm.c

(-1, +1)

| History

| Source

| Diff

· /PersistentAlarm.h

(-1, +1)

| History

| Source

| Diff

· /RTC.c

(-1, +1)

| History

| Source

| Diff

· /RTC.h

(-1, +1)

| History

| Source

| Diff

… 7 more files in changeset.

DG-DEN-16565-1: comment by Sean Nash "Why aren't we calling the specific handlers for..."

Sean Nash — Fri, 22 Dec 2023 09:37:08 -0800

Sean Nash commented on DG-DEN-16565-1

Why aren't we calling the specific handlers for reboot and enter bootloader commands?

DG-DEN-16565-1: reviewers added to DG-DEN-16565_SW Updater HD DG App Side Intake From...

Fri, 22 Dec 2023 09:32:41 -0800

Sean Nash added Dana Rich to DG-DEN-16565-1

DG-DEN-16565_SW Updater HD DG App Side Intake From Sunrise

DG-DEN-16565-1: started by Dara Navaei

Dara Navaei — Mon, 18 Dec 2023 11:24:45 -0800

Dara Navaei started review DG-DEN-16565-1

DG-DEN-13460-2: closed by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 21:20:43 -0700

Dara Navaei Closed DG-DEN-13460-2

DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Wed, 18 Oct 2023 21:20:31 -0700

Dara Navaei replied to Sean Nash in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Wed, 18 Oct 2023 21:19:58 -0700

Dara Navaei replied to wbracken (deleted user) in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH"

Dara Navaei — Wed, 18 Oct 2023 21:19:26 -0700

Dara Navaei replied to wbracken (deleted user) in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

DG-DEN-13460-2: started by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 21:18:57 -0700

Dara Navaei started review DG-DEN-13460-2

DG-DEN-13598-2: closed by Dara Navaei

Dara Navaei — Wed, 18 Oct 2023 21:18:20 -0700

Dara Navaei Closed DG-DEN-13598-2