Fisheye on fwcommon/NVDataMgmtDGRecords.h

fwcommon (staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 11 May 2026 10:13:52 -0700

Dara Navaei committed d5da2d8 on branch DENBUG-335-air-trap-fill-design-improvem, staging in fwcommon

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /Accel.c

(-1, +1)

| History

| Source

| Diff

· /Accel.h

(-1, +1)

| History

| Source

| Diff

· /Common.h

(-1, +1)

| History

| Source

| Diff

· /Integrity.c

(-1, +1)

| History

| Source

| Diff

· /Integrity.h

(-1, +1)

| History

| Source

| Diff

· /MessageSupport.c

(-1, +1)

| History

| Source

| Diff

· /MessageSupport.h

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmt.c

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmt.h

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmtDGRecords.h

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmtHDRecords.h

(-1, +1)

| History

| Source

| Diff

· /PersistentAlarm.c

(-1, +1)

| History

| Source

| Diff

· /PersistentAlarm.h

(-1, +1)

| History

| Source

| Diff

· /RTC.c

(-1, +1)

| History

| Source

| Diff

· /RTC.h

(-1, +1)

| History

| Source

| Diff

… 7 more files in changeset.

DG-DEN-17220-1: closed by Dara Navaei

Dara Navaei — Fri, 07 Feb 2025 16:12:39 -0800

Dara Navaei Closed DG-DEN-17220-1

DG-DEN-17220-1: reviewers finished

Fri, 07 Feb 2025 10:03:27 -0800

jpaguio (deleted user) and Sean Nash finished reviewing DG-DEN-17220-1

DG-DEN-17220_Release 20 P1B Staging

DG-DEN-17220-1: started by Dara Navaei

Dara Navaei — Thu, 06 Feb 2025 14:19:30 -0800

Dara Navaei started review DG-DEN-17220-1

DG-DEN-17135-1: closed by Dara Navaei

Dara Navaei — Fri, 31 Jan 2025 16:57:30 -0800

Dara Navaei Closed DG-DEN-17135-1

DG-DEN-17135-1: reviewers finished

Thu, 30 Jan 2025 10:39:28 -0800

Sean Nash finished reviewing DG-DEN-17135-1

DG-DEN-17135_Concentrate Pump Calibration Staging

fwcommon (DENBUG-335-air-trap-fill-design-improvem): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 29 Jan 2025 18:08:46 -0800

Dara Navaei committed 60705e2 on branch DEN-17234-alarm_68_fix_in_expedite_pretreatment, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more in fwcommon

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /Accel.c

(-1, +1)

| History

| Source

| Diff

· /Accel.h

(-1, +1)

| History

| Source

| Diff

· /Common.h

(-1, +1)

| History

| Source

| Diff

· /Integrity.c

(-1, +1)

| History

| Source

| Diff

· /Integrity.h

(-1, +1)

| History

| Source

| Diff

· /MessageSupport.c

(-1, +1)

| History

| Source

| Diff

· /MessageSupport.h

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmt.c

(-2, +2)

| History

| Source

| Diff

· /NVDataMgmt.h

(-1, +1)

| History

| Source

| Diff

· /NVDataMgmtDGRecords.h

(-2, +2)

| History

| Source

| Diff

· /NVDataMgmtHDRecords.h

(-1, +1)

| History

| Source

| Diff

· /PersistentAlarm.c

(-1, +1)

| History

| Source

| Diff

· /PersistentAlarm.h

(-1, +1)

| History

| Source

| Diff

· /RTC.c

(-1, +1)

| History

| Source

| Diff

· /RTC.h

(-1, +1)

| History

| Source

| Diff

… 7 more files in changeset.

DG-DEN-17135-1: reviewers finished

Wed, 29 Jan 2025 17:32:19 -0800

Vinayakam Mani finished reviewing DG-DEN-17135-1

DG-DEN-17135_Concentrate Pump Calibration Staging

DG-DEN-17135-1: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH"

Vinayakam Mani — Wed, 29 Jan 2025 17:32:01 -0800

Vinayakam Mani replied to Dara Navaei in DG-DEN-17135-1

RESOLVED IN CODE WALKTHROUGH

DG-DEN-17135-1: comment by Dara Navaei "Updated the trigger condition. This is a calibr..."

Dara Navaei — Wed, 29 Jan 2025 17:22:53 -0800

Dara Navaei replied to Vinayakam Mani in DG-DEN-17135-1

Updated the trigger condition. This is a calibration and is checked in POST. The titles are POST.

DG-DEN-17135-1: comment by Vinayakam Mani "The Trigger condition is little confusing. coul..."

Vinayakam Mani — Wed, 29 Jan 2025 17:12:35 -0800

Vinayakam Mani commented on DG-DEN-17135-1

The Trigger condition is little confusing. could you please reword it? Also In title, do you want to add " fault", if it is DG fault property?

DG-DEN-17135-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 29 Jan 2025 17:14:25 -0800

Sean Nash replied to Dara Navaei in DG-DEN-17135-1

RESOLVED in CODE WALKTHROUGH.

fwcommon (DENBUG-335-air-trap-fill-design-improvem): DEN-17135 addressed the code review comments

Dara Navaei — Wed, 29 Jan 2025 16:30:58 -0800

Dara Navaei committed 681347e on branch DEN-17135-concentrate-pump-calibration-staging, DEN-17234-alarm_68_fix_in_expedite_pretreatment and 5 more in fwcommon

DEN-17135 addressed the code review comments

· /NVDataMgmt.c	(-31, +1)	\| History	\| Source	\| Diff
· /NVDataMgmtDGRecords.h	(-8, +0)	\| History	\| Source	\| Diff

DG-DEN-17135-1: comment by Dara Navaei "Removed the typecast."

Dara Navaei — Wed, 29 Jan 2025 16:28:49 -0800

Dara Navaei replied to Sean Nash in DG-DEN-17135-1

Removed the typecast.

DG-DEN-17135-1: comment by Sean Nash "Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T..."

Sean Nash — Wed, 29 Jan 2025 16:26:37 -0800

Sean Nash commented on DG-DEN-17135-1

Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T*) necessary? Seems like &concPump->concentratePumps[ i ] is already that type.

fwcommon (DENBUG-335-air-trap-fill-design-improvem): DEN-17135 updated the acid and concentrate pumps calibration records

Dara Navaei — Wed, 20 Nov 2024 10:49:36 -0800

Dara Navaei committed 19f9abb on branch DEN-17135-concentrate-pump-calibration-staging, DEN-17234-alarm_68_fix_in_expedite_pretreatment and 5 more in fwcommon

DEN-17135 updated the acid and concentrate pumps calibration records

· /NVDataMgmt.c	(-2, +3)	\| History	\| Source	\| Diff
· /NVDataMgmtDGRecords.h	(-4, +4)	\| History	\| Source	\| Diff

DG-DEN-17135-1: started by Dara Navaei

Dara Navaei — Wed, 20 Nov 2024 09:54:26 -0800

Dara Navaei started review DG-DEN-17135-1

DG-UCOMMITS-46: closed by Dara Navaei

Dara Navaei — Wed, 28 Aug 2024 09:22:21 -0700

Dara Navaei Closed DG-UCOMMITS-46

DG-UCOMMITS-46: started by Dara Navaei

Dara Navaei — Tue, 27 Aug 2024 16:38:54 -0700

Dara Navaei started review DG-UCOMMITS-46

DG-DEN-16674-2: closed by Dara Navaei

Dara Navaei — Fri, 01 Mar 2024 16:31:05 -0800

Dara Navaei Closed DG-DEN-16674-2

DG-DEN-16674-2: reviewers finished

Fri, 01 Mar 2024 16:21:45 -0800

Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16674-2

DG-DEN-16674_Td2 Calibration Feature

DG-DEN-16674-2: comment by Vinayakam Mani "RESOLVED IN CODE WALKTHROUGH"

Vinayakam Mani — Fri, 01 Mar 2024 16:21:27 -0800

Vinayakam Mani replied to Dara Navaei in DG-DEN-16674-2

RESOLVED IN CODE WALKTHROUGH

DG-DEN-16674-2: comment by Dara Navaei "Done"

Dara Navaei — Fri, 01 Mar 2024 15:50:52 -0800

Dara Navaei replied to Vinayakam Mani in DG-DEN-16674-2

Done

DG-DEN-16674-2: comment by Vinayakam Mani "Can we bring a parenthesis for better readabili..."

Vinayakam Mani — Fri, 01 Mar 2024 13:38:40 -0800

Vinayakam Mani commented on DG-DEN-16674-2

Can we bring a parenthesis for better readability?

DG-DEN-16674-2: reviewers added to DG-DEN-16674_Td2 Calibration Feature

Fri, 01 Mar 2024 10:54:45 -0800

Dara Navaei added Behrouz NematiPour to DG-DEN-16674-2

DG-DEN-16674_Td2 Calibration Feature

DG-DEN-16674-2: started by Dara Navaei

Dara Navaei — Fri, 01 Mar 2024 08:41:42 -0800

Dara Navaei started review DG-DEN-16674-2

fwcommon (DEN-17234-alarm_68_fix_in_expedite_pretreatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 29 Feb 2024 15:04:31 -0800

Dara Navaei committed 5f45d97 on branch master, DEN-16565-sw-updater-hd-dg-app-side-intake-from-sunrise and 23 more in fwcommon

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /NVDataMgmt.c	(-1, +1)	\| History	\| Source	\| Diff
· /NVDataMgmtDGRecords.h	(-1, +1)	\| History	\| Source	\| Diff

DG-DEN-16674-1: closed by Dara Navaei

Dara Navaei — Thu, 29 Feb 2024 14:45:27 -0800

Dara Navaei Closed DG-DEN-16674-1

DG-DEN-16674-1: reviewers finished

Thu, 29 Feb 2024 13:45:11 -0800

Sean Nash finished reviewing DG-DEN-16674-1

DG-DEN-16674_Td2 Calibration Feature

DG-DEN-16674-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Thu, 29 Feb 2024 13:44:32 -0800

Sean Nash replied to Dara Navaei in DG-DEN-16674-1

RESOLVED in CODE WALKTHROUGH.