Fisheye on hdfirmware/firmware/App/Controllers

HD-DENBUG-335-2: closed by Dara Navaei

Dara Navaei — Wed, 10 Jun 2026 17:57:08 -0700

Dara Navaei Closed HD-DENBUG-335-2

HD-DENBUG-335-2: reviewers finished

Wed, 10 Jun 2026 16:48:32 -0700

Dara Navaei finished reviewing HD-DENBUG-335-2

HD-DENBUG-335_Air Trap Fill Design Improvement P1B Staging

HD-DENBUG-335-2: reviewers finished

Tue, 09 Jun 2026 13:49:51 -0700

Vinayakam Mani finished reviewing HD-DENBUG-335-2

HD-DENBUG-335_Air Trap Fill Design Improvement P1B Staging

HD-DENBUG-335-1: closed by Dara Navaei

Dara Navaei — Mon, 08 Jun 2026 15:27:08 -0700

Dara Navaei Closed HD-DENBUG-335-1

HD-DENBUG-335-1: reviewers finished

Mon, 08 Jun 2026 15:25:59 -0700

Vinayakam Mani and Dara Navaei finished reviewing HD-DENBUG-335-1

HD-DENBUG-335_Air Trap Fill Design Improvem

HD-DENBUG-335-2: started by Dara Navaei

Dara Navaei — Mon, 08 Jun 2026 14:53:40 -0700

Dara Navaei started review HD-DENBUG-335-2

HD-DENBUG-335-1: started by Dara Navaei

Dara Navaei — Mon, 08 Jun 2026 13:40:14 -0700

Dara Navaei started review HD-DENBUG-335-1

hdfirmware (staging): DENBUG-335 changed the persistent time of alarm 215 from 60 seconds to 30 seconds

Dara Navaei — Mon, 08 Jun 2026 10:50:11 -0700

Dara Navaei committed b2a7684 on branch DENBUG-335-air-trap-fill-design-improvem, develop, staging in hdfirmware

DENBUG-335 changed the persistent time of alarm 215 from 60 seconds to 30 seconds

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

HD-DENBUG-335-1: comment by Vinayakam Mani "RESOLVED in CODE WALKTHROUGH"

Vinayakam Mani — Thu, 04 Jun 2026 17:28:25 -0700

Vinayakam Mani replied to Dara Navaei in HD-DENBUG-335-1

RESOLVED in CODE WALKTHROUGH

HD-DENBUG-335-1: comment by Dara Navaei "Done"

Dara Navaei — Thu, 04 Jun 2026 11:41:25 -0700

Dara Navaei replied to Sean Nash in HD-DENBUG-335-1

Done

HD-DENBUG-335-1: comment by Vinayakam Mani "RESOLVED in CODE WALKTHROUGH"

Vinayakam Mani — Mon, 01 Jun 2026 10:56:14 -0700

Vinayakam Mani replied to Dara Navaei in HD-DENBUG-335-1

RESOLVED in CODE WALKTHROUGH

HD-DENBUG-335-1: comment by Vinayakam Mani "RESOLVED in CODE WALKTHROUGH"

Vinayakam Mani — Mon, 01 Jun 2026 10:55:34 -0700

Vinayakam Mani replied to Dara Navaei in HD-DENBUG-335-1

RESOLVED in CODE WALKTHROUGH

HD-DENBUG-335-1: comment by Dara Navaei "The comment was left here to make sure the next..."

Dara Navaei — Mon, 01 Jun 2026 10:35:14 -0700

Dara Navaei replied to Vinayakam Mani in HD-DENBUG-335-1

The comment was left here to make sure the next developer does not ask the question that the blood pump was not set here. It is a note to remind the developer that the ramp is set below.

HD-DENBUG-335-1: comment by Vinayakam Mani "Can we move the comment where required?"

Vinayakam Mani — Mon, 01 Jun 2026 09:46:47 -0700

Vinayakam Mani replied to Dara Navaei in HD-DENBUG-335-1

Can we move the comment where required?

hdfirmware (staging): DENBUG-335 addressed the code review comments

Dara Navaei — Mon, 01 Jun 2026 08:43:40 -0700

Dara Navaei committed c4ad5e2 on branch DENBUG-335-air-trap-fill-design-improvem, develop, staging in hdfirmware

DENBUG-335 addressed the code review comments

· /firmware/App/Controllers/AirTrap.c

(-2, +1)

| History

| Source

| Diff

HD-DENBUG-335-1: comment by Sean Nash "Dara, work with Nick to get the right text for ..."

Sean Nash — Mon, 01 Jun 2026 08:31:47 -0700

Sean Nash replied to Vinayakam Mani in HD-DENBUG-335-1

Dara, work with Nick to get the right text for this new alarm.

HD-DENBUG-335-1: comment by Dara Navaei "We changed the order of ORs. But the parenthesi..."

Dara Navaei — Sun, 31 May 2026 19:32:19 -0700

Dara Navaei replied to Sean Nash in HD-DENBUG-335-1

We changed the order of ORs. But the parenthesis match otherwise, it would not compile.

HD-DENBUG-335-1: comment by Dara Navaei "Done"

Dara Navaei — Sun, 31 May 2026 19:29:44 -0700

Dara Navaei replied to Vinayakam Mani in HD-DENBUG-335-1

Done

HD-DENBUG-335-1: comment by Dara Navaei "Done"

Dara Navaei — Sun, 31 May 2026 19:29:15 -0700

Dara Navaei replied to Vinayakam Mani in HD-DENBUG-335-1

Done

HD-DENBUG-335-1: comment by Dara Navaei "No this comment is explaining what will happen ..."

Dara Navaei — Sun, 31 May 2026 19:26:33 -0700

Dara Navaei replied to Vinayakam Mani in HD-DENBUG-335-1

No this comment is explaining what will happen at the bottom.

HD-DENBUG-335-1: comment by Vinayakam Mani "Need to remove comment? or missing implementati..."

Vinayakam Mani — Fri, 29 May 2026 16:51:17 -0700

Vinayakam Mani commented on HD-DENBUG-335-1

Need to remove comment? or missing implementation?

HD-DENBUG-335-1: comment by Vinayakam Mani "The alarm data doesn't sound correct."

Vinayakam Mani — Fri, 29 May 2026 16:35:53 -0700

Vinayakam Mani commented on HD-DENBUG-335-1

The alarm data doesn't sound correct.

HD-DENBUG-335-1: comment by Vinayakam Mani "Remove extra blank line"

Vinayakam Mani — Fri, 29 May 2026 16:17:19 -0700

Vinayakam Mani commented on HD-DENBUG-335-1

Remove extra blank line

HD-DENBUG-335-1: comment by Vinayakam Mani "This alarm description is more similar to alarm..."

Vinayakam Mani — Fri, 29 May 2026 16:08:58 -0700

Vinayakam Mani commented on HD-DENBUG-335-1

This alarm description is more similar to alarm 215, including title, description, trigger conditions?

hdfirmware (staging): DENBUG-335 updatd the code in treatment parameters. Removed the dead code in the valves

Dara Navaei — Wed, 20 May 2026 09:35:24 -0700

Dara Navaei committed 40aa3e7 on branch DENBUG-335-air-trap-fill-design-improvem, develop, staging in hdfirmware

DENBUG-335 updatd the code in treatment parameters. Removed the dead code in the valves

· /firmware/App/Controllers/Valves.c	(-25, +0)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeTreatmentParams.c	(-3, +3)	\| History	\| Source	\| Diff

HD-DENBUG-335-1: comment by Sean Nash "This doesn't look right. Check parenthesis."

Sean Nash — Wed, 20 May 2026 09:17:23 -0700

Sean Nash commented on HD-DENBUG-335-1

This doesn't look right. Check parenthesis.

hdfirmware (staging): DENBUG-335: Reset time window of new alarm after alarm is triggered so it doesn't interfere with alarm recovery. Fix ti...

Sean Nash — Thu, 14 May 2026 13:07:27 -0700

Sean Nash committed 5b792da on branch DENBUG-335-air-trap-fill-design-improvem, develop, staging in hdfirmware

DENBUG-335: Reset time window of new alarm after alarm is triggered so it doesn't interfere with alarm recovery. Fix time window from 1 to 5 minutes.

· /firmware/App/Controllers/AirTrap.c

(-1, +3)

| History

| Source

| Diff

hdfirmware (staging): DENBUG-335: Added check for air trap activity too frequent.

Sean Nash — Thu, 14 May 2026 11:20:41 -0700

Sean Nash committed 6d49cf6 on branch DENBUG-335-air-trap-fill-design-improvem, develop, staging in hdfirmware

DENBUG-335: Added check for air trap activity too frequent.

· /firmware/App/Controllers/AirTrap.c

(-6, +15)

| History

| Source

| Diff

hdfirmware (staging): DENBUG-335: air trap fill refinements.

Sean Nash — Wed, 13 May 2026 16:55:09 -0700

Sean Nash committed 0bb3fe3 on branch DENBUG-335-air-trap-fill-design-improvem, develop, staging in hdfirmware

DENBUG-335: air trap fill refinements.

· /firmware/App/Controllers/AirTrap.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-2, +6)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SalineBolus.c	(-2, +0)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.c	(-1, +2)	\| History	\| Source	\| Diff

hdfirmware (staging): DENBUG-335: First cut at new air trap fill approach with closing of VBV and slowing of BP.

Sean Nash — Wed, 13 May 2026 16:30:46 -0700

Sean Nash committed f3d625e on branch DENBUG-335-air-trap-fill-design-improvem, develop, staging in hdfirmware

DENBUG-335: First cut at new air trap fill approach with closing of VBV and slowing of BP.

· /firmware/App/Controllers/AirTrap.c	(-2, +29)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/AirTrap.h	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-8, +34)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/BloodPrime.c	(-5, +21)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Dialysis.c	(-1, +25)	\| History	\| Source	\| Diff
· /firmware/App/Modes/Rinseback.c	(-1, +28)	\| History	\| Source	\| Diff
· /firmware/App/Modes/SalineBolus.c	(-1, +24)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentEnd.c	(-0, +13)	\| History	\| Source	\| Diff
· /firmware/App/Modes/TreatmentStop.c	(-34, +67)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +6)	\| History	\| Source	\| Diff