Fisheye on dgfirmware/

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-96: Addressed DENBUG-97.

Sean Nash — Wed, 11 Oct 2023 12:36:08 -0700

Sean Nash committed e6e0513 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DENBUG-96: Addressed DENBUG-97.

· /firmware/App/Modes/ModeGenIdle.c	(-0, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-3, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DENBUG-96: Addressed DENBUG-98.

Sean Nash — Wed, 11 Oct 2023 12:22:01 -0700

Sean Nash committed 6243741 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DENBUG-96: Addressed DENBUG-98.

· /firmware/App/Modes/ModeStandby.c

(-0, +7)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Tue, 10 Oct 2023 15:59:36 -0700

Dara Navaei committed 8f8582c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 10 Oct 2023 15:59:22 -0700

Dara Navaei committed 3024adb on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemCommMessages.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged DEN-16487

Dara Navaei — Tue, 10 Oct 2023 15:57:52 -0700

Dara Navaei committed 8396fe2 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Merged DEN-16487

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16487 added code to set the dialin expiration time stamp once the user has logged in until the first checkin from di...

Dara Navaei — Tue, 10 Oct 2023 09:09:23 -0700

Dara Navaei committed 46dc653 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16487 added code to set the dialin expiration time stamp once the user has logged in until the first checkin from dialin is received

· /firmware/App/Services/SystemCommMessages.c

(-0, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 09 Oct 2023 11:24:15 -0700

Dara Navaei committed 0b9c7e1 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 09 Oct 2023 11:23:57 -0700

Dara Navaei committed d32f890 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Heaters.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Pressures.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/SafetyShutdown.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FPGA.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Interrupts.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged DEN-16446

Dara Navaei — Mon, 09 Oct 2023 11:09:56 -0700

Dara Navaei committed 02e8e56 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Merged DEN-16446

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

Dara Navaei — Mon, 09 Oct 2023 10:03:56 -0700

Dara Navaei committed 66bf871 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 addressed the code review comments

Dara Navaei — Mon, 09 Oct 2023 09:21:11 -0700

Dara Navaei committed 4c992d2 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16446 addressed the code review comments

· /firmware/App/Services/SystemCommMessages.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Mon, 09 Oct 2023 09:19:06 -0700

Dara Navaei committed 5fe44a7 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 09 Oct 2023 09:18:53 -0700

Dara Navaei committed dd5df16 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/TemperatureSensors.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'DEN-16475-please-add-average-tdi-tro-delta' into staging

Michael Garthwaite — Mon, 09 Oct 2023 08:59:17 -0700

Michael Garthwaite committed 3725ad2 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Merge branch 'DEN-16475-please-add-average-tdi-tro-delta' into staging

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 merged from remote

Vinayakam Mani — Mon, 09 Oct 2023 08:58:52 -0700

Vinayakam Mani committed bccd8ee on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16446 merged from remote

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16475: code review comments

Michael Garthwaite — Mon, 09 Oct 2023 08:57:32 -0700

Michael Garthwaite committed 630cc5c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 55 more in dgfirmware

DEN-16475: code review comments

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16475: added temperature event for drift during chem disinfect

Michael Garthwaite — Mon, 09 Oct 2023 07:59:14 -0700

Michael Garthwaite committed 3f44ec8 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 55 more in dgfirmware

DEN-16475: added temperature event for drift during chem disinfect

· /firmware/App/Controllers/TemperatureSensors.c

(-0, +15)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

Dara Navaei — Sun, 08 Oct 2023 10:49:47 -0700

Dara Navaei committed 9ba49eb on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16446 updated the code for VectorCAST

Dara Navaei — Sun, 08 Oct 2023 10:49:17 -0700

Dara Navaei committed fd87688 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

DEN-16446 updated the code for VectorCAST

· /firmware/App/Services/SystemCommMessages.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Fri, 06 Oct 2023 12:10:13 -0700

Dara Navaei committed b8026e6 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 55 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 06 Oct 2023 12:10:02 -0700

Dara Navaei committed 3390017 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 55 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/WatchdogMgmt.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged DEN-16372 to staging.

Sean Nash — Fri, 06 Oct 2023 11:29:24 -0700

Sean Nash committed 85c677a on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 55 more in dgfirmware

Merged DEN-16372 to staging.

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'DEN-16446-dg-dev-test-clean-up' of ssh://devapps.diality.us:7999/dg/dgfirmware into DEN-16446-dg-dev-test-...

Dara Navaei — Fri, 06 Oct 2023 11:20:24 -0700

Dara Navaei committed c91c64b on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Merge branch 'DEN-16446-dg-dev-test-clean-up' of ssh://devapps.diality.us:7999/dg/dgfirmware into DEN-16446-dg-dev-test-clean-up

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merged staging to DEN-16372.

Sean Nash — Fri, 06 Oct 2023 09:55:11 -0700

Sean Nash committed 6495ca9 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more in dgfirmware

Merged staging to DEN-16372.

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Merge branch 'DEN-16446-dg-dev-test-clean-up' of ssh://devapps.diality.us:7999/dg/dgfirmware into DEN-16446-dg-dev-test-...

Dara Navaei — Thu, 05 Oct 2023 11:35:48 -0700

Dara Navaei committed 43c590f on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 54 more in dgfirmware

Merge branch 'DEN-16446-dg-dev-test-clean-up' of ssh://devapps.diality.us:7999/dg/dgfirmware into DEN-16446-dg-dev-test-clean-up

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16372: Turn off trimmer heater if HD communication is lost.

Sean Nash — Thu, 05 Oct 2023 08:26:12 -0700

Sean Nash committed 5c8d32c on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more in dgfirmware

DEN-16372: Turn off trimmer heater if HD communication is lost.

· /firmware/App/Services/SystemComm.c

(-4, +6)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 04 Oct 2023 09:27:31 -0700

Dara Navaei committed b2c0dc6 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16372: fixed typo - wrong alarm triggered for watchdog expired.

Sean Nash — Wed, 04 Oct 2023 08:54:36 -0700

Sean Nash committed 67cbaca on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more in dgfirmware

DEN-16372: fixed typo - wrong alarm triggered for watchdog expired.

· /firmware/App/Services/WatchdogMgmt.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Dara Navaei — Wed, 04 Oct 2023 08:35:23 -0700

Dara Navaei committed d5f37a7 on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more in dgfirmware

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

· /firmware/App/DGCommon.h

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 04 Oct 2023 08:35:15 -0700

Dara Navaei committed 6edc3ea on branch DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/TemperatureSensors.c

(-2, +2)

| History

| Source

| Diff