Fisheye on dgfirmware/firmware/App/Modes/OperationModes.h https://devapps.diality.us/changelog/~br%3DDIAL-222-sys-request/dgfirmware/firmware/App/Modes/OperationModes.h Recent activity in "dgfirmware" under directory /firmware/App/Modes/OperationModes.h DG-COMMON-FIX-1: closed by Dara Navaei Thu, 19 Oct 2023 08:43:59 -0700 Dara Navaei https://devapps.diality.us/cru/DG-COMMON-FIX-1 https://devapps.diality.us/cru/DG-COMMON-FIX-1 Dara Navaei Closed DG-COMMON-FIX-1 ]]> DG-COMMON-FIX-1: reviewers finished Thu, 19 Oct 2023 08:43:51 -0700 https://devapps.diality.us/cru/DG-COMMON-FIX-1 https://devapps.diality.us/cru/DG-COMMON-FIX-1 Dara Navaei finished reviewing DG-COMMON-FIX-1 DG-COMMON-FIX_Review ]]> DG-COMMON-FIX-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:43:46 -0700 Dara Navaei https://devapps.diality.us/cru/DG-COMMON-FIX-1/#c19114 https://devapps.diality.us/cru/DG-COMMON-FIX-1/#c19114 Dara Navaei replied to pmontazemi  (deleted user) in DG-COMMON-FIX-1

RESOLVED in CODE WALKTHROUGH

]]> DG-COMMON-FIX-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:43:32 -0700 Dara Navaei https://devapps.diality.us/cru/DG-COMMON-FIX-1/#c19113 https://devapps.diality.us/cru/DG-COMMON-FIX-1/#c19113 Dara Navaei replied to pmontazemi  (deleted user) in DG-COMMON-FIX-1

RESOLVED in CODE WALKTHROUGH

]]> DG-COMMON-FIX-1: started by Dara Navaei Thu, 19 Oct 2023 08:43:00 -0700 Dara Navaei https://devapps.diality.us/cru/DG-COMMON-FIX-1 https://devapps.diality.us/cru/DG-COMMON-FIX-1 Dara Navaei started review DG-COMMON-FIX-1 ]]> DG-DEN-2650-1: closed by Dara Navaei Thu, 19 Oct 2023 08:42:37 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei Closed DG-DEN-2650-1 ]]> DG-DEN-2650-1: reviewers finished Thu, 19 Oct 2023 08:42:03 -0700 https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei finished reviewing DG-DEN-2650-1 DG-DEN-2650_DG Firmware Infrastructure ]]> DG-DEN-2650-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:41:49 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 https://devapps.diality.us/cru/DG-DEN-2650-1/#c19112 Dara Navaei replied to Sean Nash in DG-DEN-2650-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-2650-1: started by Dara Navaei Thu, 19 Oct 2023 08:41:19 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-2650-1 https://devapps.diality.us/cru/DG-DEN-2650-1 Dara Navaei started review DG-DEN-2650-1 ]]> DG-DEN-9480-1: closed by Dara Navaei Thu, 19 Oct 2023 08:05:20 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1 https://devapps.diality.us/cru/DG-DEN-9480-1 Dara Navaei Closed DG-DEN-9480-1 ]]> DG-DEN-9480-1: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Thu, 19 Oct 2023 08:05:10 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1/#c19092 https://devapps.diality.us/cru/DG-DEN-9480-1/#c19092 Dara Navaei replied to Sean Nash in DG-DEN-9480-1

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-9480-1: started by Dara Navaei Thu, 19 Oct 2023 08:03:54 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-9480-1 https://devapps.diality.us/cru/DG-DEN-9480-1 Dara Navaei started review DG-DEN-9480-1 ]]> DG-DEN-13460-2: closed by Dara Navaei Wed, 18 Oct 2023 21:20:43 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2 https://devapps.diality.us/cru/DG-DEN-13460-2 Dara Navaei Closed DG-DEN-13460-2 ]]> DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:20:31 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2/#c19072 https://devapps.diality.us/cru/DG-DEN-13460-2/#c19072 Dara Navaei replied to Sean Nash in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:19:58 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2/#c19071 https://devapps.diality.us/cru/DG-DEN-13460-2/#c19071 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13460-2: comment by Dara Navaei "RESOLVED in CODE WALKTHROUGH" Wed, 18 Oct 2023 21:19:26 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2/#c19070 https://devapps.diality.us/cru/DG-DEN-13460-2/#c19070 Dara Navaei replied to wbracken  (deleted user) in DG-DEN-13460-2

RESOLVED in CODE WALKTHROUGH

]]> DG-DEN-13460-2: started by Dara Navaei Wed, 18 Oct 2023 21:18:57 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-13460-2 https://devapps.diality.us/cru/DG-DEN-13460-2 Dara Navaei started review DG-DEN-13460-2 ]]> DG-DEN-15973-2: closed by Dara Navaei Fri, 15 Sep 2023 15:31:36 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15973-2 https://devapps.diality.us/cru/DG-DEN-15973-2 Dara Navaei Closed DG-DEN-15973-2 ]]> DG-DEN-15973-2: reviewers finished Fri, 15 Sep 2023 14:43:27 -0700 https://devapps.diality.us/cru/DG-DEN-15973-2 https://devapps.diality.us/cru/DG-DEN-15973-2 jtaylor  (deleted user) , wbracken  (deleted user) and Sean Nash finished reviewing DG-DEN-15973-2 DG-DEN-15973_Alarm 48 UF Rate Tare Error Triggered During Treatment ]]> DG-DEN-15973-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 14 Sep 2023 10:58:42 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15973-2/#c18922 https://devapps.diality.us/cru/DG-DEN-15973-2/#c18922 Sean Nash replied to Dara Navaei in DG-DEN-15973-2

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15973-2: comment by Dara Navaei "Done" Thu, 14 Sep 2023 10:28:15 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15973-2/#c18921 https://devapps.diality.us/cru/DG-DEN-15973-2/#c18921 Dara Navaei replied to Sean Nash in DG-DEN-15973-2

Done

]]> DG-DEN-15973-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 14 Sep 2023 09:53:07 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15973-2/#c18920 https://devapps.diality.us/cru/DG-DEN-15973-2/#c18920 Sean Nash replied to Dara Navaei in DG-DEN-15973-2

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15973-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 14 Sep 2023 09:52:58 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15973-2/#c18919 https://devapps.diality.us/cru/DG-DEN-15973-2/#c18919 Sean Nash replied to Dara Navaei in DG-DEN-15973-2

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15973-2: comment by Sean Nash "Dara, I mean inline comments for the magic numb..." Thu, 14 Sep 2023 09:51:45 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15973-2/#c18918 https://devapps.diality.us/cru/DG-DEN-15973-2/#c18918 Sean Nash replied to Sean Nash in DG-DEN-15973-2

Dara, I mean inline comments for the magic numbers. Explain what 40 and 32 mean and why you're using those values.

]]> DG-DEN-15973-2: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH." Thu, 14 Sep 2023 09:50:41 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15973-2/#c18917 https://devapps.diality.us/cru/DG-DEN-15973-2/#c18917 Sean Nash replied to Dara Navaei in DG-DEN-15973-2

RESOLVED in CODE WALKTHROUGH.

]]> DG-DEN-15973-2: comment by Dara Navaei "Done" Thu, 14 Sep 2023 09:44:33 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15973-2/#c18916 https://devapps.diality.us/cru/DG-DEN-15973-2/#c18916 Dara Navaei replied to Sean Nash in DG-DEN-15973-2

Done

]]> DG-DEN-15973-2: comment by Dara Navaei "Done" Thu, 14 Sep 2023 09:42:59 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15973-2/#c18915 https://devapps.diality.us/cru/DG-DEN-15973-2/#c18915 Dara Navaei replied to Sean Nash in DG-DEN-15973-2

Done

]]> DG-DEN-15973-2: comment by Sean Nash "You at least need to add a comment explaining w..." Thu, 14 Sep 2023 09:38:27 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15973-2/#c18914 https://devapps.diality.us/cru/DG-DEN-15973-2/#c18914 Sean Nash replied to Dara Navaei in DG-DEN-15973-2

You at least need to add a comment explaining what they are.

]]> DG-DEN-15973-2: comment by Dara Navaei "Done" Thu, 14 Sep 2023 09:38:24 -0700 Dara Navaei https://devapps.diality.us/cru/DG-DEN-15973-2/#c18913 https://devapps.diality.us/cru/DG-DEN-15973-2/#c18913 Dara Navaei replied to Sean Nash in DG-DEN-15973-2

Done

]]> DG-DEN-15973-2: comment by Sean Nash "No, these are the minimum values to trigger the..." Thu, 14 Sep 2023 09:37:33 -0700 Sean Nash https://devapps.diality.us/cru/DG-DEN-15973-2/#c18912 https://devapps.diality.us/cru/DG-DEN-15973-2/#c18912 Sean Nash replied to Dara Navaei in DG-DEN-15973-2

No, these are the minimum values to trigger the alarm. But they are named maximums.

]]>