RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Done

sizeof should be first in if

Should this have a set of parenthesis around the condition similar to line 437?

Resolved in code review.

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH. (with nausea)

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

Done

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp or other anomalies.

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5).
I would suggest using the ifdef within the body of the default clause, even with the statement duplicated, or adding an else clause to the ifndef with a second, empty default.

What's left? When would this code ever become reachable?

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).