Fisheye on dialin/version.py

dialin (DEN-12358-sw_dev-sprint-67_mg): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 11 Nov 2021 14:03:08 -0800

Dara Navaei committed be5fbab on branch DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11250-hd-syringe-pump-updates and 201 more in dialin

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /README.md

(-8, +8)

| History

| Source

| Diff

· /dialin/common/dg_defs.py

(-2, +2)

| History

| Source

| Diff

· /dialin/common/msg_ids.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/calibration_record.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/concentrate_pumps.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/dialysate_generator.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/drain_pump.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/events.py

(-0, +15)

| History

| Source

| Diff

· /dialin/dg/fans.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/flush.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/hd_proxy.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/heaters.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/ro_pump.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/rtc.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/service_record.py

(-2, +2)

| History

| Source

| Diff

… 22 more files in changeset.

DIALIN-DEN-8856-1: closed by qnguyen

qnguyen — Wed, 04 Aug 2021 10:46:21 -0700

qnguyen (deleted user) Closed DIALIN-DEN-8856-1

DIALIN-DEN-8856-1: reviewers finished

Wed, 04 Aug 2021 10:45:31 -0700

pmontazemi (deleted user) and Sean Nash finished reviewing DIALIN-DEN-8856-1

DIALIN-DEN-8856_Sprint 47

DIALIN-DEN-8856-1: comment by Sean Nash "RESOLVED."

Sean Nash — Fri, 30 Jul 2021 10:36:20 -0700

Sean Nash replied to Behrouz NematiPour in DIALIN-DEN-8856-1

RESOLVED.

DIALIN-DEN-8856-1: comment by Sean Nash "RESOLVED."

Sean Nash — Fri, 30 Jul 2021 10:35:42 -0700

Sean Nash replied to qnguyen (deleted user) in DIALIN-DEN-8856-1

RESOLVED.

DIALIN-DEN-8856-1: comment by Behrouz NematiPour "In this filename, "prs" means "Product Requirem..."

Behrouz NematiPour — Thu, 29 Jul 2021 17:47:03 -0700

Behrouz NematiPour replied to Sean Nash in DIALIN-DEN-8856-1

In this filename, "prs" means "Product Requirement Specification" and not "Pressure".
These values are defined in the PRS and are being used by UI Simulator.

DIALIN-DEN-8856-1: comment by qnguyen "Removed the return of CAN frame list."

qnguyen — Thu, 29 Jul 2021 11:44:40 -0700

qnguyen (deleted user) replied to Sean Nash in DIALIN-DEN-8856-1

Removed the return of CAN frame list.

DIALIN-DEN-8856-1: comment by qnguyen "These are no definitions of these class inside ..."

qnguyen — Wed, 21 Jul 2021 12:23:44 -0700

qnguyen (deleted user) replied to Sean Nash in DIALIN-DEN-8856-1

These are no definitions of these class inside alarm_defs.py yet. I think this means PRS definitions rather than pressure.
Behrouz NematiPour Should these definitions be moved to another file?

DIALIN-DEN-8856-1: comment by Sean Nash "What does it mean to return two things: frames ..."

Sean Nash — Tue, 20 Jul 2021 13:19:59 -0700

Sean Nash commented on DIALIN-DEN-8856-1

What does it mean to return two things: frames and message?

DIALIN-DEN-8856-1: comment by Sean Nash "Aren't these alarm enums duplicates of the ones..."

Sean Nash — Tue, 20 Jul 2021 13:11:04 -0700

Sean Nash commented on DIALIN-DEN-8856-1

Aren't these alarm enums duplicates of the ones in alarm_defs.py? Also, file name suggests these are pressure related definitions - so why are alarm definitions in here?

DIALIN-DEN-8856-1: comment by pmontazemi "RESOLVED."

pmontazemi — Mon, 19 Jul 2021 09:50:01 -0700

pmontazemi (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8856-1

RESOLVED.

DIALIN-DEN-8856-1: comment by pmontazemi "RESOLVED."

pmontazemi — Mon, 19 Jul 2021 09:49:50 -0700

pmontazemi (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8856-1

RESOLVED.

DIALIN-DEN-8856-1: comment by pmontazemi "RESOLVED."

pmontazemi — Mon, 19 Jul 2021 09:49:40 -0700

pmontazemi (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8856-1

RESOLVED.

DIALIN-DEN-8856-1: comment by pmontazemi "RESOLVED."

pmontazemi — Mon, 19 Jul 2021 09:49:30 -0700

pmontazemi (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8856-1

RESOLVED.

DIALIN-DEN-8856-1: comment by qnguyen "Done."

qnguyen — Mon, 19 Jul 2021 09:31:50 -0700

qnguyen (deleted user) replied to pmontazemi (deleted user) in DIALIN-DEN-8856-1

Done.

DIALIN-DEN-8856-1: comment by qnguyen "Done."

qnguyen — Mon, 19 Jul 2021 09:31:44 -0700

qnguyen (deleted user) replied to pmontazemi (deleted user) in DIALIN-DEN-8856-1

Done.

DIALIN-DEN-8856-1: comment by qnguyen "Done."

qnguyen — Mon, 19 Jul 2021 09:31:32 -0700

qnguyen (deleted user) replied to pmontazemi (deleted user) in DIALIN-DEN-8856-1

Done.

DIALIN-DEN-8856-1: comment by qnguyen "Done."

qnguyen — Mon, 19 Jul 2021 09:31:28 -0700

qnguyen (deleted user) replied to pmontazemi (deleted user) in DIALIN-DEN-8856-1

Done.

DIALIN-DEN-8856-1: comment by pmontazemi "Add TODO"

pmontazemi — Fri, 09 Jul 2021 13:42:38 -0700

pmontazemi (deleted user) commented on DIALIN-DEN-8856-1

Add TODO

DIALIN-DEN-8856-1: comment by pmontazemi "Add TODO"

pmontazemi — Fri, 09 Jul 2021 13:42:26 -0700

pmontazemi (deleted user) commented on DIALIN-DEN-8856-1

Add TODO

DIALIN-DEN-8856-1: comment by pmontazemi "CAN instead of can"

pmontazemi — Fri, 09 Jul 2021 13:40:33 -0700

pmontazemi (deleted user) commented on DIALIN-DEN-8856-1

CAN instead of can

DIALIN-DEN-8856-1: comment by pmontazemi "Denali with capital "D"."

pmontazemi — Fri, 09 Jul 2021 13:40:17 -0700

pmontazemi (deleted user) commented on DIALIN-DEN-8856-1

Denali with capital "D".

DIALIN-DEN-8856-1: started by qnguyen

qnguyen — Tue, 06 Jul 2021 16:44:27 -0700

qnguyen (deleted user) started review DIALIN-DEN-8856-1

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-8856: Use setuptools scm for dialin version

Wed, 30 Jun 2021 22:31:19 -0700

Quang Nguyen committed a96c710 on branch DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime, DEN-10602_UI_DEV_PatientID and 208 more in dialin

DEN-8856: Use setuptools scm for dialin version

· /dialin/__init__.py	(-2, +14)	\| History	\| Source	\| Diff
· /dialin/hd/alarms.py	(-1, +1)	\| History	\| Source	\| Diff
· /dialin/version.py	(-69, +0)	\| History	\| Source	\| Diff
· /setup.py	(-4, +2)	\| History	\| Source	\| Diff
· /version.py	(--139, +0)	\| History	\| Source	\| Diff

DIALIN-DEN-8462-1: closed by plucia

plucia — Tue, 22 Jun 2021 13:42:04 -0700

plucia (deleted user) Closed DIALIN-DEN-8462-1

DIALIN-DEN-8462-1: reviewers finished

Tue, 22 Jun 2021 13:41:19 -0700

Sean Nash and qnguyen (deleted user) finished reviewing DIALIN-DEN-8462-1

DIALIN-DEN-8462_Sprint 45

DIALIN-DEN-8462-1: comment by qnguyen "RESOLVED."

qnguyen — Tue, 22 Jun 2021 13:39:21 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8462-1

RESOLVED.

DIALIN-DEN-8462-1: comment by plucia "That's a good idea and I think we should do so...."

plucia — Tue, 22 Jun 2021 13:25:57 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8462-1

That's a good idea and I think we should do so. Since this code review is quite old I will make that change in my latest branch

DIALIN-DEN-8462-1: comment by qnguyen "should we create dg_defs file?"

qnguyen — Thu, 03 Jun 2021 00:16:18 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8462-1

should we create dg_defs file?

DIALIN-DEN-8462-1: started by plucia

plucia — Wed, 02 Jun 2021 13:26:29 -0700

plucia (deleted user) started review DIALIN-DEN-8462-1