DIALIN-DEN-8856-1 DIALIN-DEN-8856_Sprint 47

closed on 04 Aug 21

Author

Moderator

Reviewers

DIALIN-DEN-8856_Sprint 47

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 35

dialin 0
- Folder dialin 0
  - Folder common 0
    - File __init__.py 0 Remove
    - File alarm_defs.py 0 Remove
    - File alarm_priorities.py 0 Remove
    - File dg_defs.py 0 Remove
    - File hd_defs.py 0 Remove
    - File msg_defs.py 0 Remove
    - File msg_ids.py 0 Remove
    - File prs_defs.py 4 Remove
    - File ui_defs.py 0 Remove
  - Folder dg 0
    - File alarms.py 0 Remove
    - File ro_pump.py 0 Remove
    - File valves.py 0 Remove
  - Folder hd 0
    - File alarms.py 0 Remove
    - File buttons.py 0 Remove
    - File calibration_record.py 0 Remove
    - File syringe_pump.py 0 Remove
    - File treatment.py 0 Remove
    - File ui_proxy.py 0 Remove
    - File watchdog.py 0 Remove
  - Folder protocols 0
    - File CAN.py 9 Remove
    - File __init__.py 0 Remove
  - Folder ui 0
    - File hd_simulator.py 0 Remove
    - File hd_simulator_alarms.py 0 Remove
  - Folder utils 0
    - File __init__.py 0 Remove
    - File base.py 0 Remove
    - File conversions.py 0 Remove
    - File data_logger.py 3 Remove
    - File singleton.py 3 Remove
  - File __init__.py 0 Remove
  - File version.py 0 Remove
- Folder docs/source 0
  - File conf.py 0 Remove
- Folder tests/peter 0
  - File test_gen_requirements.py 0 Remove
- File requirements.txt 0 Remove
- File setup.py 0 Remove
- File version.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
qnguyen (deleted user)	Author & Moderator	49m	6	Removed the return of CAN frame list.
Behrouz NematiPour	Reviewer - 40% reviewed	10m	1	In this filename, "prs" means "Product Requirement Specif...
pmontazemi (deleted user)	Reviewer - Complete	13m	8	RESOLVED.
Sean Nash	Reviewer - Complete	31m	4	RESOLVED.
Total		1h 44m	19

Linked issues
- DEN-7347
- DEN-8856
- DEN-8859
- DIAL-100
- DIAL-104
- DIAL-91

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-DEN-8856-1

DIALIN-DEN-8856_Sprint 47

DIALIN-DEN-8856-1 19

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DIALIN-DEN-8856_Sprint 47

DIALIN-DEN-8856-1 19

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time