Fisheye on dgfirmware/firmware/App/Modes/ModeROPermeateSample.c

DG-DEN-17047-1: closed by Dara Navaei

Dara Navaei — Sat, 08 Nov 2025 14:06:26 -0800

Dara Navaei Closed DG-DEN-17047-1

DG-DEN-16970-1: closed by Dara Navaei

Dara Navaei — Thu, 12 Sep 2024 13:40:34 -0700

Dara Navaei Closed DG-DEN-16970-1

DG-DEN-16970-1: reviewers finished

Thu, 12 Sep 2024 13:37:36 -0700

Vinayakam Mani and Sean Nash finished reviewing DG-DEN-16970-1

DG-DEN-16970_Stuck IN Cancel Basic Path During Heat Disinfect Passive Cool

DG-DEN-17047-1: started by Dara Navaei

Dara Navaei — Tue, 10 Sep 2024 12:12:10 -0700

Dara Navaei started review DG-DEN-17047-1

DG-DEN-16970-1: reviewers added to DG-DEN-16970_Stuck IN Cancel Basic Path During Hea...

Mon, 09 Sep 2024 16:13:17 -0700

Dara Navaei added pvedantam (deleted user) to DG-DEN-16970-1

DG-DEN-16970_Stuck IN Cancel Basic Path During Heat Disinfect Passive Cool

DG-DEN-16970-1: started by Dara Navaei

Dara Navaei — Mon, 09 Sep 2024 12:58:27 -0700

Dara Navaei started review DG-DEN-16970-1

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 28 Jul 2023 15:04:28 -0700

Dara Navaei committed 75868c8 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 92 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Switches.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-1, +1)	\| History	\| Source	\| Diff

DG-DEN-15614-1: closed by Dara Navaei

Dara Navaei — Fri, 28 Jul 2023 15:03:28 -0700

Dara Navaei Closed DG-DEN-15614-1

DG-DEN-15614-1: reviewers finished

Fri, 28 Jul 2023 15:01:15 -0700

jtaylor (deleted user) and wbracken (deleted user) finished reviewing DG-DEN-15614-1

DG-DEN-15614_New Updated Disinfect Actuators Requirement Issues List

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15614 changed the cleaning modes to request a transition to fault mode if a fault alarm is triggered

Dara Navaei — Thu, 27 Jul 2023 13:43:56 -0700

Dara Navaei committed 9226e7b on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 92 more in dgfirmware

DEN-15614 changed the cleaning modes to request a transition to fault mode if a fault alarm is triggered

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-1, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.c	(-6, +6)	\| History	\| Source	\| Diff

DG-DEN-15614-1: started by Dara Navaei

Dara Navaei — Wed, 26 Jul 2023 14:03:22 -0700

Dara Navaei started review DG-DEN-15614-1

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 26 Jul 2023 11:39:37 -0700

Dara Navaei committed 9b8889b on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 92 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DrainPump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/LoadCell.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFlush.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/OperationModes.c	(-1, +1)	\| History	\| Source	\| Diff

DG-DEN-15921-1: closed by Dara Navaei

Dara Navaei — Wed, 26 Jul 2023 11:20:29 -0700

Dara Navaei Closed DG-DEN-15921-1

DG-DEN-15921-1: reviewers finished

Wed, 26 Jul 2023 11:08:37 -0700

wbracken (deleted user) finished reviewing DG-DEN-15921-1

DG-DEN-15921_When Cap IS Open DG Transition TO Cancel Basic Path Instead OF Cancel Water Path

DG-DEN-15921-1: comment by dcox "RESOLVED IN CODE WALKTHROUGH"

dcox — Wed, 26 Jul 2023 10:04:47 -0700

dcox (deleted user) replied to Dara Navaei in DG-DEN-15921-1

RESOLVED IN CODE WALKTHROUGH

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15921 addressed a code review comment

Dara Navaei — Tue, 25 Jul 2023 13:22:09 -0700

Dara Navaei committed 81be018 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

DEN-15921 addressed a code review comment

· /firmware/App/Modes/ModeROPermeateSample.c

(-1, +1)

| History

| Source

| Diff

DG-DEN-15921-1: comment by Dara Navaei "Done thanks."

Dara Navaei — Tue, 25 Jul 2023 13:19:00 -0700

Dara Navaei replied to dcox (deleted user) in DG-DEN-15921-1

Done thanks.

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15921, DEN-15882 made a change in the code to transition to drain R1 in RO permeate sample mode after the sample col...

Dara Navaei — Tue, 25 Jul 2023 13:14:54 -0700

Dara Navaei committed 0accd81 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

DEN-15921, DEN-15882 made a change in the code to transition to drain R1 in RO permeate sample mode after the sample collection is finished

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c	(-3, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-1, +2)	\| History	\| Source	\| Diff

DG-DEN-15921-1: comment by dcox "This comment should say "bicarb pump is 2% fast..."

dcox — Tue, 25 Jul 2023 12:53:19 -0700

dcox (deleted user) commented on DG-DEN-15921-1

This comment should say "bicarb pump is 2% faster than...." .

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-15921, DEN-15868 changed the direction of the pumps in RO permeate sample mode. Changed the code to check the flow i...

Dara Navaei — Tue, 25 Jul 2023 08:49:32 -0700

Dara Navaei committed e240618 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 93 more in dgfirmware

DEN-15921, DEN-15868 changed the direction of the pumps in RO permeate sample mode. Changed the code to check the flow in heat disinfect and active cool to only when the system is not hot

· /firmware/App/Controllers/DrainPump.c	(-4, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.c	(-3, +12)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ROPump.h	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeROPermeateSample.c	(-2, +2)	\| History	\| Source	\| Diff

DG-DEN-15921-1: started by Dara Navaei

Dara Navaei — Mon, 24 Jul 2023 12:03:34 -0700

Dara Navaei started review DG-DEN-15921-1

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 14 Jun 2023 09:57:02 -0700

Dara Navaei committed d325999 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 106 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ConductivitySensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/DrainPump.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Pressures.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/TemperatureSensors.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeChemicalDisinfectFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeDrain.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFault.c

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFill.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeFlush.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfect.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Modes/ModeHeatDisinfectActiveCool.c

(-1, +1)

| History

| Source

| Diff

… 11 more files in changeset.

DG-DEN-15367-1: closed by Dara Navaei

Dara Navaei — Wed, 14 Jun 2023 09:39:48 -0700

Dara Navaei Closed DG-DEN-15367-1

DG-DEN-15367-1: reviewers finished

Wed, 14 Jun 2023 09:12:02 -0700

Sean Nash finished reviewing DG-DEN-15367-1

DG-DEN-15367_HD DG Test Configuration Setup

DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Wed, 14 Jun 2023 09:05:01 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 13 Jun 2023 15:31:31 -0700

Dara Navaei replied to Sean Nash in DG-DEN-15367-1

Done

DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 13 Jun 2023 12:50:35 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 13 Jun 2023 12:50:01 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1: comment by Sean Nash "Still has a payload. Should remove it."

Sean Nash — Tue, 13 Jun 2023 12:48:04 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15367-1

Still has a payload. Should remove it.

DG-DEN-15367-1: comment by Sean Nash "RESOLVED in CODE WALKTHROUGH."

Sean Nash — Tue, 13 Jun 2023 12:47:07 -0700

Sean Nash replied to Dara Navaei in DG-DEN-15367-1

RESOLVED in CODE WALKTHROUGH.