Fisheye on dgfirmware/firmware/App/Services/SystemComm.c

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-283: message handling for moving average override.

Michael Garthwaite — Mon, 11 Sep 2023 13:59:11 -0700

Michael Garthwaite committed 3fc8744 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 62 more in dgfirmware

DIAL-283: message handling for moving average override.

· /firmware/App/Modes/ModeChemicalDisinfect.c	(-10, +7)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeChemicalDisinfect.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +31)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 06 Sep 2023 07:40:03 -0700

Dara Navaei committed f910ec2 on branch DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 65 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-14706: fixed compiler errors

Michael Garthwaite — Tue, 05 Sep 2023 08:11:21 -0700

Michael Garthwaite committed 0ae5f0f on branch DEN-14706-can-messge-not-acked-fix, DEN-15791-dg-software-design-description and 66 more in dgfirmware

DEN-14706: fixed compiler errors

· /firmware/App/Services/SystemComm.c

(-3, +3)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-14706: code review comments.

Michael Garthwaite — Fri, 01 Sep 2023 10:01:45 -0700

Michael Garthwaite committed e23b440 on branch DEN-14706-can-messge-not-acked-fix, DEN-15791-dg-software-design-description and 66 more in dgfirmware

DEN-14706: code review comments.

· /firmware/App/Services/SystemComm.c

(-7, +2)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-14706: wip of code review comments.

Michael Garthwaite — Thu, 31 Aug 2023 14:12:34 -0700

Michael Garthwaite committed ceccf84 on branch DEN-14706-can-messge-not-acked-fix, DEN-15791-dg-software-design-description and 66 more in dgfirmware

DEN-14706: wip of code review comments.

· /firmware/App/Services/SystemComm.c

(-9, +9)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-14706: Fixed DG pending ack override.

Michael Garthwaite — Thu, 31 Aug 2023 12:30:26 -0700

Michael Garthwaite committed fceea21 on branch DEN-14706-can-messge-not-acked-fix, DEN-15791-dg-software-design-description and 66 more in dgfirmware

DEN-14706: Fixed DG pending ack override.

· /firmware/App/Services/SystemComm.c

(-5, +18)

| History

| Source

| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 30 Aug 2023 15:48:53 -0700

Dara Navaei committed 16c0f81 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/ConcentratePumps.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeFill.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16093 changes merge in to staging

Vinayakam Mani — Wed, 30 Aug 2023 15:25:06 -0700

Vinayakam Mani committed e0ffb87 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

DEN-16093 changes merge in to staging

· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +21)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 30 Aug 2023 14:48:11 -0700

Dara Navaei committed fd84d51 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeHeatDisinfect.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DIAL-278: implementation of heat disinfection state timer overrides.

Michael Garthwaite — Tue, 29 Aug 2023 09:34:08 -0700

Michael Garthwaite committed 6703d91 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more in dgfirmware

DIAL-278: implementation of heat disinfection state timer overrides.

· /firmware/App/Modes/ModeHeatDisinfect.c	(-4, +105)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeHeatDisinfect.h	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +64)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +7)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): take latest changes from staging

Vinayakam Mani — Fri, 25 Aug 2023 13:06:48 -0700

Vinayakam Mani committed 4b528a5 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more in dgfirmware

take latest changes from staging

· /firmware/App/Modes/ModeFill.c	(-5, +13)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-4, +58)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-5, +69)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +7)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 24 Aug 2023 16:46:31 -0700

Dara Navaei committed bd1f452 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 73 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/AlarmMgmt.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmt.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-2, +2)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merged staging to DENBUG-59.

Sean Nash — Thu, 24 Aug 2023 10:55:40 -0700

Sean Nash committed 09cde48 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 74 more in dgfirmware

Merged staging to DENBUG-59.

· /firmware/App/Services/Reservoirs.c	(-23, +88)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-4, +69)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-7, +169)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16093 handler for DG park concnetrate pump added

Vinayakam Mani — Mon, 21 Aug 2023 18:04:00 -0700

Vinayakam Mani committed 09ac8a1 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more in dgfirmware

DEN-16093 handler for DG park concnetrate pump added

· /firmware/App/Controllers/ConcentratePumps.c	(-0, +42)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-11, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 21 Aug 2023 12:44:51 -0700

Dara Navaei committed b607a94 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 74 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/Reservoirs.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'DIAL-280-reservoir-broadcast-override' into staging

Michael Garthwaite — Mon, 21 Aug 2023 12:38:09 -0700

Michael Garthwaite committed 26af10a on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 74 more in dgfirmware

Merge branch 'DIAL-280-reservoir-broadcast-override' into staging

· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +32)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 21 Aug 2023 11:48:25 -0700

Dara Navaei committed 9b423e2 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 74 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): Merge branch 'staging' into DIAL-280-reservoir-broadcast-override

Michael Garthwaite — Mon, 21 Aug 2023 11:29:13 -0700

Michael Garthwaite committed a45a2f0 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 75 more in dgfirmware

Merge branch 'staging' into DIAL-280-reservoir-broadcast-override

· /firmware/App/Services/SystemComm.c	(-1, +50)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +32)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-16499-fw-message-list-testing-issues-2): DEN-16093-added DG park concentrate pumps

Vinayakam Mani — Mon, 21 Aug 2023 09:04:30 -0700

Vinayakam Mani committed 2b2cf77 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more in dgfirmware

DEN-16093-added DG park concentrate pumps

· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +31)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14706: removed #define

Michael Garthwaite — Fri, 18 Aug 2023 12:37:06 -0700

Michael Garthwaite committed ad186fe on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 76 more in dgfirmware

DEN-14706: removed #define

· /firmware/App/Services/SystemComm.c

(-1, +0)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14706: changed override condition for pending ack

Michael Garthwaite — Fri, 18 Aug 2023 10:42:47 -0700

Michael Garthwaite committed 64f53d7 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 76 more in dgfirmware

DEN-14706: changed override condition for pending ack

· /firmware/App/Services/SystemComm.c

(-2, +1)

| History

| Source

| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DIAL-280: Reservoir broadcast interval override.

Michael Garthwaite — Thu, 17 Aug 2023 20:16:01 -0700

Michael Garthwaite committed 4375a41 on branch DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 75 more in dgfirmware

DIAL-280: Reservoir broadcast interval override.

· /firmware/App/Services/Reservoirs.c	(-21, +85)	\| History	\| Source	\| Diff
· /firmware/App/Services/Reservoirs.h	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +31)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment): DEN-14706: DG ACK pending override message handling and implementation.

Michael Garthwaite — Thu, 17 Aug 2023 19:59:21 -0700

Michael Garthwaite committed aa1367a on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 76 more in dgfirmware

DEN-14706: DG ACK pending override message handling and implementation.

· /firmware/App/Services/SystemComm.c	(-1, +52)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemComm.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +32)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +3)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Aug 2023 10:22:01 -0700

Dara Navaei committed b90c388 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c

(-2, +2)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Merge remote-tracking branch 'origin/staging' into staging

Wed, 16 Aug 2023 10:16:56 -0700

James Walter Taylor committed 50572d2 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more in dgfirmware

Merge remote-tracking branch 'origin/staging' into staging

· /firmware/App/Services/SystemComm.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Merge remote-tracking branch 'origin/DEN-15996-over-ride-commands-duplicates-the-id-msg_id_valves_states_publish_interva...

Wed, 16 Aug 2023 10:04:33 -0700

James Walter Taylor committed 28427a8 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more in dgfirmware

Merge remote-tracking branch 'origin/DEN-15996-over-ride-commands-duplicates-the-id-msg_id_valves_states_publish_interval_override' into staging

· /firmware/App/Services/SystemComm.c

(-1, +1)

| History

| Source

| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 16 Aug 2023 09:43:45 -0700

Dara Navaei committed 3d8da96 on branch DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 80 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DEN-14692: Implemented message handling for DG RAM status override.

Michael Garthwaite — Tue, 15 Aug 2023 15:40:21 -0700

Michael Garthwaite committed 7408f6f on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 81 more in dgfirmware

DEN-14692: Implemented message handling for DG RAM status override.

· /firmware/App/Services/SystemComm.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-0, +33)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-0, +4)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 15 Aug 2023 09:08:27 -0700

Dara Navaei committed 94b2c47 on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 81 more in dgfirmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff

dgfirmware (DEN-16215-srsdg-215-incorrect-fill-mode-starts-in-start-state): DIAL-269: Fixed dialin's get ro only mode

Michael Garthwaite — Fri, 11 Aug 2023 14:12:08 -0700

Michael Garthwaite committed a98dd1b on branch DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 82 more in dgfirmware

DIAL-269: Fixed dialin's get ro only mode

· /firmware/App/Services/SystemComm.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommMessages.h	(-1, +1)	\| History	\| Source	\| Diff