fixed. Removed ifdef as well as it is no longer applies here since we are retrieving the data from the monitor which has the #ifdefs for teensy.

I think using filtered values for alarms makes sense.

we need filtered values for various applications in the system. My question is should we be checking dialysate temperature using a filtered value or a sample point? This version showed that we want a sample point.

in Denali, looks like the HD got the filtered temperature value from the DG for checking dialysate temp alarms. Are we upholding that same design of using a filtered value for leahi dialysate temp?

I don't see fix. Did you push fwcommon?

Restore this blank line.

Remove all of these blank lines please.

Removed the ifdef here as these overrides still be used without breaking the teensy driver.
I can add it on request. Unsure if teensy will be tested long enough for them to use those overrides.

In the meantime,

MSG_ID_DD_FILTERED_COND_SENSOR_READINGS_OVERRIDE_REQUEST and MSG_ID_FP_FILTERED_COND_SENSOR_READINGS_OVERRIDE_REQUEST are still available to override the monitor/filtered data.

fixed.

fixed.

Not here. This include was not in the right spot as we want the two drivers to be separated. the include is in the monitor

Temperature monitor only has getter's for d4 and d50 at the moment. It looks like that hasnt been refactored to consider all temp sensors.

for Teensy it is done at the driver as it is a part of the initialization sequence. See TEENSY_CMD_GET_EEPROM_DATA cmd.

Not at the moment. This feature isnt expected to on the V2's. The v2's arent going to have ALY_LINEAR as that is one specific to the teensy sensors.

#ifdef TEENSY for these new functions.

Only needed for TEENSY, right? So #ifdef should be applied.

No model selection for V2 sensor?

Teensy driver doesn't need overrides too?

Probably shouldn't have "TEENSY" in the name. Non-teensy driver will probably need this too, so can be generic.

Is calibration going to be done here or at driver? I was expecting driver to calibrate since cal factors are coming from sensor.

Remove blank line.

Should we have #ifdef here to determine which driver to initialize?

If we're not using filtered values, why filter them at all?

Add comments to right.

enum should have a /// comment on top.

Shouldn't D27 temp be gotten from monitor (Temperature.c) instead of from conductivity drivers?