fixed. thanks!

· /firmware/App/Controllers/Valves.c

(-1, +1)

| History

| Source

| Diff

]]> Thu, 16 Oct 2025 09:49:39 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1/#c24672 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1/#c24672 Sean Nash commented on LEAHI-RO-FIRMWARE-LDT-1773-1

I think this should be initialized to zero in case some bits are unused.

· /firmware/App/Controllers/Valves.c	(-5, +5)	| History	| Source	| Diff
· /firmware/App/Services/FpgaFP.c	(-5, +43)	| History	| Source	| Diff
· /firmware/App/Services/FpgaFP.h	(-1, +1)	| History	| Source	| Diff

]]> Fri, 19 Sep 2025 10:00:57 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-1773-1 Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-1773-1 ]]> Fri, 19 Sep 2025 08:58:03 -0700 Michael Garthwaite https://devapps.diality.us/changelog/ro-firmware?cs=cf82e0c4128078cce50bd6c7969ea7192ab5be94 https://devapps.diality.us/changelog/ro-firmware?cs=cf82e0c4128078cce50bd6c7969ea7192ab5be94 Michael Garthwaite committed cf82e0c on branch LDT-1773-iofp-valve-pwm, LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware LDT-1773: implemented FPGA interface for valve PWM. implemented in valves module

· /firmware/App/Controllers/Valves.c	(-0, +12)	| History	| Source	| Diff
· /firmware/App/Services/FpgaFP.c	(-0, +33)	| History	| Source	| Diff
· /firmware/App/Services/FpgaFP.h	(-0, +5)	| History	| Source	| Diff

]]> Fri, 05 Sep 2025 07:58:15 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1 https://devapps.diality.us/cru/RO-LDT-1242-1 Michael Garthwaite Closed RO-LDT-1242-1 ]]> Thu, 04 Sep 2025 09:01:05 -0700 https://devapps.diality.us/cru/RO-LDT-1242-1 https://devapps.diality.us/cru/RO-LDT-1242-1 Sean Nash and Raghu Kallala finished reviewing RO-LDT-1242-1 RO-LDT-1242_Iofp Finalize Permeate Tank ]]> Thu, 04 Sep 2025 08:39:13 -0700 Michael Garthwaite https://devapps.diality.us/cru/RO-LDT-1242-1/#c24037 https://devapps.diality.us/cru/RO-LDT-1242-1/#c24037 Michael Garthwaite replied to Sean Nash in RO-LDT-1242-1

reverted commit. Back to 110 ranking and changed properties for DD fault = TRUE

fault -> FALSE

Or maybe 110 was correct and fault property should be FALSE and DD fault property should be TRUE? This doesn't look like a TD fault. All other faults are DD faults.

updated pre-gen alarms that fault to rank 10

fixed thanks!

just a placeholder for now ( until SA updates ). bumped it to 10 seconds in the meantime

fixed thanks!

fixed thanks!

fixed thanks!

fixed thanks!

removed comment.

fixed thanks!

fixed thanks!

it was place holder until blood leak alarms are were in staging. its in order now.