Updated

Added

reverted back

This code is removed and not required

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

I was thinking that comment should go above the first if statement.

Updated

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

Added

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Added

Should probably initialize your new stall counter variable.

Sean Nash I need your help for writing this Alarm properties.

Wrong place.

I'll drop by and we can set properties together.

Added

Updated

Sorry, Updated

Updated, if this is wrong then I need your help

Match properties from Denali where you can. The priorities should both be HIGH. The rank for the warning should be a higher number. The alarm should be TRUE for no resume and no rinseback. So, I know these properties aren't correct.
One thing I don't think we should copy from Denali though - I think the warning should not be TRUE for the STOP property so that we stay in blood prime state.

Add a blank line after declaration.

I think we should just have == here so that we only warn them once.