Fisheye on td-firmware/firmware/App/Services/Messaging.h

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "I don't see you changing the GoalL. Recommend ..."

Sean Nash — Tue, 05 May 2026 18:21:50 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "2 lines above/below banner"

Sean Nash — Tue, 05 May 2026 18:52:58 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

2 lines above/below banner

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "remove blank line."

Sean Nash — Tue, 05 May 2026 18:48:29 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

remove blank line.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "use response.x for these."

Sean Nash — Tue, 05 May 2026 18:25:58 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

use response.x for these.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "use response.duration."

Sean Nash — Tue, 05 May 2026 18:25:43 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

use response.duration.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Already set this above."

Sean Nash — Tue, 05 May 2026 18:24:49 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Already set this above.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "I don't think we should change this."

Sean Nash — Sun, 03 May 2026 23:17:30 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

I don't think we should change this.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Not sure this makes sense. Time is in minutes...."

Sean Nash — Sun, 03 May 2026 23:13:40 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Not sure this makes sense. Time is in minutes. min * mL/min = mL (makes sense). min * L/hr = minL/hr (does not make sense).
Talk to Raghu about UF rate units and when we should use mL/min vs. L/hr.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "I don't think you want stored (old) value here...."

Sean Nash — Thu, 30 Apr 2026 15:57:21 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

I don't think you want stored (old) value here. You want value from first message before confirmation.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Keep 2 blank lines above the banner below."

Sean Nash — Wed, 29 Apr 2026 09:57:28 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Keep 2 blank lines above the banner below.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Is this still needed?"

Sean Nash — Wed, 29 Apr 2026 09:56:56 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Is this still needed?

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "You moved this to TxParams.h and I think that's..."

Sean Nash — Wed, 29 Apr 2026 09:56:25 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Keep 2 blank lines above the test support funct..."

Sean Nash — Wed, 29 Apr 2026 09:49:17 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Keep 2 blank lines above the test support functions banner.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Not sure why you are making changes to this fun..."

Sean Nash — Wed, 29 Apr 2026 09:47:09 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Not sure why you are making changes to this function.
This function handles message from UI to pause or resume ultrafiltration.
This is not a treatment parameter edit message, so I don't think it's part of your assignment.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "No longer needed?"

Sean Nash — Wed, 29 Apr 2026 09:43:11 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

No longer needed?

LEAHI-TD-FIRMWARE-LDT-3970-1: reviewers added to LEAHI-TD-FIRMWARE-LDT-3970_Edit Treatment Paramete...

Wed, 29 Apr 2026 09:42:22 -0700

Sean Nash added Vendor - TEL - Arpita Srivastava to LEAHI-TD-FIRMWARE-LDT-3970-1

LEAHI-TD-FIRMWARE-LDT-3970_Edit Treatment Parameters During Treatment - FW Implementation - 1/4:

LEAHI-TD-FIRMWARE-LDT-3970-1: reviewers removed from LEAHI-TD-FIRMWARE-LDT-3970_Edit Treatment Paramete...

Wed, 29 Apr 2026 09:42:22 -0700

Sean Nash removed Dara Navaei , Stephen Quong and Tiffany Mejia from LEAHI-TD-FIRMWARE-LDT-3970-1

LEAHI-TD-FIRMWARE-LDT-3970_Edit Treatment Parameters During Treatment - FW Implementation - 1/4:

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "We can set bolus volume here now. These functi..."

Sean Nash — Sun, 26 Apr 2026 13:08:35 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

We can set bolus volume here now. These functions should be moved to TxParams where all of these settings exist and can be updated.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Why does confirm msg have duration again? If U..."

Sean Nash — Sun, 26 Apr 2026 13:05:44 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Why does confirm msg have duration again? If UI resends duration, we have to validate it again. If UI just sends confirmation of previously sent duration, we don't have to validate it again.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "These are already in TxParams I believe."

Sean Nash — Sun, 26 Apr 2026 13:02:17 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

These are already in TxParams I believe.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Should these be moved to Services\TxParams?"

Sean Nash — Sun, 26 Apr 2026 13:01:33 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Should these be moved to Services\TxParams?

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "Change 1 to TRUE"

Sean Nash — Sun, 26 Apr 2026 12:59:57 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Change 1 to TRUE

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "I think these message handlers for editing trea..."

Sean Nash — Sun, 26 Apr 2026 12:56:51 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

I think these message handlers for editing treatment parameters should be moved to Services\TxParams.

LEAHI-TD-FIRMWARE-LDT-3970-1: comment by Sean Nash "See if we have already defined this stuff in Se..."

Sean Nash — Sun, 26 Apr 2026 12:48:19 -0700

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

See if we have already defined this stuff in Services\TxParams. TxParams may also have get function(s) for min/max values that you can use.

LEAHI-TD-FIRMWARE-LDT-3970-1: started by Dara Navaei

Dara Navaei — Thu, 16 Apr 2026 19:32:48 -0700

Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-3970-1

LEAHI-TD-FIRMWARE-LDT-3259-1: reviewers removed from LEAHI-TD-FIRMWARE-LDT-3259_Software Update - TD

Sat, 11 Apr 2026 13:38:29 -0700

Dara Navaei removed Daniel Ho from LEAHI-TD-FIRMWARE-LDT-3259-1

LEAHI-TD-FIRMWARE-LDT-3259_Software Update - TD

LEAHI-TD-FIRMWARE-LDT-3259-1: comment by Sean Nash "Has integrity unit been added to TD project?"

Sean Nash — Fri, 27 Feb 2026 08:48:20 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3259-1

Has integrity unit been added to TD project?

LEAHI-TD-FIRMWARE-LDT-3259-1: comment by Sean Nash "Where are these being triggered?"

Sean Nash — Fri, 27 Feb 2026 08:44:19 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3259-1

Where are these being triggered?

LEAHI-TD-FIRMWARE-LDT-3259-1: comment by Sean Nash "Is this necessary? If so, why?"

Sean Nash — Fri, 27 Feb 2026 08:32:19 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3259-1

Is this necessary? If so, why?

td-firmware (LDT-2240-disposable-tube-set-self-test): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 19 Jan 2026 17:08:21 -0800

Dara Navaei committed 395522d on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td and 40 more in td-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmAudio.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmAudio.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Ejector.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Ejector.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/BubbleDetector.c

(-1, +1)

| History

| Source

| Diff

… 82 more files in changeset.