Fisheye on td-firmware/firmware/App/Controllers/AirPump.h https://devapps.diality.us/changelog/~br%3DLDT-1903-air-trap-level-control-dev--td---0/td-firmware/firmware/App/Controllers/AirPump.h Recent activity in "td-firmware" under directory /firmware/App/Controllers/AirPump.h LEAHI-TD-FIRMWARE-LDT-3215-1: reviewers finished Mon, 30 Mar 2026 09:40:36 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1 Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-3215-1 LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed ]]> LEAHI-TD-FIRMWARE-LDT-3215-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated" Thu, 19 Mar 2026 09:12:11 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28124 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28124 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-3215-1

Updated

]]> LEAHI-TD-FIRMWARE-LDT-3215-1: comment by Vendor - TEL - Varshini Nagabooshanam "Added" Thu, 19 Mar 2026 09:12:01 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28123 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28123 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-3215-1

Added

]]> LEAHI-TD-FIRMWARE-LDT-3215-1: comment by Sean Nash "If you change this line to "if ( ++airPumpStall..." Tue, 17 Mar 2026 21:46:11 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28108 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28108 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3215-1

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

]]> LEAHI-TD-FIRMWARE-LDT-3215-1: comment by Sean Nash "I was thinking that comment should go above the..." Tue, 17 Mar 2026 21:44:12 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28107 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28107 Sean Nash replied to Vendor - TEL - Varshini Nagabooshanam in LEAHI-TD-FIRMWARE-LDT-3215-1

I was thinking that comment should go above the first if statement.

]]> LEAHI-TD-FIRMWARE-LDT-3215-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated" Tue, 17 Mar 2026 15:05:52 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28098 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28098 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-3215-1

Updated

]]> LEAHI-TD-FIRMWARE-LDT-3215-1: comment by Sean Nash "Define what 3 means (#define up top). If 3 mea..." Tue, 17 Mar 2026 14:53:51 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28096 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28096 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3215-1

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

]]> LEAHI-TD-FIRMWARE-LDT-3215-1: comment by Vendor - TEL - Varshini Nagabooshanam "Added" Tue, 17 Mar 2026 14:56:01 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28097 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28097 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-3215-1

Added

]]> LEAHI-TD-FIRMWARE-LDT-3215-1: comment by Sean Nash "Add a comment explaining what we're looking for..." Tue, 17 Mar 2026 14:52:21 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28094 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28094 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3215-1

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

]]> LEAHI-TD-FIRMWARE-LDT-3215-1: comment by Vendor - TEL - Varshini Nagabooshanam "Added" Tue, 17 Mar 2026 14:52:37 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28095 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28095 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-3215-1

Added

]]> LEAHI-TD-FIRMWARE-LDT-3215-1: comment by Sean Nash "Should probably initialize your new stall count..." Tue, 17 Mar 2026 14:50:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28093 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28093 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3215-1

Should probably initialize your new stall counter variable.

]]> LEAHI-TD-FIRMWARE-LDT-3215-1: comment by Vendor - TEL - Varshini Nagabooshanam "[~snash] I need your help for writing this Alar..." Tue, 17 Mar 2026 14:08:58 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28092 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1/#c28092 Vendor - TEL - Varshini Nagabooshanam commented on LEAHI-TD-FIRMWARE-LDT-3215-1

Sean Nash I need your help for writing this Alarm properties.

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: closed by Vendor - TEL - Sameer Poyil Wed, 04 Mar 2026 20:22:26 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 Vendor - TEL - Sameer Poyil Closed LEAHI-TD-FIRMWARE-LDT-1903-8 ]]> td-firmware (LDT-1415-pressures-monitoring-td-updates): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 02 Mar 2026 21:01:14 -0800 Dara Navaei https://devapps.diality.us/changelog/td-firmware?cs=c049177f4d18a4740a357941b48a833d7115b581 https://devapps.diality.us/changelog/td-firmware?cs=c049177f4d18a4740a357941b48a833d7115b581 Dara Navaei committed c049177 on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td-baro and 19 more in td-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/AirPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/AirTrap.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/AirTrap.h (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/GLXferPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/GLXferPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/FpgaTD.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/FpgaTD.h (-2, +2) | History | Source | Diff
]]> LEAHI-TD-FIRMWARE-LDT-1903-8: reviewers resumed Mon, 02 Mar 2026 20:46:01 -0800 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 Sean Nash resumed reviewing LEAHI-TD-FIRMWARE-LDT-1903-8 LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation ]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "fixed in latest code" Mon, 02 Mar 2026 11:54:51 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27695 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27695 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

fixed in latest code

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "implemented" Mon, 02 Mar 2026 11:53:34 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27694 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27694 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

implemented

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "fixed" Mon, 02 Mar 2026 11:53:26 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27693 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27693 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

fixed

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "I think this would be a TD s/w fault (alarm alr..." Mon, 02 Mar 2026 09:52:52 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27674 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27674 Sean Nash replied to Vendor - TEL - Sameer Poyil in LEAHI-TD-FIRMWARE-LDT-1903-8

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "This structure doesn't seem necessary - it's ju..." Mon, 02 Mar 2026 09:50:52 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27673 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27673 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "Fixed" Mon, 02 Mar 2026 07:42:05 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27671 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27671 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

Fixed

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "removed from here" Mon, 02 Mar 2026 07:37:03 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27670 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27670 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

removed from here

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "fixed" Mon, 02 Mar 2026 07:36:38 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27669 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27669 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

fixed

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "We need new alarm . That should be included in ..." Fri, 27 Feb 2026 14:54:56 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27665 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27665 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Add blank line after declarations." Fri, 27 Feb 2026 13:32:31 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27664 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27664 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Add blank line after declarations.

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Alarm should be handled inside of setAirPumpSta..." Fri, 27 Feb 2026 13:32:13 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27663 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27663 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Alarm should be handled inside of setAirPumpState().

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Alarm should be handled inside of setAirPumpSta..." Fri, 27 Feb 2026 13:31:55 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27662 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27662 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Alarm should be handled inside of setAirPumpState().

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Alarm should be handled inside of setAirPumpSta..." Fri, 27 Feb 2026 13:31:38 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27661 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27661 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Alarm should be handled inside of setAirPumpState().

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Alarm should be handled inside of setAirPumpSta..." Fri, 27 Feb 2026 13:31:18 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27660 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27660 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Alarm should be handled inside of setAirPumpState().

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Alarm should be handled inside of setAirPumpSta..." Fri, 27 Feb 2026 13:31:01 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27659 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27659 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Alarm should be handled inside of setAirPumpState().

]]>