Fisheye on td-firmware/firmware/App/Controllers/Valves.c

td-firmware (LDT-2240-disposable-tube-set-self-test): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 19 Jan 2026 17:08:21 -0800

Dara Navaei committed 395522d on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td and 32 more in td-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmAudio.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmAudio.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Ejector.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Ejector.h

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-1, +1)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-2, +2)

| History

| Source

| Diff

· /firmware/App/Drivers/BubbleDetector.c

(-1, +1)

| History

| Source

| Diff

… 82 more files in changeset.

LEAHI-TD-FIRMWARE-LDT-1886-1: closed by Dara Navaei

Dara Navaei — Fri, 19 Dec 2025 13:57:43 -0800

Dara Navaei Closed LEAHI-TD-FIRMWARE-LDT-1886-1

td-firmware (LDT-2240-disposable-tube-set-self-test): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 19 Dec 2025 13:51:56 -0800

Dara Navaei committed 65a7fc8 on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td and 32 more in td-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/AirTrap.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Ejector.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Ejector.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/EjectorMotor.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/EjectorMotor.h	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/PressureSensor.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/RotaryValve.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/RotaryValve.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaTD.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaTD.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/TDCommon.h	(-1, +1)	\| History	\| Source	\| Diff

td-firmware (LDT-2240-disposable-tube-set-self-test): Merge branch 'staging' into LDT-1886-blood-set-auto-load-and-auto-eject-implement-ejector-sensor

Dara Navaei — Fri, 19 Dec 2025 13:48:01 -0800

Dara Navaei committed 1537847 on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td and 33 more in td-firmware

Merge branch 'staging' into LDT-1886-blood-set-auto-load-and-auto-eject-implement-ejector-sensor

· /firmware/App/Controllers/AirPump.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/AirTrap.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Ejector.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Ejector.h	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/EjectorMotor.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/EjectorMotor.h	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/PressureSensor.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/RotaryValve.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/RotaryValve.h	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaTD.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaTD.h	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-5, +5)	\| History	\| Source	\| Diff
· /firmware/App/TDCommon.h	(-9, +9)	\| History	\| Source	\| Diff

LEAHI-TD-FIRMWARE-LDT-1886-1: reviewers finished

Fri, 19 Dec 2025 12:16:13 -0800

Vendor - TEL - Sameer Poyil and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-1886-1

LEAHI-TD-FIRMWARE-LDT-1886_Blood Set Auto-Load and Auto-Eject - TD

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Dara Navaei "We tend to initialize the local variables as a ..."

Dara Navaei — Thu, 18 Dec 2025 15:08:24 -0800

Dara Navaei replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1886-1

We tend to initialize the local variables as a standard practice.

td-firmware (LDT-2240-disposable-tube-set-self-test): LDT-1886 updated the valves code to be able to rehome the valves if needed

Dara Navaei — Thu, 18 Dec 2025 15:01:38 -0800

Dara Navaei committed c1978d8 on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td and 33 more in td-firmware

LDT-1886 updated the valves code to be able to rehome the valves if needed

· /firmware/App/Controllers/Valves.c	(-2, +4)	\| History	\| Source	\| Diff
· /firmware/App/TDCommon.h	(-1, +1)	\| History	\| Source	\| Diff

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Sean Nash "These don't need to be initialized to zero."

Sean Nash — Thu, 18 Dec 2025 14:54:33 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1886-1

These don't need to be initialized to zero.

td-firmware (LDT-2240-disposable-tube-set-self-test): LDT-1886 fixed the valves round down the encoder to division of 8 all the time

Dara Navaei — Wed, 17 Dec 2025 13:50:57 -0800

Dara Navaei committed dcc1278 on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td and 33 more in td-firmware

LDT-1886 fixed the valves round down the encoder to division of 8 all the time

· /firmware/App/Controllers/Valves.c

(-8, +2)

| History

| Source

| Diff

td-firmware (LDT-2240-disposable-tube-set-self-test): LDT-1886 addressed the code review comments

Dara Navaei — Wed, 17 Dec 2025 11:11:38 -0800

Dara Navaei committed a0b8983 on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td and 33 more in td-firmware

LDT-1886 addressed the code review comments

· /firmware/App/Controllers/Ejector.c	(-31, +31)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.c	(-25, +25)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/RotaryValve.c	(-30, +30)	\| History	\| Source	\| Diff

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Dara Navaei "Done"

Dara Navaei — Wed, 17 Dec 2025 11:07:58 -0800

Dara Navaei replied to Vendor - TEL - Sameer Poyil in LEAHI-TD-FIRMWARE-LDT-1886-1

Done

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Dara Navaei "Done"

Dara Navaei — Wed, 17 Dec 2025 11:06:29 -0800

Dara Navaei replied to Vendor - TEL - Sameer Poyil in LEAHI-TD-FIRMWARE-LDT-1886-1

Done

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Dara Navaei "Done"

Dara Navaei — Wed, 17 Dec 2025 11:05:35 -0800

Dara Navaei replied to Vendor - TEL - Sameer Poyil in LEAHI-TD-FIRMWARE-LDT-1886-1

Done

td-firmware (LDT-2240-disposable-tube-set-self-test): LDT-1886 addressed the code review comments

Dara Navaei — Wed, 17 Dec 2025 11:04:08 -0800

Dara Navaei committed 5e92f25 on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td and 33 more in td-firmware

LDT-1886 addressed the code review comments

· /firmware/App/Controllers/Valves.c

(-37, +22)

| History

| Source

| Diff

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 16 Dec 2025 14:53:15 -0800

Dara Navaei replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1886-1

Done

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Dara Navaei "Done"

Dara Navaei — Wed, 17 Dec 2025 10:48:51 -0800

Dara Navaei replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1886-1

Done

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Dara Navaei "Done."

Dara Navaei — Tue, 16 Dec 2025 14:55:13 -0800

Dara Navaei replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1886-1

Done.

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Dara Navaei "No. It is permanent, I would like to know the v..."

Dara Navaei — Tue, 16 Dec 2025 14:53:43 -0800

Dara Navaei replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1886-1

No. It is permanent, I would like to know the value for the homing.

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Sean Nash "The else in this trinary looks wrong - doesn't ..."

Sean Nash — Tue, 16 Dec 2025 14:17:23 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1886-1

The else in this trinary looks wrong - doesn't round up to multiple of 8.

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Sean Nash "This if should have an else where we zero .valv..."

Sean Nash — Tue, 16 Dec 2025 14:15:04 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1886-1

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Sean Nash "Declarations should be at top of scope."

Sean Nash — Tue, 16 Dec 2025 14:13:58 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1886-1

Declarations should be at top of scope.

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Sean Nash "Is this temporary?"

Sean Nash — Tue, 16 Dec 2025 14:13:28 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1886-1

Is this temporary?

td-firmware (LDT-2240-disposable-tube-set-self-test): LDT-1886 updated the valves homing sequence

Dara Navaei — Tue, 16 Dec 2025 13:47:18 -0800

Dara Navaei committed eef2409 on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td and 33 more in td-firmware

LDT-1886 updated the valves homing sequence

· /firmware/App/Controllers/Valves.c	(-70, +159)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/Valves.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/EjectorMotor.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/RotaryValve.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/RotaryValve.h	(-3, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +2)	\| History	\| Source	\| Diff

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Dara Navaei "Done"

Dara Navaei — Tue, 16 Dec 2025 13:01:03 -0800

Dara Navaei replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1886-1

Done

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Sean Nash "Not sure how Doxygen will handle this comment b..."

Sean Nash — Mon, 15 Dec 2025 14:23:25 -0800

Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1886-1

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Dara Navaei "Done"

Dara Navaei — Sun, 14 Dec 2025 19:26:13 -0800

Dara Navaei replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1886-1

Done

td-firmware (LDT-2240-disposable-tube-set-self-test): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Fri, 12 Dec 2025 14:20:00 -0800

Dara Navaei committed b824ef4 on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td and 33 more in td-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/AirPump.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/AirTrap.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmAudio.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmAudio.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/AlarmLamp.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/BloodFlow.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Ejector.c

(-4, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/Ejector.h

(-4, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Drivers/BubbleDetector.c

(-4, +4)

| History

| Source

| Diff

… 80 more files in changeset.

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Vendor - TEL - Sameer Poyil "move static function after public function"

Vendor - TEL - Sameer Poyil — Thu, 11 Dec 2025 10:15:39 -0800

Vendor - TEL - Sameer Poyil commented on LEAHI-TD-FIRMWARE-LDT-1886-1

move static function after public function

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Vendor - TEL - Sameer Poyil "let public function on top"

Vendor - TEL - Sameer Poyil — Thu, 11 Dec 2025 10:14:01 -0800

Vendor - TEL - Sameer Poyil commented on LEAHI-TD-FIRMWARE-LDT-1886-1

let public function on top

LEAHI-TD-FIRMWARE-LDT-1886-1: comment by Vendor - TEL - Sameer Poyil "Let all public functions come on top for all fi..."

Vendor - TEL - Sameer Poyil — Thu, 11 Dec 2025 10:10:58 -0800

Vendor - TEL - Sameer Poyil commented on LEAHI-TD-FIRMWARE-LDT-1886-1

Let all public functions come on top for all files