Updated

Added

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

I was thinking that comment should go above the first if statement.

Updated

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

Added

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).

Added

Should probably initialize your new stall counter variable.

Sean Nash I need your help for writing this Alarm properties.

· /firmware/App/Controllers/AirTrap.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Bubbles.c	(-2, +2)	| History	| Source	| Diff

]]> Fri, 13 Mar 2026 15:21:43 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 Vendor - TEL - Praneeth Bunne Closed LEAHI-TD-FIRMWARE-LDT-3600-1 ]]> Fri, 13 Mar 2026 14:52:51 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/changelog/td-firmware?cs=2ecbfd1ca70fd29f322dad5e12b7332db5b1a73b https://devapps.diality.us/changelog/td-firmware?cs=2ecbfd1ca70fd29f322dad5e12b7332db5b1a73b Vendor - TEL - Praneeth Bunne committed 2ecbfd1 on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 13 more in td-firmware Merge branch 'LDT-3600-request-for-td-test-config-for' into staging

· /firmware/App/Monitors/Bubbles.c

(-1, +6)

| History

| Source

| Diff

]]> Fri, 13 Mar 2026 14:47:47 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 Vinayakam Mani , Vendor - TEL - Jashwant Gantyada and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-3600-1 LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD ]]> Fri, 13 Mar 2026 14:23:39 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 Sean Nash added Vendor - TEL - Jashwant Gantyada and Vinayakam Mani to LEAHI-TD-FIRMWARE-LDT-3600-1 LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD ]]> Fri, 13 Mar 2026 13:45:19 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1/#c28029 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1/#c28029 Vinayakam Mani commented on LEAHI-TD-FIRMWARE-LDT-3600-1

Can we remove the empty lines after if / else if blocks in this function?

· /firmware/App/Monitors/Bubbles.c

(-2, +2)

| History

| Source

| Diff

]]> Fri, 13 Mar 2026 11:30:06 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3539-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3539-1 Vendor - TEL - Varshini Nagabooshanam Closed LEAHI-TD-FIRMWARE-LDT-3539-1 ]]> Fri, 13 Mar 2026 11:28:56 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3539-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3539-1 Dara Navaei finished reviewing LEAHI-TD-FIRMWARE-LDT-3539-1 LEAHI-TD-FIRMWARE-LDT-3539_Air Infusion - TD ]]> Thu, 12 Mar 2026 13:47:28 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/changelog/td-firmware?cs=539f3837b28f2c3998b559aae085eb8fd872e334 https://devapps.diality.us/changelog/td-firmware?cs=539f3837b28f2c3998b559aae085eb8fd872e334 Vendor - TEL - Praneeth Bunne committed 539f383 on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 14 more in td-firmware Minor formatting and logic cleanup.

· /firmware/App/Controllers/AirTrap.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Bubbles.c	(-1, +1)	| History	| Source	| Diff

]]> Wed, 11 Mar 2026 17:38:36 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/changelog/td-firmware?cs=17d7a287b62351847759e24e5be390db19c4a531 https://devapps.diality.us/changelog/td-firmware?cs=17d7a287b62351847759e24e5be390db19c4a531 Vendor - TEL - Praneeth Bunne committed 17d7a28 on branch LDT-1415-pressures-monitoring-td-baro, LDT-1886-blood-set-auto-load-and-auto-ej and 14 more in td-firmware LDT-3600: Skip air trap fill, lowerevents and venous bubble alarm when testing without tubing set.

· /firmware/App/Controllers/AirTrap.c	(-0, +7)	| History	| Source	| Diff
· /firmware/App/Monitors/Bubbles.c	(-1, +6)	| History	| Source	| Diff

]]> Wed, 11 Mar 2026 15:31:36 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-3600-1 ]]> Fri, 20 Feb 2026 13:48:47 -0800 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3539-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3539-1 Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-3539-1 LEAHI-TD-FIRMWARE-LDT-3539_Air Infusion - TD ]]> Fri, 20 Feb 2026 13:08:22 -0800 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3539-1/#c27504 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3539-1/#c27504 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-3539-1

Updated