· /firmware/App/Controllers/ROPump.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/WaterQualityMonitor.c	(-1, +1)	| History	| Source	| Diff

]]> Wed, 21 Jan 2026 10:10:21 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-1925-1 ]]> Wed, 21 Jan 2026 09:46:06 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 Michael Garthwaite finished reviewing LEAHI-DD-FIRMWARE-LDT-1925-1 LEAHI-DD-FIRMWARE-LDT-1925_IOFP - Understand lag in P16 flow measurement vs. P7 flow measurement after RO pump startup ]]> Tue, 20 Jan 2026 14:19:07 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-1925-1 LEAHI-DD-FIRMWARE-LDT-1925_IOFP - Understand lag in P16 flow measurement vs. P7 flow measurement after RO pump startup ]]> Tue, 20 Jan 2026 14:15:56 -0800 Raghu Kallala https://devapps.diality.us/changelog/dd-firmware?cs=7b70f5410bf7532b1722be7310e74e998e387cb9 https://devapps.diality.us/changelog/dd-firmware?cs=7b70f5410bf7532b1722be7310e74e998e387cb9 Raghu Kallala committed 7b70f54 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 53 more in dd-firmware LDT-1925 addressed review comments

· /firmware/App/Controllers/ROPump.c	(-8, +8)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/WaterQualityMonitor.c	(-1, +1)	| History	| Source	| Diff

]]> Tue, 20 Jan 2026 14:14:53 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26471 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26471 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1925-1

Updated

Added

Updated

Fixed

TRUE if low flow alarm is exempt, FALSE if not.

timeSinceP12Started?

Should we have a comment for this one too?

Should we rename this function to "isROPumpLowflowAlarmExempt"? The current name makes me think it will set the alarm to be exempt.

Updated to use isPersistentAlarmTriggered

Fixed

Updated

Updated

Changed the implementation

Fixed

· /firmware/App/Controllers/ROPump.c	(-34, +29)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.h	(-2, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-0, +5)	| History	| Source	| Diff
· /firmware/App/Monitors/WaterQualityMonitor.c	(-9, +9)	| History	| Source	| Diff

]]> Tue, 20 Jan 2026 09:58:08 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26452 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26452 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-1925-1

Why are we setting timer for pressure and PWM controls? Isn't it only applicable in flow control?
And why aren't we resetting exempt flag in same place as timer?

I think this function should return TRUE if exempt (we are in first 10 seconds of flow control from off state). All criteria checked here in this function.

I think timer should be internal (private) to this unit.

We need to be calling the isPersistentAlarm function regardless of exemption, but only triggering the alarm if persistent alarm function returns TRUE and exemption is FALSE.

I think timeout should be handled inside ROPump unit. From here, we should just call one function that tells us whether alarm should be exempt or not.

For init functions, I think it's ok (and cleaner) to just say we initialize ALL unit variables.