Fisheye on ro-firmware/firmware/App/Drivers/InternalADC.c

ro-firmware (staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 18 Dec 2025 10:27:26 -0800

Dara Navaei committed ca95dc7 on branch LDT-2116-iofp-evaluate-closing-p39, staging in ro-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BoostPump.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/BoostPump.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Controllers/PermeateTank.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/PermeateTank.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.c

(-4, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/ROPump.h

(-4, +4)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Controllers/Valves.h

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.c

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Drivers/ConductivitySensor.h

(-6, +6)

| History

| Source

| Diff

· /firmware/App/Drivers/FlowSensor.c

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Drivers/FlowSensor.h

(-3, +3)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.c

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Drivers/FluidPump.h

(-5, +5)

| History

| Source

| Diff

· /firmware/App/Drivers/InternalADC.c

(-0, +16)

| History

| Source

| Diff

… 67 more files in changeset.

LEAHI-RO-FIRMWARE-LDT-828-1: closed by Michael Garthwaite

Michael Garthwaite — Wed, 03 Sep 2025 08:52:54 -0700

Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-828-1

LEAHI-RO-FIRMWARE-LDT-1242-1: closed by Michael Garthwaite

Michael Garthwaite — Wed, 03 Sep 2025 08:52:47 -0700

Michael Garthwaite Closed LEAHI-RO-FIRMWARE-LDT-1242-1

LEAHI-RO-FIRMWARE-LDT-828-1: started by Dara Navaei

Dara Navaei — Tue, 02 Sep 2025 10:03:23 -0700

Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-828-1

LEAHI-RO-FIRMWARE-LDT-1242-1: started by Dara Navaei

Dara Navaei — Tue, 02 Sep 2025 10:03:14 -0700

Dara Navaei started review LEAHI-RO-FIRMWARE-LDT-1242-1

RO-LEAH-1972-1: closed by Sean Nash

Sean Nash — Thu, 23 Jan 2025 14:32:43 -0800

Sean Nash Closed RO-LEAH-1972-1

RO-LEAH-1972-1: reviewers finished

Thu, 23 Jan 2025 14:07:39 -0800

Michael Garthwaite finished reviewing RO-LEAH-1972-1

RO-LEAH-1972_RO Integration Changes

RO-LEAH-1972-1: reviewers finished

Wed, 22 Jan 2025 11:14:50 -0800

Vinayakam Mani finished reviewing RO-LEAH-1972-1

RO-LEAH-1972_RO Integration Changes

RO-LEAH-1972-1: comment by Sean Nash "Fixed."

Sean Nash — Wed, 22 Jan 2025 11:01:28 -0800

Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Fixed.

RO-LEAH-1972-1: comment by Sean Nash "Done."

Sean Nash — Wed, 22 Jan 2025 11:00:24 -0800

Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Done.

RO-LEAH-1972-1: comment by Sean Nash "Done."

Sean Nash — Wed, 22 Jan 2025 10:58:23 -0800

Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Done.

RO-LEAH-1972-1: comment by Sean Nash "Fixed."

Sean Nash — Wed, 22 Jan 2025 10:56:06 -0800

Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Fixed.

RO-LEAH-1972-1: comment by Sean Nash "Done."

Sean Nash — Wed, 22 Jan 2025 10:53:41 -0800

Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Done.

RO-LEAH-1972-1: comment by Sean Nash "Fixed."

Sean Nash — Wed, 22 Jan 2025 10:44:40 -0800

Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Fixed.

RO-LEAH-1972-1: comment by Sean Nash "Done."

Sean Nash — Wed, 22 Jan 2025 10:43:40 -0800

Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Done.

RO-LEAH-1972-1: comment by Sean Nash "Pressure sensor temps to stay with pressure as ..."

Sean Nash — Wed, 22 Jan 2025 10:31:20 -0800

Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Pressure sensor temps to stay with pressure as these temps do not have their own component designator on the flow path.

RO-LEAH-1972-1: comment by Sean Nash "Done."

Sean Nash — Wed, 22 Jan 2025 10:37:08 -0800

Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Done.

RO-LEAH-1972-1: comment by Sean Nash "Done."

Sean Nash — Wed, 22 Jan 2025 10:30:58 -0800

Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Done.

RO-LEAH-1972-1: comment by Vinayakam Mani "Please update the naming order."

Vinayakam Mani — Wed, 22 Jan 2025 10:10:21 -0800

Vinayakam Mani commented on RO-LEAH-1972-1

Please update the naming order.

RO-LEAH-1972-1: comment by Vinayakam Mani "Do we need to move this to temperature.c (like ..."

Vinayakam Mani — Wed, 22 Jan 2025 10:07:31 -0800

Vinayakam Mani commented on RO-LEAH-1972-1

Do we need to move this to temperature.c (like you moved it for flow sensor). We have temperature for Pressure and conductivity sensors. do we all need to move to one location?

RO-LEAH-1972-1: comment by Vinayakam Mani "Please update the component ID first, followed ..."

Vinayakam Mani — Wed, 22 Jan 2025 10:04:21 -0800

Vinayakam Mani commented on RO-LEAH-1972-1

Please update the component ID first, followed by sensor name (for both temperature and pressure).

RO-LEAH-1972-1: comment by Sean Nash "Fixed."

Sean Nash — Wed, 22 Jan 2025 10:03:17 -0800

Sean Nash replied to Vinayakam Mani in RO-LEAH-1972-1

Fixed.

RO-LEAH-1972-1: comment by Vinayakam Mani "Needs to be cleaned up for RO."

Vinayakam Mani — Wed, 22 Jan 2025 10:01:41 -0800

Vinayakam Mani commented on RO-LEAH-1972-1

Needs to be cleaned up for RO.

RO-LEAH-1972-1: comment by Vinayakam Mani "RO floater"

Vinayakam Mani — Wed, 22 Jan 2025 09:59:51 -0800

Vinayakam Mani commented on RO-LEAH-1972-1

RO floater

RO-LEAH-1972-1: comment by Vinayakam Mani "Just to be consistent, can we change it to p7Fl..."

Vinayakam Mani — Wed, 22 Jan 2025 09:57:41 -0800

Vinayakam Mani commented on RO-LEAH-1972-1

Just to be consistent, can we change it to p7Flow (instead of FlowP7)? same for P16flow.

RO-LEAH-1972-1: comment by Vinayakam Mani "Index needs to be updated per latest changes."

Vinayakam Mani — Wed, 22 Jan 2025 09:54:01 -0800

Vinayakam Mani commented on RO-LEAH-1972-1

Index needs to be updated per latest changes.

RO-LEAH-1972-1: comment by Vinayakam Mani "This need to be cleaned up for RO."

Vinayakam Mani — Wed, 22 Jan 2025 09:48:20 -0800

Vinayakam Mani commented on RO-LEAH-1972-1

This need to be cleaned up for RO.

RO-LEAH-1972-1: comment by Vinayakam Mani "I guess this need to be cleaned up for RO."

Vinayakam Mani — Wed, 22 Jan 2025 09:42:19 -0800

Vinayakam Mani commented on RO-LEAH-1972-1

I guess this need to be cleaned up for RO.

RO-LEAH-1972-1: comment by Vinayakam Mani "CPI, CPO to be referred as P9 and P18? when th..."

Vinayakam Mani — Wed, 22 Jan 2025 09:39:00 -0800

Vinayakam Mani commented on RO-LEAH-1972-1

CPI, CPO to be referred as P9 and P18? when the code is uncommented, there is a possibility of leaving CPI/CPO as it is.

RO-LEAH-1972-1: comment by Vinayakam Mani "Please update 'ropump' as 'P12Pump' and 'bstPum..."

Vinayakam Mani — Wed, 22 Jan 2025 09:34:00 -0800

Vinayakam Mani commented on RO-LEAH-1972-1

Please update 'ropump' as 'P12Pump' and 'bstPump' as 'P40Pump'.