Fisheye on leahi-fwcommon/NVJobQ.h

LEAHI-DD-FIRMWARE-LDT-3735-1: closed by Vendor - TEL - Arpita Srivastava

Vendor - TEL - Arpita Srivastava — Thu, 30 Jul 2026 11:23:44 -0700

Vendor - TEL - Arpita Srivastava Closed LEAHI-DD-FIRMWARE-LDT-3735-1

LEAHI-DD-FIRMWARE-LDT-3735-1: reviewers finished

Thu, 30 Jul 2026 10:23:26 -0700

Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3735-1

LEAHI-DD-FIRMWARE-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation

LEAHI-DD-FIRMWARE-LDT-3735-1: reviewers finished

Wed, 29 Jul 2026 17:37:37 -0700

Dara Navaei finished reviewing LEAHI-DD-FIRMWARE-LDT-3735-1

LEAHI-DD-FIRMWARE-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation

leahi-fwcommon (LDT-2118-main-treatment-screen---td---vectorcast-tests-7-31-2026): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 29 Jul 2026 11:06:22 -0700

Dara Navaei committed 0b8f91f on branch LDT-2118-main-treatment-screen---td---vectorcast-tests-7-31-2026, LDT-3735-non-volatile-memory and 7 more in leahi-fwcommon

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /NVDriver.c	(-2, +5)	\| History	\| Source	\| Diff
· /NVDriver.h	(-2, +5)	\| History	\| Source	\| Diff
· /NVJobQ.c	(-2, +5)	\| History	\| Source	\| Diff
· /NVJobQ.h	(-2, +5)	\| History	\| Source	\| Diff
· /NVMgmt.c	(-2, +5)	\| History	\| Source	\| Diff
· /NVMgmt.h	(-2, +5)	\| History	\| Source	\| Diff
· /TestSupport.h	(-2, +2)	\| History	\| Source	\| Diff
· /WatchdogMgmt.c	(-2, +2)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Vendor - TEL - Arpita Srivastava "Added but crucible is not showing this change. ..."

Vendor - TEL - Arpita Srivastava — Mon, 27 Jul 2026 11:21:48 -0700

Vendor - TEL - Arpita Srivastava replied to Dara Navaei in LEAHI-DD-FIRMWARE-LDT-3735-1

Added but crucible is not showing this change. Please check bitbucket.

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Vendor - TEL - Arpita Srivastava "These variables are correctly initialized to th..."

Vendor - TEL - Arpita Srivastava — Mon, 27 Jul 2026 11:17:24 -0700

Vendor - TEL - Arpita Srivastava replied to Dara Navaei in LEAHI-DD-FIRMWARE-LDT-3735-1

These variables are correctly initialized to the first enum in the list.

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Vendor - TEL - Arpita Srivastava "Not needed because the retry mechanism is going..."

Vendor - TEL - Arpita Srivastava — Mon, 27 Jul 2026 11:16:26 -0700

Vendor - TEL - Arpita Srivastava replied to Dara Navaei in LEAHI-DD-FIRMWARE-LDT-3735-1

Not needed because the retry mechanism is going to be deleted in the next ticket.

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Vendor - TEL - Arpita Srivastava "I would rather keep it. Anyways, we need an els..."

Vendor - TEL - Arpita Srivastava — Mon, 27 Jul 2026 11:16:00 -0700

Vendor - TEL - Arpita Srivastava replied to Dara Navaei in LEAHI-DD-FIRMWARE-LDT-3735-1

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Vendor - TEL - Arpita Srivastava "I would rather keep it. Anyways, we need an els..."

Vendor - TEL - Arpita Srivastava — Mon, 27 Jul 2026 11:15:44 -0700

Vendor - TEL - Arpita Srivastava replied to Dara Navaei in LEAHI-DD-FIRMWARE-LDT-3735-1

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Vendor - TEL - Arpita Srivastava "Not needed because the retry mechanism is going..."

Vendor - TEL - Arpita Srivastava — Mon, 27 Jul 2026 11:14:24 -0700

Vendor - TEL - Arpita Srivastava replied to Dara Navaei in LEAHI-DD-FIRMWARE-LDT-3735-1

Not needed because the retry mechanism is going to be deleted in the next ticket.

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Dara Navaei "Same question as above: should we alarm if the ..."

Dara Navaei — Thu, 23 Jul 2026 11:22:59 -0700

Dara Navaei commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Same question as above: should we alarm if the retries failed?

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Dara Navaei "This else is not needed because isFlashAddressV..."

Dara Navaei — Thu, 23 Jul 2026 11:06:11 -0700

Dara Navaei commented on LEAHI-DD-FIRMWARE-LDT-3735-1

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Dara Navaei "This else is not needed because isFlashAddressV..."

Dara Navaei — Thu, 23 Jul 2026 11:04:42 -0700

Dara Navaei commented on LEAHI-DD-FIRMWARE-LDT-3735-1

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Dara Navaei "If a retry goes wrong will you trigger an alarm..."

Dara Navaei — Thu, 23 Jul 2026 10:39:19 -0700

Dara Navaei commented on LEAHI-DD-FIRMWARE-LDT-3735-1

If a retry goes wrong will you trigger an alarm?

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Dara Navaei "Any fault alarm here?"

Dara Navaei — Thu, 23 Jul 2026 10:31:43 -0700

Dara Navaei commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Any fault alarm here?

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Dara Navaei "Have these variables been initialized correctly..."

Dara Navaei — Thu, 23 Jul 2026 10:18:31 -0700

Dara Navaei commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Have these variables been initialized correctly?

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Remove extra blank line."

Sean Nash — Wed, 22 Jul 2026 13:26:51 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "We generally don't add { } to switch cases unle..."

Sean Nash — Wed, 22 Jul 2026 13:13:12 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

We generally don't add { } to switch cases unless they require local variable declarations.

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "If we're not including a timestamp, can we just..."

Sean Nash — Wed, 22 Jul 2026 13:08:53 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

If we're not including a timestamp, can we just remove this line of code?

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Why commented out?"

Sean Nash — Wed, 22 Jul 2026 13:07:59 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Why commented out?

LEAHI-DD-FIRMWARE-LDT-5157-1: started by Dara Navaei

Dara Navaei — Wed, 15 Jul 2026 09:48:45 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-5157-1

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Remove blank line."

Sean Nash — Tue, 14 Jul 2026 14:43:08 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "If this is a override message handler, it is no..."

Sean Nash — Tue, 14 Jul 2026 14:41:49 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Can we have a payload structure (packed to 1 by..."

Sean Nash — Tue, 14 Jul 2026 14:36:09 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line between declarations and rest of..."

Sean Nash — Tue, 14 Jul 2026 14:31:17 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line between declarations and rest of function code (throughout this unit)

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line before return statement. ( thro..."

Sean Nash — Tue, 14 Jul 2026 14:31:30 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line before return statement. ( throughout this unit )

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line before return statement."

Sean Nash — Tue, 14 Jul 2026 14:31:08 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line before return statement.

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line between declarations and rest of..."

Sean Nash — Tue, 14 Jul 2026 14:30:54 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line between declarations and rest of function code.

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line between declarations and rest of..."

Sean Nash — Tue, 14 Jul 2026 14:30:40 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line between declarations and rest of function code.

LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line between declarations and rest of..."

Sean Nash — Tue, 14 Jul 2026 14:30:32 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line between declarations and rest of function code.