· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

]]> Fri, 23 Jan 2026 13:03:18 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-2977-1 ]]> Fri, 23 Jan 2026 13:02:17 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1 Sean Nash and Raghu Kallala finished reviewing LEAHI-DD-FIRMWARE-LDT-2977-1 LEAHI-DD-FIRMWARE-LDT-2977_IOFP - Update starting flow estimations based on recovery mode ]]> Fri, 23 Jan 2026 12:55:02 -0800 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=a59557e653a712fcdebb7928a74514b2108f44ea https://devapps.diality.us/changelog/dd-firmware?cs=a59557e653a712fcdebb7928a74514b2108f44ea Michael Garthwaite committed a59557e on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 50 more in dd-firmware LDT-2977: code review adjust

· /firmware/App/Controllers/ROPump.c

(-2, +0)

| History

| Source

| Diff

]]> Fri, 23 Jan 2026 12:51:22 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26590 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26590 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-2977-1

fixed.

· /firmware/App/Controllers/ROPump.c

(-0, +5)

| History

| Source

| Diff

]]> Fri, 23 Jan 2026 12:49:14 -0800 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=f9d0e15ba8e25a69666ed0231721ea58e2145f2f https://devapps.diality.us/changelog/dd-firmware?cs=f9d0e15ba8e25a69666ed0231721ea58e2145f2f Michael Garthwaite committed f9d0e15 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 50 more in dd-firmware LDT-2977: code review comments.

· /firmware/App/Controllers/ROPump.c

(-2, +2)

| History

| Source

| Diff

]]> Fri, 23 Jan 2026 12:45:04 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26589 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26589 Sean Nash replied to Michael Garthwaite in LEAHI-DD-FIRMWARE-LDT-2977-1

When comment is above, use /// instead of ///<. And add blank lines before/after - doxygen seems to get confused about where to apply the comment without clear separation.

fixed for both _TO_PWM macros

its been removed. looks like we send everything down as a percentage now and the fluid pump driver will change it counts.

· /firmware/App/Controllers/ROPump.c

(-6, +4)

| History

| Source

| Diff

]]> Fri, 23 Jan 2026 12:06:09 -0800 Michael Garthwaite https://devapps.diality.us/changelog/dd-firmware?cs=19dd28ed9c1c81d3bbf50e7a6bf691f19be0b54e https://devapps.diality.us/changelog/dd-firmware?cs=19dd28ed9c1c81d3bbf50e7a6bf691f19be0b54e Michael Garthwaite committed 19dd28e on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 50 more in dd-firmware Merge branch 'staging' into LDT-2977-iofp-update

· /firmware/App/Controllers/ROPump.c

(-19, +51)

| History

| Source

| Diff

]]> Fri, 23 Jan 2026 09:50:58 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26585 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1/#c26585 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-2977-1

For long macros, consider moving doxygen comment from right side to line above with /// since right side won't line up with others.

I don't see this macro being used anywhere.

· /firmware/App/Controllers/ROPump.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/WaterQualityMonitor.c	(-1, +1)	| History	| Source	| Diff

]]> Wed, 21 Jan 2026 10:10:21 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-1925-1 ]]> Wed, 21 Jan 2026 09:46:06 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 Michael Garthwaite finished reviewing LEAHI-DD-FIRMWARE-LDT-1925-1 LEAHI-DD-FIRMWARE-LDT-1925_IOFP - Understand lag in P16 flow measurement vs. P7 flow measurement after RO pump startup ]]> Tue, 20 Jan 2026 14:19:07 -0800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-1925-1 LEAHI-DD-FIRMWARE-LDT-1925_IOFP - Understand lag in P16 flow measurement vs. P7 flow measurement after RO pump startup ]]> Tue, 20 Jan 2026 14:15:56 -0800 Raghu Kallala https://devapps.diality.us/changelog/dd-firmware?cs=7b70f5410bf7532b1722be7310e74e998e387cb9 https://devapps.diality.us/changelog/dd-firmware?cs=7b70f5410bf7532b1722be7310e74e998e387cb9 Raghu Kallala committed 7b70f54 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1473-ultrafiltration---dd-2 and 51 more in dd-firmware LDT-1925 addressed review comments

· /firmware/App/Controllers/ROPump.c	(-8, +8)	| History	| Source	| Diff
· /firmware/App/Controllers/ROPump.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Modes/FPModes/StateFlushPermeate.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/WaterQualityMonitor.c	(-1, +1)	| History	| Source	| Diff

]]> Tue, 20 Jan 2026 14:14:53 -0800 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26471 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1925-1/#c26471 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1925-1

Updated

Added

Updated

Fixed

TRUE if low flow alarm is exempt, FALSE if not.

timeSinceP12Started?

Should we have a comment for this one too?

Should we rename this function to "isROPumpLowflowAlarmExempt"? The current name makes me think it will set the alarm to be exempt.