Fisheye on dd-firmware/firmware/App/Controllers/PistonPumpControl.c https://devapps.diality.us/changelog/~br%3DLDT-319-basic-dialysis-treatment-dd-UIT/dd-firmware/firmware/App/Controllers/PistonPumpControl.c Recent activity in "dd-firmware" under directory /firmware/App/Controllers/PistonPumpControl.c LEAHI-DD-FIRMWARE-LDT-2004-13: started by Dara Navaei Wed, 25 Mar 2026 04:01:46 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-13 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-13 ]]> LEAHI-DD-FIRMWARE-LDT-2004-11: started by Dara Navaei Thu, 19 Mar 2026 15:47:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-11 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-2004-11 ]]> DD-LDT-1735-1: closed by ven.smathamala Wed, 03 Sep 2025 15:07:08 -0700 ven.smathamala https://devapps.diality.us/cru/DD-LDT-1735-1 https://devapps.diality.us/cru/DD-LDT-1735-1 ven.smathamala  (deleted user) Closed DD-LDT-1735-1 ]]> DD-LDT-1735-1: reviewers finished Wed, 03 Sep 2025 14:56:08 -0700 https://devapps.diality.us/cru/DD-LDT-1735-1 https://devapps.diality.us/cru/DD-LDT-1735-1 Sean Nash and Vinayakam Mani finished reviewing DD-LDT-1735-1 DD-LDT-1735_Test Config Support For DD ]]> DD-LDT-1735-1: comment by Sean Nash "Fixed." Fri, 29 Aug 2025 11:05:38 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1735-1/#c23975 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23975 Sean Nash replied to Vinayakam Mani in DD-LDT-1735-1

Fixed.

]]> DD-LDT-1735-1: comment by ven.smathamala "Fixed ." Fri, 29 Aug 2025 10:51:48 -0700 ven.smathamala https://devapps.diality.us/cru/DD-LDT-1735-1/#c23973 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23973 ven.smathamala  (deleted user) replied to Vinayakam Mani in DD-LDT-1735-1

Fixed .

]]> DD-LDT-1735-1: comment by Vinayakam Mani "I guess, you should still need 'TestingActivate..." Fri, 29 Aug 2025 10:36:37 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1735-1/#c23971 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23971 Vinayakam Mani commented on DD-LDT-1735-1

I guess, you should still need 'TestingActivated' check, due to a reason when system team wants to change the states as part of their testing.

]]> DD-LDT-1735-1: comment by Vinayakam Mani "timePerStep is not initialized with the values ..." Fri, 29 Aug 2025 10:34:47 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1735-1/#c23970 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23970 Vinayakam Mani commented on DD-LDT-1735-1

timePerStep is not initialized with the values and being used here.

]]> DD-LDT-1735-1: comment by ven.smathamala "Swapped." Mon, 25 Aug 2025 11:53:17 -0700 ven.smathamala https://devapps.diality.us/cru/DD-LDT-1735-1/#c23860 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23860 ven.smathamala  (deleted user) replied to Sean Nash in DD-LDT-1735-1

Swapped.

]]> DD-LDT-1735-1: comment by ven.smathamala "Fixed." Mon, 25 Aug 2025 11:51:49 -0700 ven.smathamala https://devapps.diality.us/cru/DD-LDT-1735-1/#c23859 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23859 ven.smathamala  (deleted user) replied to Vinayakam Mani in DD-LDT-1735-1

Fixed.

]]> DD-LDT-1735-1: comment by ven.smathamala "Fixed." Mon, 25 Aug 2025 11:49:36 -0700 ven.smathamala https://devapps.diality.us/cru/DD-LDT-1735-1/#c23858 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23858 ven.smathamala  (deleted user) replied to Vinayakam Mani in DD-LDT-1735-1

Fixed.

]]> DD-LDT-1735-1: comment by Vinayakam Mani "It should be equal to true? ( getTestConfigS..." Fri, 22 Aug 2025 16:04:00 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1735-1/#c23857 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23857 Vinayakam Mani commented on DD-LDT-1735-1

It should be equal to true?

( getTestConfigStatus( TEST_CONFIG_DISABLE_BC_PRESSURE_ALARMS ) == TRUE )

]]> DD-LDT-1735-1: comment by Vinayakam Mani "Add open and close parenthesis." Fri, 22 Aug 2025 15:41:08 -0700 Vinayakam Mani https://devapps.diality.us/cru/DD-LDT-1735-1/#c23856 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23856 Vinayakam Mani commented on DD-LDT-1735-1

Add open and close parenthesis.

]]> DD-LDT-1735-1: comment by Sean Nash "Beta and Alpha are swapped here. Beta should b..." Fri, 22 Aug 2025 13:30:07 -0700 Sean Nash https://devapps.diality.us/cru/DD-LDT-1735-1/#c23850 https://devapps.diality.us/cru/DD-LDT-1735-1/#c23850 Sean Nash commented on DD-LDT-1735-1

Beta and Alpha are swapped here. Beta should be -14.... and Alpha should be 0.0.

]]> DD-LDT-1735-1: started by Dara Navaei Wed, 20 Aug 2025 10:02:30 -0700 Dara Navaei https://devapps.diality.us/cru/DD-LDT-1735-1 https://devapps.diality.us/cru/DD-LDT-1735-1 Dara Navaei started review DD-LDT-1735-1 ]]> DD-LEAH-224-1: closed by Vinayakam Mani Mon, 24 Feb 2025 15:46:33 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-224-1 https://devapps.diality.us/cru/DD-LEAH-224-1 Vinayakam Mani Closed DD-LEAH-224-1 ]]> DD-LEAH-224-1: reviewers finished Mon, 24 Feb 2025 14:19:13 -0800 https://devapps.diality.us/cru/DD-LEAH-224-1 https://devapps.diality.us/cru/DD-LEAH-224-1 Michael Garthwaite and Sean Nash finished reviewing DD-LEAH-224-1 DD-LEAH-224_FW DD Gear Pump Driver 1 ]]> DD-LEAH-224-1: comment by Vinayakam Mani "Done." Mon, 24 Feb 2025 12:48:41 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-224-1/#c21564 https://devapps.diality.us/cru/DD-LEAH-224-1/#c21564 Vinayakam Mani replied to Sean Nash in DD-LEAH-224-1

Done.

]]> DD-LEAH-224-1: comment by Sean Nash "Update @return comment." Mon, 24 Feb 2025 12:39:07 -0800 Sean Nash https://devapps.diality.us/cru/DD-LEAH-224-1/#c21563 https://devapps.diality.us/cru/DD-LEAH-224-1/#c21563 Sean Nash commented on DD-LEAH-224-1

Update @return comment.

]]> dd-firmware (LDT-1916-rename_ro_to_fp_in_dd): Code review udpate Mon, 24 Feb 2025 11:30:03 -0800 Vinayakam Mani https://devapps.diality.us/changelog/dd-firmware?cs=5126b79e4970ffe2ed9db4cccea18a1216c78570 https://devapps.diality.us/changelog/dd-firmware?cs=5126b79e4970ffe2ed9db4cccea18a1216c78570 Vinayakam Mani committed 5126b79 on branch BambooSetup, LDT-1195-dd-is-balancing-chamber-switching and 96 more in dd-firmware Code review udpate

· /firmware/App/Controllers/BalancingChamber.c (-23, +14) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/ConcentratePumps.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/DialysatePumps.c (-32, +0) | History | Source | Diff
· /firmware/App/Controllers/PistonPumpControl.c (-2, +2) | History | Source | Diff
· /firmware/App/DDCommon.h (-4, +0) | History | Source | Diff
· /firmware/App/Modes/ModeGenDialysate.c (-14, +4) | History | Source | Diff
· /firmware/App/Monitors/Level.c (-2, +0) | History | Source | Diff
· /firmware/App/Monitors/Pressure.c (-14, +0) | History | Source | Diff
]]> DD-LEAH-224-1: comment by Vinayakam Mani "Removed. Done." Mon, 24 Feb 2025 11:23:40 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-224-1/#c21562 https://devapps.diality.us/cru/DD-LEAH-224-1/#c21562 Vinayakam Mani replied to Sean Nash in DD-LEAH-224-1

Removed. Done.

]]> DD-LEAH-224-1: comment by Vinayakam Mani "Done." Mon, 24 Feb 2025 11:15:16 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-224-1/#c21561 https://devapps.diality.us/cru/DD-LEAH-224-1/#c21561 Vinayakam Mani replied to Sean Nash in DD-LEAH-224-1

Done.

]]> DD-LEAH-224-1: comment by Vinayakam Mani "Done." Mon, 24 Feb 2025 11:12:02 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-224-1/#c21560 https://devapps.diality.us/cru/DD-LEAH-224-1/#c21560 Vinayakam Mani replied to Sean Nash in DD-LEAH-224-1

Done.

]]> DD-LEAH-224-1: comment by Vinayakam Mani "Done." Mon, 24 Feb 2025 11:11:55 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-224-1/#c21559 https://devapps.diality.us/cru/DD-LEAH-224-1/#c21559 Vinayakam Mani replied to Sean Nash in DD-LEAH-224-1

Done.

]]> DD-LEAH-224-1: comment by Vinayakam Mani "Done." Mon, 24 Feb 2025 11:01:07 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-224-1/#c21558 https://devapps.diality.us/cru/DD-LEAH-224-1/#c21558 Vinayakam Mani replied to Sean Nash in DD-LEAH-224-1

Done.

]]> DD-LEAH-224-1: comment by Vinayakam Mani "Done." Mon, 24 Feb 2025 10:40:46 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-224-1/#c21557 https://devapps.diality.us/cru/DD-LEAH-224-1/#c21557 Vinayakam Mani replied to Sean Nash in DD-LEAH-224-1

Done.

]]> DD-LEAH-224-1: comment by Vinayakam Mani "Done." Mon, 24 Feb 2025 10:40:39 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-224-1/#c21556 https://devapps.diality.us/cru/DD-LEAH-224-1/#c21556 Vinayakam Mani replied to Sean Nash in DD-LEAH-224-1

Done.

]]> DD-LEAH-224-1: comment by Vinayakam Mani "Done." Mon, 24 Feb 2025 10:40:30 -0800 Vinayakam Mani https://devapps.diality.us/cru/DD-LEAH-224-1/#c21555 https://devapps.diality.us/cru/DD-LEAH-224-1/#c21555 Vinayakam Mani replied to Sean Nash in DD-LEAH-224-1

Done.

]]> DD-LEAH-224-1: comment by Sean Nash "Still needed?" Mon, 24 Feb 2025 09:37:31 -0800 Sean Nash https://devapps.diality.us/cru/DD-LEAH-224-1/#c21550 https://devapps.diality.us/cru/DD-LEAH-224-1/#c21550 Sean Nash commented on DD-LEAH-224-1

Still needed?

]]> DD-LEAH-224-1: comment by Sean Nash "Remove these blank lines." Mon, 24 Feb 2025 09:35:40 -0800 Sean Nash https://devapps.diality.us/cru/DD-LEAH-224-1/#c21549 https://devapps.diality.us/cru/DD-LEAH-224-1/#c21549 Sean Nash commented on DD-LEAH-224-1

Remove these blank lines.

]]>