I prefer you create a local BOOL result so you can have a simpler return statement.

Should go to your new complete state here.

The number looks incorrect. This was an issue in the staging branch, which is fixed now. Can you please pull latest staging and update the values of your enums?

· /MsgDefs.h

(-2, +3)

| History

| Source

| Diff

]]> Tue, 05 May 2026 06:58:57 -0700 Dara Navaei https://devapps.diality.us/changelog/leahi-common?cs=4b4bd3eb49d8cb9a98b2020b4342504040eeb2ee https://devapps.diality.us/changelog/leahi-common?cs=4b4bd3eb49d8cb9a98b2020b4342504040eeb2ee Dara Navaei committed 4b4bd3e on branch LDT-3259-software-update---td-firmware, staging in leahi-common Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /MsgDefs.h

(-1, +1)

| History

| Source

| Diff

]]> Mon, 04 May 2026 16:30:01 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c28818 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2/#c28818 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1886-2

check alarm status instead of switch state.

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

I guess, all these checks should be moved to FillEndState.

after one state of BC switching completed. update the next comment as well.

Uncommented

Should we add a TODO to remove this one as well?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

Please update the function name : testDDFloaterLevelStateOverride

]]> Mon, 04 May 2026 00:00:14 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28807 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2240-1/#c28807 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-2240-1

Remove extra blank line.

Why is this service prefixed with "Tx"?
Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

DrySelfTests unit.

DrySelfTests unit initialized.

Remove extra blank line.

.. handles dry self-tests execution for pre-treatment and treatment modes.

Should be in "", not <>. And should be placed alphabetically down before TxParams.h.

Calling signal function here seems circular (that's how we got here in the first place).
Shouldn't we set state to the install state here instead?

Put before TxParams.

I think Praneeth created a function for this. Make sure they're identical.

Is the folder name necessary?

Remove unnecessary spaces before =