Fisheye on dd-firmware/

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3372: code review comments

Michael Garthwaite — Fri, 06 Mar 2026 14:29:04 -0800

Michael Garthwaite committed a5d119a on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more in dd-firmware

LDT-3372: code review comments

· /firmware/App/Monitors/Conductivity.c

(-1, +0)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3372: code review comments

Michael Garthwaite — Fri, 06 Mar 2026 14:24:37 -0800

Michael Garthwaite committed e7d048b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more in dd-firmware

LDT-3372: code review comments

· /firmware/App/Drivers/ConductivityTeensy.c

(-2, +0)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3372: code review comments

Michael Garthwaite — Fri, 06 Mar 2026 14:22:34 -0800

Michael Garthwaite committed f87a631 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more in dd-firmware

LDT-3372: code review comments

· /firmware/App/Monitors/Conductivity.c

(-1, +1)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3372: code review comments

Michael Garthwaite — Fri, 06 Mar 2026 14:18:32 -0800

Michael Garthwaite committed b48cd32 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more in dd-firmware

LDT-3372: code review comments

· /firmware/App/Monitors/Conductivity.h

(-1, +0)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): WIP on develop...

Michael Garthwaite — Fri, 06 Mar 2026 12:30:52 -0800

Michael Garthwaite committed 54c171b on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more in dd-firmware

WIP on develop

LDT-3372: fixed error on release builds

· /firmware/App/Monitors/Conductivity.c

(-1, +1)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Merge branch 'staging' into LDT-3372-v1-conductivity-fixes

Michael Garthwaite — Fri, 06 Mar 2026 12:18:15 -0800

Michael Garthwaite committed 3fbfacb on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more in dd-firmware

Merge branch 'staging' into LDT-3372-v1-conductivity-fixes

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3372: code review comments.

Michael Garthwaite — Fri, 06 Mar 2026 12:14:38 -0800

Michael Garthwaite committed 72de2cf on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more in dd-firmware

LDT-3372: code review comments.

· /firmware/App/Drivers/ConductivityTeensy.c	(-22, +19)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/ConductivityTeensy.h	(-18, +1)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-6, +23)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.h	(-3, +1)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Temperature.c	(-3, +13)	\| History	\| Source	\| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Thu, 05 Mar 2026 17:12:40 -0800

Dara Navaei committed 24303ae on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 36 more in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Thu, 05 Mar 2026 17:12:21 -0800

Dara Navaei committed b604744 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 36 more in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Monitors/BloodLeak.c

(-2, +2)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Merged LDT-3605

Dara Navaei — Thu, 05 Mar 2026 17:10:03 -0800

Dara Navaei committed b6e4ccd on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 36 more in dd-firmware

Merged LDT-3605

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3605 added code in the blood leak driver to reset its state machine once the hardware configuration has changed

Dara Navaei — Thu, 05 Mar 2026 15:07:36 -0800

Dara Navaei committed 1e12823 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 37 more in dd-firmware

LDT-3605 added code in the blood leak driver to reset its state machine once the hardware configuration has changed

· /firmware/App/Monitors/BloodLeak.c

(-3, +16)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Merge branch 'staging' into LDT-3372-v1-conductivity-fixes

Michael Garthwaite — Thu, 05 Mar 2026 09:40:22 -0800

Michael Garthwaite committed 8e63185 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more in dd-firmware

Merge branch 'staging' into LDT-3372-v1-conductivity-fixes

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3372: fixes set conductivity model per code review

Michael Garthwaite — Thu, 05 Mar 2026 09:39:14 -0800

Michael Garthwaite committed 3fa7efb on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more in dd-firmware

LDT-3372: fixes set conductivity model per code review

· /firmware/App/Drivers/ConductivityTeensy.c

(-2, +2)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3372: removed functions per code review.

Michael Garthwaite — Wed, 04 Mar 2026 11:23:47 -0800

Michael Garthwaite committed d9c77cf on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more in dd-firmware

LDT-3372: removed functions per code review.

· /firmware/App/Drivers/ConductivityTeensy.c

(-52, +0)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Wed, 04 Mar 2026 09:38:36 -0800

Dara Navaei committed d52c0d9 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 38 more in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 04 Mar 2026 09:38:18 -0800

Dara Navaei committed b37e7ab on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 38 more in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Heaters.c

(-1, +1)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3597 merge into staging

Vinayakam Mani — Wed, 04 Mar 2026 09:36:08 -0800

Vinayakam Mani committed 2be6edc on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 38 more in dd-firmware

LDT-3597 merge into staging

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3597 heater update

Vinayakam Mani — Tue, 03 Mar 2026 19:25:45 -0800

Vinayakam Mani committed 5abf7ed on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 39 more in dd-firmware

LDT-3597 heater update

· /firmware/App/Controllers/Heaters.c

(-0, +3)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Tue, 03 Mar 2026 15:33:08 -0800

Dara Navaei committed 4e6f674 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 39 more in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 03 Mar 2026 15:32:47 -0800

Dara Navaei committed 4ea0591 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 39 more in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +1)	\| History	\| Source	\| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Merge LDT-3219-dd-d3-opens-as-soon-as-dd-is-po into staging

Vendor - TEL - Sameer Poyil — Tue, 03 Mar 2026 15:30:39 -0800

Vendor - TEL - Sameer Poyil committed 39fd923 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 39 more in dd-firmware

Merge LDT-3219-dd-d3-opens-as-soon-as-dd-is-po into staging

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Merge branch 'staging' of bitbucket.org:diality-cloud/dd-firmware into staging

Vendor - TEL - Sameer Poyil — Tue, 03 Mar 2026 15:29:57 -0800

Vendor - TEL - Sameer Poyil committed e3f44af on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 39 more in dd-firmware

Merge branch 'staging' of bitbucket.org:diality-cloud/dd-firmware into staging

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Dara Navaei — Tue, 03 Mar 2026 14:16:54 -0800

Dara Navaei committed b115c2f on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 39 more in dd-firmware

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

· /firmware/App/DDCommon.h

(-1, +1)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 03 Mar 2026 14:16:08 -0800

Dara Navaei committed adb60c3 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 39 more in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Monitors/WaterQualityMonitor.c

(-2, +2)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): Merge branch 'LDT-3514-dialin-config' into staging

Michael Garthwaite — Tue, 03 Mar 2026 14:13:15 -0800

Michael Garthwaite committed 8763749 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 39 more in dd-firmware

Merge branch 'LDT-3514-dialin-config' into staging

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3514: wrapped ALARM_ID_FP_POWER_BUDGET_OUT_OF_RANGE around test config TEST_CONFIG_FP_DISABLE_RO_CURRENT_ALARM.

Michael Garthwaite — Mon, 02 Mar 2026 13:13:27 -0800

Michael Garthwaite committed 77d2a00 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 40 more in dd-firmware

LDT-3514: wrapped ALARM_ID_FP_POWER_BUDGET_OUT_OF_RANGE around test config TEST_CONFIG_FP_DISABLE_RO_CURRENT_ALARM.

· /firmware/App/Monitors/WaterQualityMonitor.c

(-1, +5)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3372: code review comments.

Michael Garthwaite — Mon, 02 Mar 2026 11:40:20 -0800

Michael Garthwaite committed 3b97a99 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more in dd-firmware

LDT-3372: code review comments.

· /firmware/App/Drivers/ConductivityTeensy.c

(-13, +10)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3372: fixes to conductivity calculation.

Michael Garthwaite — Mon, 02 Mar 2026 11:15:45 -0800

Michael Garthwaite committed 37e25a9 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more in dd-firmware

LDT-3372: fixes to conductivity calculation.

· /firmware/App/Drivers/ConductivityTeensy.c

(-5, +5)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3372: improvements to teensy init sequence. Removed casting from calculations to uphold data integrity. fixed conver...

Michael Garthwaite — Thu, 26 Feb 2026 11:51:10 -0800

Michael Garthwaite committed e78ed64 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more in dd-firmware

LDT-3372: improvements to teensy init sequence. Removed casting from calculations to uphold data integrity. fixed conversion values. Removed some compiler warnings

· /firmware/App/Drivers/ConductivityTeensy.c

(-120, +21)

| History

| Source

| Diff

dd-firmware (LDT-553-water-treatment-and-degassing-baro): LDT-3219 removing D3 open in standby mode

Vendor - TEL - Sameer Poyil — Tue, 24 Feb 2026 23:32:40 -0800

Vendor - TEL - Sameer Poyil committed 77e25b8 on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 40 more in dd-firmware

LDT-3219 removing D3 open in standby mode

· /firmware/App/Modes/ModeStandby.c

(-3, +0)

| History

| Source

| Diff