Fisheye on dd-firmware/firmware/App/Controllers/PermeateTank.c https://devapps.diality.us/changelog/~br%3DLDT-3603-ability-to-set-operation-sub-mode-2/dd-firmware/firmware/App/Controllers/PermeateTank.c Recent activity in "dd-firmware" under directory /firmware/App/Controllers/PermeateTank.c LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conduc... Thu, 23 Apr 2026 14:59:17 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "instead of 0, we can use the level Enum 'LVL_ST..." Thu, 23 Apr 2026 14:56:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "lower? and change the D98 level sensor comment ..." Thu, 23 Apr 2026 14:49:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

lower? and change the D98 level sensor comment as well.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Remove empty line" Thu, 23 Apr 2026 14:47:11 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove empty line

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space before LVL_STATE_LOW" Thu, 23 Apr 2026 14:45:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space before LVL_STATE_LOW

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "space inside array index." Thu, 23 Apr 2026 14:43:35 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

space inside array index.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space inside parenthesis." Thu, 23 Apr 2026 14:41:03 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space inside parenthesis.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Change this to LEVEL_T enum." Thu, 23 Apr 2026 14:39:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Change this to LEVEL_T enum.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Is this macro still being used? if not, delete ..." Thu, 23 Apr 2026 14:38:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Is this macro still being used? if not, delete it.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: started by Dara Navaei Thu, 23 Apr 2026 07:47:26 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3978-1 ]]> LEAHI-DD-FIRMWARE-LDT-3984-1: closed by Dara Navaei Mon, 20 Apr 2026 09:51:13 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Dara Navaei Closed LEAHI-DD-FIRMWARE-LDT-3984-1 ]]> LEAHI-DD-FIRMWARE-LDT-3984-1: reviewers finished Mon, 20 Apr 2026 09:23:14 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Vinayakam Mani and Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-3984-1 LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber ]]> LEAHI-DD-FIRMWARE-LDT-3984-1: comment by Michael Garthwaite "fixed" Mon, 20 Apr 2026 06:52:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28540 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28540 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3984-1

fixed

]]> LEAHI-DD-FIRMWARE-LDT-3984-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 wi... Fri, 17 Apr 2026 18:02:29 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Sean Nash added Vendor - TEL - Jashwant Gantyada and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3984-1 LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber ]]> LEAHI-DD-FIRMWARE-LDT-3984-1: comment by Vinayakam Mani "Align the comments." Fri, 17 Apr 2026 17:17:01 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28539 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1/#c28539 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3984-1

Align the comments.

]]> LEAHI-DD-FIRMWARE-LDT-3984-1: started by Dara Navaei Fri, 17 Apr 2026 17:13:47 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3984-1 ]]> LEAHI-DD-FIRMWARE-LDT-3218-4: closed by Michael Garthwaite Thu, 16 Apr 2026 08:15:43 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-3218-4 ]]> LEAHI-DD-FIRMWARE-LDT-3218-4: reviewers finished Wed, 15 Apr 2026 17:31:50 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3218-4 LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed) ]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "by the end of S27 we will know if we need to ke..." Wed, 15 Apr 2026 16:12:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28431 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28431 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3218-4

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Vinayakam Mani "If this is the core change, can we introduce th..." Wed, 15 Apr 2026 15:34:19 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28426 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28426 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3218-4

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "nope. removed." Wed, 15 Apr 2026 09:52:57 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28375 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28375 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

nope. removed.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "fixed" Wed, 15 Apr 2026 09:52:50 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28374 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28374 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

fixed

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "fixed" Wed, 15 Apr 2026 09:52:35 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28373 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28373 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

fixed

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "fixed" Wed, 15 Apr 2026 09:52:20 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28372 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28372 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

fixed

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "fixed" Wed, 15 Apr 2026 09:52:04 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28371 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28371 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

fixed

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Add blank line before return." Tue, 14 Apr 2026 14:08:22 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28328 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28328 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Add blank line before return.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Add blank line after declarations." Tue, 14 Apr 2026 14:07:02 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28327 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28327 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Add blank line after declarations.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Why U32? Why not RECOVER_STATE_T?" Tue, 14 Apr 2026 14:05:42 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28326 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28326 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Why U32? Why not RECOVER_STATE_T?

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Lower case x" Tue, 14 Apr 2026 14:04:13 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28325 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28325 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Lower case x

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Sean Nash "Is blood flow in need of a PID controller too?" Tue, 14 Apr 2026 14:02:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28324 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28324 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3218-4

Is blood flow in need of a PID controller too?

]]>