Fisheye on td-firmware/firmware/App/Controllers/AirTrap.h https://devapps.diality.us/changelog/~br%3DLDT-3722-non-volatile-memory/td-firmware/firmware/App/Controllers/AirTrap.h Recent activity in "td-firmware" under directory /firmware/App/Controllers/AirTrap.h LEAHI-TD-FIRMWARE-LDT-1903-8: closed by Vendor - TEL - Sameer Poyil Wed, 04 Mar 2026 20:22:26 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 Vendor - TEL - Sameer Poyil Closed LEAHI-TD-FIRMWARE-LDT-1903-8 ]]> td-firmware (LDT-1415-pressures-monitoring-td-updates): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 02 Mar 2026 21:01:14 -0800 Dara Navaei https://devapps.diality.us/changelog/td-firmware?cs=c049177f4d18a4740a357941b48a833d7115b581 https://devapps.diality.us/changelog/td-firmware?cs=c049177f4d18a4740a357941b48a833d7115b581 Dara Navaei committed c049177 on branch LDT-1394-blood-flow-rate-h4-rotor-count, LDT-1415-pressures-monitoring-td-baro and 19 more in td-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/AirPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/AirTrap.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/AirTrap.h (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/GLXferPump.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/GLXferPump.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/FpgaTD.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/FpgaTD.h (-2, +2) | History | Source | Diff
]]> LEAHI-TD-FIRMWARE-LDT-1903-8: reviewers resumed Mon, 02 Mar 2026 20:46:01 -0800 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 Sean Nash resumed reviewing LEAHI-TD-FIRMWARE-LDT-1903-8 LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation ]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "fixed in latest code" Mon, 02 Mar 2026 11:54:51 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27695 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27695 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

fixed in latest code

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "implemented" Mon, 02 Mar 2026 11:53:34 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27694 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27694 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

implemented

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "fixed" Mon, 02 Mar 2026 11:53:26 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27693 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27693 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

fixed

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "I think this would be a TD s/w fault (alarm alr..." Mon, 02 Mar 2026 09:52:52 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27674 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27674 Sean Nash replied to Vendor - TEL - Sameer Poyil in LEAHI-TD-FIRMWARE-LDT-1903-8

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "This structure doesn't seem necessary - it's ju..." Mon, 02 Mar 2026 09:50:52 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27673 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27673 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "Fixed" Mon, 02 Mar 2026 07:42:05 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27671 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27671 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

Fixed

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "removed from here" Mon, 02 Mar 2026 07:37:03 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27670 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27670 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

removed from here

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "fixed" Mon, 02 Mar 2026 07:36:38 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27669 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27669 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

fixed

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "We need new alarm . That should be included in ..." Fri, 27 Feb 2026 14:54:56 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27665 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27665 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Add blank line after declarations." Fri, 27 Feb 2026 13:32:31 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27664 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27664 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Add blank line after declarations.

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Alarm should be handled inside of setAirPumpSta..." Fri, 27 Feb 2026 13:32:13 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27663 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27663 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Alarm should be handled inside of setAirPumpState().

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Alarm should be handled inside of setAirPumpSta..." Fri, 27 Feb 2026 13:31:55 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27662 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27662 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Alarm should be handled inside of setAirPumpState().

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Alarm should be handled inside of setAirPumpSta..." Fri, 27 Feb 2026 13:31:38 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27661 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27661 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Alarm should be handled inside of setAirPumpState().

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Alarm should be handled inside of setAirPumpSta..." Fri, 27 Feb 2026 13:31:18 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27660 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27660 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Alarm should be handled inside of setAirPumpState().

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Alarm should be handled inside of setAirPumpSta..." Fri, 27 Feb 2026 13:31:01 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27659 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27659 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Alarm should be handled inside of setAirPumpState().

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Alarm should be handled inside of setAirPumpSta..." Fri, 27 Feb 2026 13:30:45 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27658 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27658 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Alarm should be handled inside of setAirPumpState().

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Add blank line after declarations." Fri, 27 Feb 2026 13:30:23 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27657 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27657 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Add blank line after declarations.

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "I think alarm should be handled inside the setA..." Fri, 27 Feb 2026 13:29:59 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27656 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27656 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

I think alarm should be handled inside the setAirPumpState() function.

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Should we have alarm here?" Fri, 27 Feb 2026 13:29:35 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27655 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27655 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Should we have alarm here?

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "duty misspelled." Fri, 27 Feb 2026 13:28:04 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27654 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27654 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

duty misspelled.

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Can we remove inclusion of fpga here? It shoul..." Fri, 27 Feb 2026 13:26:07 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27653 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27653 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Can we remove inclusion of fpga here? It shouldn't be needed.

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: reviewers resumed Fri, 27 Feb 2026 10:04:35 -0800 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 Vendor - TEL - Jashwant Gantyada resumed reviewing LEAHI-TD-FIRMWARE-LDT-1903-8 LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation ]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "pushed new code" Fri, 27 Feb 2026 09:17:39 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27633 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27633 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

pushed new code

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "Fixed" Fri, 27 Feb 2026 09:14:40 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27632 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27632 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

Fixed

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "fixed it in commit ID 71a6797" Fri, 27 Feb 2026 09:14:28 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27631 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27631 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

fixed it in commit ID 71a6797

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "I don't like controller bypassing driver to get..." Thu, 26 Feb 2026 22:52:07 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27589 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27589 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

I don't like controller bypassing driver to get to fpga access functions. There should be a get function in the driver that we can call here instead.

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Add blank line after declarations." Thu, 26 Feb 2026 22:51:01 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27588 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27588 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Add blank line after declarations.

]]>