Fisheye on dd-firmware/firmware/App

Fisheye on dd-firmware/firmware/App https://devapps.diality.us/changelog/~br%3DLDT-3735-non-volatile-memory/dd-firmware/firmware/App Recent activity in "dd-firmware" under directory /firmware/App LEAHI-DD-FIRMWARE-LDT-5157-1: started by Dara Navaei Wed, 15 Jul 2026 09:48:45 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5157-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-5157-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-5157-1 ]]> dd-firmware (LDT-3735-non-volatile-memory): LDT-3735: Addressed review comments Wed, 15 Jul 2026 09:33:50 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/changelog/dd-firmware?cs=be1ff666dbd2ff03342c22c8e50b21d0f9b988a9 https://devapps.diality.us/changelog/dd-firmware?cs=be1ff666dbd2ff03342c22c8e50b21d0f9b988a9 Vendor - TEL - Arpita Srivastava committed be1ff66 on branch LDT-3735-non-volatile-memory, LDT-5157-conductivity-sensor-calibration in dd-firmware LDT-3735: Addressed review comments

· /firmware/App/Services/Messaging.c (-15, +15) | History | Source | Diff

· /firmware/App/Services/NVMessagingDD.c (-83, +116) | History | Source | Diff

· /firmware/App/Services/NVMessagingDD.h (-17, +15) | History | Source | Diff

· /firmware/App/Services/NVRecordsDD.c (-2, +1) | History | Source | Diff

· /firmware/App/Services/NVRecordsDD.h (-1, +1) | History | Source | Diff

]]> LEAHI-DD-FIRMWARE-LDT-4733-1: closed by Michael Garthwaite Tue, 14 Jul 2026 14:58:45 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4733-1 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-4733-1 ]]> LEAHI-DD-FIRMWARE-LDT-4734-1: closed by Michael Garthwaite Tue, 14 Jul 2026 14:58:38 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4734-1 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-4734-1 ]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Remove blank line." Tue, 14 Jul 2026 14:43:08 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30477 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30477 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "If this is a override message handler, it is no..." Tue, 14 Jul 2026 14:41:49 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30476 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30476 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Can we have a payload structure (packed to 1 by..." Tue, 14 Jul 2026 14:36:09 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30475 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30475 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line between declarations and rest of..." Tue, 14 Jul 2026 14:31:17 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30473 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30473 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line between declarations and rest of function code (throughout this unit)

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line before return statement. ( thro..." Tue, 14 Jul 2026 14:31:30 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30474 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30474 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line before return statement. ( throughout this unit )

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line before return statement." Tue, 14 Jul 2026 14:31:08 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30472 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30472 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line before return statement.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line between declarations and rest of..." Tue, 14 Jul 2026 14:30:54 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30471 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30471 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line between declarations and rest of function code.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line between declarations and rest of..." Tue, 14 Jul 2026 14:30:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30470 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30470 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line between declarations and rest of function code.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line between declarations and rest of..." Tue, 14 Jul 2026 14:30:32 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30469 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30469 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line between declarations and rest of function code.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line between declarations and rest of..." Tue, 14 Jul 2026 14:30:23 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30468 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30468 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line between declarations and rest of function code.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line before return statement." Tue, 14 Jul 2026 14:29:54 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30467 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30467 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line before return statement.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line between declarations and rest of..." Tue, 14 Jul 2026 14:29:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30466 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30466 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line between declarations and rest of function code.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line before return statement." Tue, 14 Jul 2026 14:29:17 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30465 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30465 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line before return statement.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line before return statement." Tue, 14 Jul 2026 14:29:03 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30464 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30464 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line before return statement.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add blank line before return statement." Tue, 14 Jul 2026 14:28:46 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30463 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30463 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add blank line before return statement.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Indent too deep here." Tue, 14 Jul 2026 14:28:05 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30462 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30462 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Indent too deep here.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Remove blank line." Tue, 14 Jul 2026 14:27:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30461 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30461 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Indent looks too deep here." Tue, 14 Jul 2026 14:26:47 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30460 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30460 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Indent looks too deep here.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "1 blank line here is sufficient." Tue, 14 Jul 2026 14:25:46 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30459 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30459 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

1 blank line here is sufficient.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Remove blank line." Tue, 14 Jul 2026 13:30:09 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30458 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30458 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Remove blank line." Tue, 14 Jul 2026 13:29:27 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30457 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30457 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Remove blank line." Tue, 14 Jul 2026 13:29:07 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30456 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30456 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Add a blank line after private defs banner." Tue, 14 Jul 2026 13:28:07 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30455 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30455 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Add a blank line after private defs banner.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Remove extra blank line." Tue, 14 Jul 2026 13:24:48 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30454 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30454 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Remove extra blank line.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Remove blank line." Tue, 14 Jul 2026 13:24:02 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30453 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30453 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Remove blank line.

]]> LEAHI-DD-FIRMWARE-LDT-3735-1: comment by Sean Nash "Just 1 blank line here is sufficient." Tue, 14 Jul 2026 13:22:28 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30452 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3735-1/#c30452 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3735-1

Just 1 blank line here is sufficient.

]]>