instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

lower? and change the D98 level sensor comment as well.

Remove empty line

Space before LVL_STATE_LOW

space inside array index.

Space inside parenthesis.

Change this to LEVEL_T enum.

Is this macro still being used? if not, delete it.

· /firmware/App/Drivers/NVDriver.c	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Services/NVMgmtDD.c	(-6, +3)	| History	| Source	| Diff
· /firmware/App/Services/NVMsgQ.c	(-229, +81)	| History	| Source	| Diff
· /firmware/App/Services/NVMsgQ.h	(-6, +3)	| History	| Source	| Diff
· /firmware/App/Services/NVRecordsDD.c	(-84, +58)	| History	| Source	| Diff
· /firmware/App/Services/NVRecordsDD.h	(-31, +1)	| History	| Source	| Diff

]]> Wed, 22 Apr 2026 14:11:04 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3980-1 LEAHI-DD-FIRMWARE-LDT-3980_Dialysate Composition - FW Implementation (Dry Bicarbonate) - 1/1: ]]> Wed, 22 Apr 2026 11:40:13 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3904-1 ]]> Wed, 22 Apr 2026 11:39:46 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 Michael Garthwaite finished reviewing LEAHI-DD-FIRMWARE-LDT-3904-1 LEAHI-DD-FIRMWARE-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes ]]> Wed, 22 Apr 2026 10:41:20 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3749-2 ]]> Wed, 22 Apr 2026 09:55:43 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3749-2 LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem ]]> Tue, 21 Apr 2026 15:32:43 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/changelog/dd-firmware?cs=b878faee61a0800b767d053ab3f65afb3790dacb https://devapps.diality.us/changelog/dd-firmware?cs=b878faee61a0800b767d053ab3f65afb3790dacb Vendor - TEL - Arpita Srivastava committed b878fae on branch LDT-3735-non-volatile-memory in dd-firmware LDT-3735: receive in progress

· /firmware/App/Drivers/NVDriver.h	(-6, +3)	| History	| Source	| Diff
· /firmware/App/Services/NVMgmtDD.c	(-8, +8)	| History	| Source	| Diff
· /firmware/App/Services/NVMsgQ.c	(-92, +169)	| History	| Source	| Diff
· /firmware/App/Services/NVMsgQ.h	(-3, +5)	| History	| Source	| Diff
· /firmware/App/Services/NVRecordsDD.c	(-13, +13)	| History	| Source	| Diff
· /firmware/App/Services/NVRecordsDD.h	(-6, +3)	| History	| Source	| Diff

]]> Tue, 21 Apr 2026 14:24:50 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3904-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3904-1 LEAHI-DD-FIRMWARE-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes ]]> Tue, 21 Apr 2026 14:17:37 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3749-2 LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem ]]> Tue, 21 Apr 2026 13:01:19 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28564 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3980-1/#c28564 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3980-1

control interval is different. Control interval must be separated else we don't get finer control on bicarb conductivity. also the dead band is different. need to figure out whether we can combine or not

This code looks very similar to bicarb code above. Do we really need separate handling?

Updated

Remove extra blank line.

Add unit of measure to definition name (e.g. _PSI). Should be done for all definitions w/ a unit of measure to prevent unit errors.

· /firmware/App/Drivers/NVDriver.c	(-6, +63)	| History	| Source	| Diff
· /firmware/App/Drivers/NVDriver.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Services/NVMgmtDD.c	(-8, +8)	| History	| Source	| Diff
· /firmware/App/Services/NVMsgQ.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/NVRecordsDD.c	(-2, +3)	| History	| Source	| Diff
· /firmware/App/Services/NVRecordsDD.h	(-1, +1)	| History	| Source	| Diff

]]> Mon, 20 Apr 2026 09:51:13 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Dara Navaei Closed LEAHI-DD-FIRMWARE-LDT-3984-1 ]]> Mon, 20 Apr 2026 09:23:14 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3984-1 Vinayakam Mani and Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-3984-1 LEAHI-DD-FIRMWARE-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber ]]> Mon, 20 Apr 2026 08:17:53 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-2004-9 ]]>