create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here

comment still needed?

Keep 2 blank lines above the banner below.

Is this still needed?

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

Keep 2 blank lines above the test support functions banner.

Not sure why you are making changes to this function.
This function handles message from UI to pause or resume ultrafiltration.
This is not a treatment parameter edit message, so I don't think it's part of your assignment.

No longer needed?

· /firmware/App/Modes/StateTxDialysis.c	(-6, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.h	(-1, +0)	| History	| Source	| Diff

]]> Tue, 28 Apr 2026 20:33:51 -0700 Vendor - TEL - Vijay Pamula https://devapps.diality.us/changelog/td-firmware?cs=421336466eff4ba9fef0ca5416043e5d83c63841 https://devapps.diality.us/changelog/td-firmware?cs=421336466eff4ba9fef0ca5416043e5d83c63841 Vendor - TEL - Vijay Pamula committed 4213364 on branch LDT-3970-edit-treatment-parameters-during-treatment in td-firmware LDT-3970: Adressed code review comments

· /firmware/App/Modes/ModeTreatment.c	(-225, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.h	(-3, +0)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxDialysis.c	(-41, +41)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.c	(-169, +0)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.h	(-65, +0)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-0, +428)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.h	(-0, +62)	| History	| Source	| Diff

]]> Tue, 28 Apr 2026 18:13:22 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-473-3 LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation ]]> Tue, 28 Apr 2026 14:31:18 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28733 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28733 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

???

Do we need a parameter for confirmation?

It looks like you deleted it instead of fixing it.

Need to request syringe pump to start a seek before we go to seek state. It's not implemented yet, so just put a TODO comment for now.

Need to check heparin bolus volume > 0 too.

Don't we need to check this too still?

Do we need to reset authStartTime here before we go to next state?

Put positive case first ( TRUE == ...), then alarm and reject cases.

No occlusion sensor in Leahi. Delete variable and references to it.

We should now send the scanned text to the UI s/w for authentication before we go to next state where we wait for UI response.

Remove extra l at end of flag name (mis-spelled). And why are we sending this flag with scan event? Seems like the Received flag is what you want here.

The barcode reader is under TD f/w control via the FPGA (not implemented yet). So asking UI s/w to do a scan doesn't make sense.