What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert to L/hr every time it needs to send UI a message. Either way works for me.

Changed to U32

we are sending a message ack as response in the handler of this message request

Other existing set functions in TD is using UF in liter and rate in L/hr

Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When sending UF rate to UI, we would convert back to L/hr first, but everywhere else we would work with mL/min.

Remove extra blank line.

Remove extra space before function name.

This is not a Dialin message, so move up above all of these "test" functions.

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate doxygen group.

Do we have a return confirmation that the command is accepted by DD?

Is the UF rate unit in ml/min (instead of hr.)?

Are we assuming the sub mode return is pre-gen sub mode always?

create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here

comment still needed?

Keep 2 blank lines above the banner below.

Is this still needed?

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

Keep 2 blank lines above the test support functions banner.

Not sure why you are making changes to this function.
This function handles message from UI to pause or resume ultrafiltration.
This is not a treatment parameter edit message, so I don't think it's part of your assignment.

No longer needed?

· /firmware/App/Modes/StateTxDialysis.c	(-6, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.h	(-1, +0)	| History	| Source	| Diff

]]> Tue, 28 Apr 2026 20:33:51 -0700 Vendor - TEL - Vijay Pamula https://devapps.diality.us/changelog/td-firmware?cs=421336466eff4ba9fef0ca5416043e5d83c63841 https://devapps.diality.us/changelog/td-firmware?cs=421336466eff4ba9fef0ca5416043e5d83c63841 Vendor - TEL - Vijay Pamula committed 4213364 on branch LDT-3970-edit-treatment-parameters-during-treatment in td-firmware LDT-3970: Adressed code review comments

· /firmware/App/Modes/ModeTreatment.c	(-225, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.h	(-3, +0)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxDialysis.c	(-41, +41)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.c	(-169, +0)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.h	(-65, +0)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-0, +428)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.h	(-0, +62)	| History	| Source	| Diff

]]> Tue, 28 Apr 2026 18:13:22 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-473-3 LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation ]]>