Done.

I think we also need this to be uncommented, as we were running into an alarm because of this.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

Done.

Done.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

Can we restore the real code here yet? Ask Dara.

Why comment this out? fault ID should probably be more specific (i.e. which message payload length is invalid?)

Why isn't this TRUE == ?

· /PIDControllers.h

(-0, +3)

| History

| Source

| Diff

]]> Thu, 28 May 2026 13:37:36 -0700 Sean Nash https://devapps.diality.us/changelog/leahi-fwcommon?cs=a0f051c3f707ecbc537bdc85c40f0df346066652 https://devapps.diality.us/changelog/leahi-fwcommon?cs=a0f051c3f707ecbc537bdc85c40f0df346066652 Sean Nash committed a0f051c on branch LDT-3975-water-treatment-and-degassing-- in leahi-fwcommon LDT-3975: refactored PID controller.

· /PIDControllers.c	(-59, +40)	| History	| Source	| Diff
· /PIDControllers.h	(-2, +1)	| History	| Source	| Diff

]]> Wed, 27 May 2026 16:28:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4000-1/#c29453 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4000-1/#c29453 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4000-1

Fix comment.

· /CommBuffers.h	(-2, +2)	| History	| Source	| Diff
· /Integrity.c	(-0, +16)	| History	| Source	| Diff
· /Integrity.h	(-0, +16)	| History	| Source	| Diff
· /SystemComm.c	(-2, +2)	| History	| Source	| Diff

]]> Wed, 27 May 2026 15:36:32 -0700 Dara Navaei https://devapps.diality.us/changelog/leahi-fwcommon?cs=8ac30e74c42d94da54f6f2f2bc9b3446d60dcc1e https://devapps.diality.us/changelog/leahi-fwcommon?cs=8ac30e74c42d94da54f6f2f2bc9b3446d60dcc1e Dara Navaei committed 8ac30e7 on branch LDT-3958-dialysate-temperature---fw-impl, LDT-3975-water-treatment-and-degassing-- and 3 more in leahi-fwcommon Merged LDT-3259

]]> Wed, 27 May 2026 15:34:40 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3259-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3259-1 Vendor - TEL - Jashwant Gantyada and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-3259-1 LEAHI-TD-FIRMWARE-LDT-3259_Software Update - TD ]]> Wed, 27 May 2026 14:56:28 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3259-1/#c29438 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3259-1/#c29438 Dara Navaei replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-3259-1

Done

· /CommBuffers.h

(-2, +2)

| History

| Source

| Diff

]]> Wed, 27 May 2026 13:47:50 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3259-1/#c29411 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3259-1/#c29411 Dara Navaei replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-3259-1

Done

This file was updated automatically using HALCoGen.

Missing other test functions in the substitution pump (publish, target speed.)?

update original author name and date.

update all test functions header and descriptions, Input, outputs and param sections.

Are we missing the publish function for the substitution pump?

are we checking any range here? if not, remove the above comment.