· /leahi_dialin/dd/modules/levels.py

(-1, +1)

| History

| Source

| Diff

]]> Thu, 30 Apr 2026 14:32:36 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4000-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4000-1 Dara Navaei started review LEAHI-DIALIN-LDT-4000-1 ]]> Thu, 30 Apr 2026 14:23:40 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1 Vendor - TEL - Sameer Poyil Closed LEAHI-DIALIN-LDT-3984-1 ]]> Thu, 30 Apr 2026 14:14:36 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4188-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4188-1 Michael Garthwaite , Vinayakam Mani and Sean Nash finished reviewing LEAHI-DIALIN-LDT-4188-1 LEAHI-DIALIN-LDT-4188_SW/FW integration to run a Treatment from UI ]]> Thu, 30 Apr 2026 11:46:39 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/leahi-dialin?cs=97a6c2e0e7d391043007600c73d67701a09aa7ee https://devapps.diality.us/changelog/leahi-dialin?cs=97a6c2e0e7d391043007600c73d67701a09aa7ee Vendor - TEL - Sameer Poyil committed 97a6c2e on branch LDT-3984-unit-test-failure-fix, LDT-4000-hdf-fw-implementation-1-4 and 3 more in leahi-dialin Merge branch LDT-3984-dd-sw-d46-reads-0-with-and-with into staging

]]> Thu, 30 Apr 2026 11:45:33 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/leahi-dialin?cs=71f2092930ad621e8a738de12faf806e8c46b1b9 https://devapps.diality.us/changelog/leahi-dialin?cs=71f2092930ad621e8a738de12faf806e8c46b1b9 Vendor - TEL - Sameer Poyil committed 71f2092 on branch LDT-3984-dd-sw-d46-reads-0-with-and-with, LDT-3984-unit-test-failure-fix and 4 more in leahi-dialin Merge branch staging into LDT-3984-dd-sw-d46-reads-0-with-and-with

· /leahi_dialin/common/dd_defs.py

(-2, +2)

| History

| Source

| Diff

]]> Thu, 30 Apr 2026 09:30:53 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4188-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4188-1 Dara Navaei started review LEAHI-DIALIN-LDT-4188-1 ]]> Wed, 29 Apr 2026 12:05:18 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/leahi-dialin?cs=b0929a0985784c80e2d184413995a87e6aa23d4b https://devapps.diality.us/changelog/leahi-dialin?cs=b0929a0985784c80e2d184413995a87e6aa23d4b Vendor - TEL - Sameer Poyil committed b0929a0 on branch LDT-3984-dd-sw-d46-reads-0-with-and-with, LDT-3984-unit-test-failure-fix and 4 more in leahi-dialin LDT-3984 addressed review comments

· /leahi_dialin/fp/modules/levels.py

(-1, +1)

| History

| Source

| Diff

]]> Tue, 28 Apr 2026 09:17:20 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1/#c28712 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1/#c28712 Zoltan Miskolci commented on LEAHI-DIALIN-LDT-3984-1

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

Why increment the number when you didn't add a new sensor?

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

LEVEL_OFFSET?

· /leahi_dialin/common/dd_defs.py	(-5, +5)	| History	| Source	| Diff
· /leahi_dialin/common/fp_defs.py	(-1, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/levels.py	(-3, +2)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/levels.py	(-1, +3)	| History	| Source	| Diff

]]> Mon, 27 Apr 2026 13:08:16 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4213-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4213-1 Dara Navaei started review LEAHI-DIALIN-LDT-4213-1 ]]> Sun, 26 Apr 2026 14:46:25 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3218-1/#c28685 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3218-1/#c28685 Sean Nash commented on LEAHI-DIALIN-LDT-3218-1

Should this be an enumeration somewhere?

· /leahi_dialin/common/msg_ids.py	(-1, +2)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/levels.py	(-0, +27)	| History	| Source	| Diff
· /leahi_dialin/fp/modules/levels.py	(-3, +5)	| History	| Source	| Diff

]]> Fri, 24 Apr 2026 10:40:01 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3352-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3352-1 ]]> Thu, 23 Apr 2026 11:45:58 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=a778c5e34188d52d265ef992106bc410ad8eb845 https://devapps.diality.us/changelog/leahi-dialin?cs=a778c5e34188d52d265ef992106bc410ad8eb845 Zoltan Miskolci committed a778c5e on branch LDT-3505-heparin-td-04-dev-feature-implemenation, LDT-3984-dd-sw-d46-reads-0-with-and-with and 8 more in leahi-dialin Merge branch 'LDT-3352-dd---revisit-d3-level-control-l' into staging

]]> Thu, 23 Apr 2026 11:08:50 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4161-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-4161-1 Dara Navaei started review LEAHI-DIALIN-LDT-4161-1 ]]> Thu, 23 Apr 2026 08:02:29 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3984-1 Dara Navaei started review LEAHI-DIALIN-LDT-3984-1 ]]> Thu, 23 Apr 2026 08:00:45 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/leahi-dialin?cs=23ad7f4e46c52fcc77452ca6cfa171305f01cfcc https://devapps.diality.us/changelog/leahi-dialin?cs=23ad7f4e46c52fcc77452ca6cfa171305f01cfcc Vendor - TEL - Sameer Poyil committed 23ad7f4 on branch LDT-3984-dd-sw-d46-reads-0-with-and-with, LDT-3984-unit-test-failure-fix and 4 more in leahi-dialin LDT-3984 aligning D46 with DD firmware

· /leahi_dialin/common/dd_defs.py	(-4, +4)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/levels.py	(-3, +3)	| History	| Source	| Diff

]]> Wed, 22 Apr 2026 11:48:54 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3352-1 Raghu Kallala and Michael Garthwaite finished reviewing LEAHI-DIALIN-LDT-3352-1 LEAHI-DIALIN-LDT-3352_DD - revisit D3 level control logic ]]> Fri, 17 Apr 2026 15:05:55 -0700 Nicholas Ramirez https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3757-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3757-1 Nicholas Ramirez Closed LEAHI-DIALIN-LDT-3757-1 ]]>