Fisheye on dd-firmware/firmware/App/Controllers/SubstitutionPump.h

LEAHI-DD-FIRMWARE-LDT-4001-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation...

Fri, 29 May 2026 18:29:56 -0700

Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-4001-1

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:

LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Vinayakam Mani "This needs TD source update and also dialin upd..."

Vinayakam Mani — Fri, 29 May 2026 18:27:35 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4001-1

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Vinayakam Mani "Please add HDF Pump speed register and add a mo..."

Vinayakam Mani — Fri, 29 May 2026 18:24:35 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Please add HDF Pump speed register and add a monitor in the substitution pump controller to compare against the target speed and if the difference is out of range, trigger an alarm.

LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Vinayakam Mani "Substitution pump"

Vinayakam Mani — Fri, 29 May 2026 18:20:06 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Substitution pump

LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Vinayakam Mani "Missing comment."

Vinayakam Mani — Fri, 29 May 2026 14:03:18 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Missing comment.

LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Vinayakam Mani "update comment. next one as well."

Vinayakam Mani — Fri, 29 May 2026 14:01:46 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4001-1

update comment. next one as well.

LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Vinayakam Mani "blank line after the banner and maintain alphab..."

Vinayakam Mani — Fri, 29 May 2026 13:58:59 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4001-1

blank line after the banner and maintain alphabetical order of include files.

dd-firmware (LDT-4001-hdf-fw-implementation-2-4): LDT-4001: previous CR comments. updates to TD interface and messaging

Michael Garthwaite — Fri, 29 May 2026 11:57:27 -0700

Michael Garthwaite committed f90c1ee on branch LDT-4001-hdf-fw-implementation-2-4 in dd-firmware

LDT-4001: previous CR comments. updates to TD interface and messaging

· /firmware/App/Controllers/SubstitutionPump.c	(-34, +56)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SubstitutionPump.h	(-9, +8)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/TDInterface.c	(-1, +1)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-4001-1: started by Dara Navaei

Dara Navaei — Fri, 29 May 2026 11:02:02 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4001-1

dd-firmware (LDT-4001-hdf-fw-implementation-2-4): LDT-4001: fixes and merges from previous working branch.

Michael Garthwaite — Fri, 29 May 2026 10:47:42 -0700

Michael Garthwaite committed 84b30e2 on branch LDT-4001-hdf-fw-implementation-2-4 in dd-firmware

LDT-4001: fixes and merges from previous working branch.

· /firmware/App/Controllers/RinsePump.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/SubstitutionPump.h	(-0, +73)	\| History	\| Source
· /firmware/App/Monitors/Conductivity.c	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaDD.c	(-1, +3)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaDD.h	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/TDInterface.c	(-0, +2)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-4246-1: started by Dara Navaei

Dara Navaei — Wed, 06 May 2026 08:48:07 -0700

Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4246-1