LEAHI-DD-FIRMWARE-LDT-4001-1 LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:

closed on 11 Jun

Author

Moderator

Reviewers

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 18

dd-firmware 0
- Folder firmware/App 0
  - Folder Controllers 0
    - File Heaters.c 6 Remove
    - File RinsePump.c 0 Remove
    - File SubstitutionPump.c 31 Remove
    - File SubstitutionPump.h 1 Remove
  - Folder Monitors 0
    - File Conductivity.c 0 Remove
    - File Level.c 0 Remove
    - File Temperature.c 0 Remove
  - Folder Services 0
    - File AlarmMgmtSWFaults.h 0 Remove
    - File FpgaDD.c 6 Remove
    - File FpgaDD.h 0 Remove
    - File Messaging.c 4 Remove
    - File TDInterface.c 5 Remove
  - Folder Tasks 0
    - File TaskPriority.c 0 Remove
leahi-common 0
- File AlarmDefs.h 0 Remove
- File MsgDefs.h 2 Remove
leahi-fwcommon 0
- File MessagePayloads.h 8 Remove
- File TestSupport.c 4 Remove
- File TestSupport.h 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Michael Garthwaite	Author & Moderator	2h 6m	30	fixed thanks
Sean Nash	Reviewer - Complete	58m	16	Should we change msg ID from speed to rate?
Dara Navaei	Reviewer - 0% reviewed	0m
Vinayakam Mani	Reviewer - Complete	55m	10	Add Set Substitution pump target speed here.
Vendor - TEL - Jashwant Gantyada	Reviewer - 18% reviewed	14m	5	same comment as above
Vendor - TEL - Sameer Poyil	Reviewer - 10% reviewed	7m	6	Please check with TD, I have seen one of the develop bran...
Total		4h 23m	67

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-DD-FIRMWARE-LDT-4001-1

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:

LEAHI-DD-FIRMWARE-LDT-4001-1 67

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:

LEAHI-DD-FIRMWARE-LDT-4001-1 67

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time