Fisheye on leahi-common/ https://devapps.diality.us/changelog/~br%3DLDT-4002-hdf-fw-implementation/leahi-common Recent activity in "leahi-common" under directory / LEAHI-TD-FIRMWARE-LDT-1886-2: reviewers finished Fri, 22 May 2026 13:31:18 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1886-2 Sean Nash and Vendor - TEL - Arpita Srivastava finished reviewing LEAHI-TD-FIRMWARE-LDT-1886-2 LEAHI-TD-FIRMWARE-LDT-1886_Blood Set Auto-Load and Auto-Eject - TD ]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated" Fri, 22 May 2026 13:14:51 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29327 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29327 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4033-1

Updated

]]> LEAHI-TD-FIRMWARE-LDT-3215-1: reviewers resumed Fri, 22 May 2026 12:22:11 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3215-1 Vendor - TEL - Jashwant Gantyada and Sean Nash resumed reviewing LEAHI-TD-FIRMWARE-LDT-3215-1 LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed ]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Vendor - TEL - Varshini Nagabooshanam "Removed" Fri, 22 May 2026 12:09:50 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29326 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29326 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4033-1

Removed

]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Vendor - TEL - Varshini Nagabooshanam "Fixed" Fri, 22 May 2026 12:09:31 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29325 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29325 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4033-1

Fixed

]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Vendor - TEL - Varshini Nagabooshanam "Removed" Fri, 22 May 2026 12:03:20 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29324 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29324 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4033-1

Removed

]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Vendor - TEL - Varshini Nagabooshanam "Added alarm" Fri, 22 May 2026 12:03:14 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29323 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29323 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4033-1

Added alarm

]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Vendor - TEL - Varshini Nagabooshanam "Added back" Fri, 22 May 2026 12:02:57 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29322 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29322 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4033-1

Added back

]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Sean Nash "Add alarm here." Fri, 22 May 2026 11:28:33 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29321 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29321 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4033-1

Add alarm here.

]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Sean Nash "Make h10DACControl a U08." Fri, 22 May 2026 11:26:17 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29320 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29320 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4033-1

Make h10DACControl a U08.

]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Sean Nash "Remove extra blank line." Fri, 22 May 2026 11:17:21 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29319 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29319 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4033-1

Remove extra blank line.

]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Sean Nash "This looks like leftover from merge conflict. ..." Fri, 22 May 2026 11:15:42 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29318 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29318 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4033-1

This looks like leftover from merge conflict. Remove this line.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: closed by Vendor - TEL - Jashwant Gantyada Fri, 22 May 2026 11:11:01 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3963-1 ]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Sean Nash "What do we do if BP module reports an error? D..." Fri, 22 May 2026 11:09:10 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29317 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29317 Sean Nash replied to Vendor - TEL - Varshini Nagabooshanam in LEAHI-TD-FIRMWARE-LDT-4033-1

What do we do if BP module reports an error? Do we just go to idle state and there is no alarm?

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: reviewers finished Fri, 22 May 2026 10:50:41 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3963-1 LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3: ]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Vendor - TEL - Varshini Nagabooshanam "Thats for error register so not required now" Fri, 22 May 2026 10:02:04 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29316 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29316 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4033-1

Thats for error register so not required now

]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Vendor - TEL - Varshini Nagabooshanam "You’re right. I should also check the busy stat..." Fri, 22 May 2026 09:10:45 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29314 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29314 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4033-1

You’re right. I should also check the busy status before transitioning to the GET_DATA state. I’ll update the measurement completion logic to first verify the busy bit is cleared, then validate the BP data response code before moving to BP_DRIVER_GET_DATA_STATE.

]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Sean Nash "Why do you have {} in the cases?" Thu, 21 May 2026 22:46:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29313 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29313 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4033-1

Why do you have {} in the cases?

]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Sean Nash "You are getting bpResults, but not doing anythi..." Thu, 21 May 2026 22:44:14 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29312 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29312 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4033-1

You are getting bpResults, but not doing anything with them. Should you pass as parameter to checkBloodPressureReading() function?

]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Sean Nash "Where are these get functions defined? I can't..." Thu, 21 May 2026 22:43:14 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29311 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29311 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4033-1

Where are these get functions defined? I can't find them.

]]> LEAHI-TD-FIRMWARE-LDT-3505-1: closed by Vendor - TEL - Arpita Srivastava Thu, 21 May 2026 16:27:58 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3505-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3505-1 Vendor - TEL - Arpita Srivastava Closed LEAHI-TD-FIRMWARE-LDT-3505-1 ]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vendor - TEL - Jashwant Gantyada "restored" Thu, 21 May 2026 15:24:19 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29309 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29309 Vendor - TEL - Jashwant Gantyada replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3963-1

restored

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Not sure why Crucible is showing it this way. ..." Thu, 21 May 2026 15:23:57 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29308 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29308 Sean Nash replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-3963-1

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Should be #ifndef" Sun, 17 May 2026 23:23:10 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29158 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29158 Sean Nash replied to Vendor - TEL - Jashwant Gantyada in LEAHI-DD-FIRMWARE-LDT-3963-1

Should be #ifndef

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Should be #ifndef I think." Thu, 21 May 2026 15:13:44 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29307 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29307 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Should be #ifndef I think.

]]> LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Can we make these low priority and 999 rank?" Thu, 21 May 2026 15:06:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29305 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1/#c29305 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Can we make these low priority and 999 rank?

]]> LEAHI-TD-FIRMWARE-LDT-3505-1: reviewers finished Thu, 21 May 2026 15:06:50 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3505-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3505-1 Vendor - TEL - Jashwant Gantyada and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-3505-1 LEAHI-TD-FIRMWARE-LDT-3505_Heparin - TD - 04: DEV - Feature Implementation ]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Vendor - TEL - Varshini Nagabooshanam "Removed" Thu, 21 May 2026 12:11:46 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29302 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29302 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4033-1

Removed

]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Vendor - TEL - Varshini Nagabooshanam "Updated" Thu, 21 May 2026 12:02:52 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29301 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29301 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4033-1

Updated

]]> LEAHI-TD-FIRMWARE-LDT-4033-1: comment by Sean Nash "Do we not need the module error alarm?" Thu, 21 May 2026 11:28:08 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29300 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29300 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4033-1

Do we not need the module error alarm?

]]>