fix the typo in 'persistence' across the file.

This function is not checking the level anymore and may be move the functionality at end of fill water end state and transition to next chamber fill state directly,

Check pressure limit.

Does this supposed to be 14 or 17 PSI (based on manifold) for B2.1 hardware?

Is this code updated for B2.1 fill implementation?

Update Inputs and outputs.

fix the typo.

declare a local variable to get these function values and use the variables here?

remove blank space before =

Can we split the functions into two files: 1) DryBicart.c/h - Manages drybicart fill, supply, drain & depressurizing states and 2) MixingControl: for acid/bicarb open/close loop functionality?

Same as above.

Can we keep getBicarbMixControlInterval( removing drybicart) from the function name?

Do we need to call updateDryBicartOperation() here to determine the appropriate state.

function adjusts the volume of acid and bicarb based on the target conductivity of bicarb and dialysate solution?

Add alarm message.

Remove the commented code and add the comment for below function

As suggested earlier in other code review, split this function into few init functions and call it here.

All these are more of debug related overrides (acid and bicarb P & I gain). you can keep them in one function, when the implementation is complete, you may remove these. The init function is too big, group them and split in the functions and call here.

Some of these parameters can be changed over td proxy commands, need not to implement additional overrides.

I guess all these MACRO implementations should move to function/s to compute the final acid and bicarb volume, that would help to calculate the volumes when Na and Bicarb params changed during treatment.

looks Bicarb and sodium settings interchanged? There are multiple macros on the same values. remove the duplicates.

33.0?

Add comment for each macro.

For all floats add F at the end, across the file.

Align the comment

· /firmware/App/Controllers/BalancingChamber.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/BloodLeakDriver.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivityTeensy.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.c	(-2, +2)	| History	| Source	| Diff
… 4 more files in changeset.

]]> Fri, 22 May 2026 11:11:01 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3963-1 ]]> Fri, 22 May 2026 10:50:41 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3963-1 LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3: ]]> Fri, 22 May 2026 07:51:14 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-1 Vinayakam Mani resumed reviewing LEAHI-DD-FIRMWARE-LDT-4183-1 LEAHI-DD-FIRMWARE-LDT-4183_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 2/1: ]]>