· /firmware/App/Modes/ModeTreatment.c	(-6, +11)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.h	(-3, +5)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxIsolatedUF.c	(-4, +129)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxIsolatedUF.h	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +1)	| History	| Source	| Diff

]]> Mon, 01 Jun 2026 16:34:08 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4009-1/#c29592 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4009-1/#c29592 Vinayakam Mani commented on LEAHI-TD-FIRMWARE-LDT-4009-1

Maintain alphabetical order.

Eliza says we do allow multiple iso UF sessions in a treatment. So do we still need this else if, but looking at <= iso UF elapsed session time?

What about HDF?

Once UI software sends the volume and/or duration change request and once we change them, the UI software will send another request to confirm the displayed settings to the user and that is what is being handled in this function.

return result;

Keep local result and set to TRUE or FALSE with a ternary.

Which setting does this message confirm (duration or volume)?

· /firmware/App/Modes/ModeTreatment.c	(-42, +64)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.h	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxIsolatedUF.c	(-1, +16)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxIsolatedUF.h	(-5, +6)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.h	(-10, +10)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-83, +109)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.h	(-0, +2)	| History	| Source	| Diff

]]> Mon, 01 Jun 2026 11:02:32 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4009-1/#c29561 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4009-1/#c29561 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4009-1

Align comment.

How can settings be pending when you set that flag to TRUE in the code below this? And why would we want to use uf volume setting in the else part of this ternary?

else reason is Invalid Request Format

Should check if iso UF volume + UF volume < max. And if user can do multiple iso uf sessions, you would check iso UF volume + any previous iso UF volume + UF volume.
I don't know if there is a minimum iso UF volume.

Looking for "less than current" only makes sense if user can do multiple iso UF sessions in a treatment. And if that's the case, we should be looking at how much time we've already spent doing iso UF instead of how much time we've spent in the HD or HDF treatment.

I think we have to check whether the iso uf duration + treatment duration does not exceed maximum treatment duration.
And I'm not sure if there is a minimum duration for iso uf, but if there is a minimum, it probably isn't the same as the minimum treatment duration.

Just add this as an AND condition in the if statement above.

If we are in treatment end state, the treatment is completed (no need to check that) and I don't think iso UF is a modality.

Do we need this? Check with Raghu. I don't think iso UF is a modality (at least not yet).

Align all or none of the =

I don't think iso uf is considered a modality - at least not in phase 1 of development.

· /firmware/App/Modes/StateTxIsolatedUF.c	(-0, +424)	| History	| Source
· /firmware/App/Modes/StateTxIsolatedUF.h	(-0, +60)	| History	| Source

]]> Mon, 18 May 2026 12:02:06 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4009-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4009-1 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-4009-1 ]]>