On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop similar to UF pump.
GenDialysate mode will have an HDF sub-state that signals this controller from Off to On and would also call separate controller for heater and separate (Switches) monitor for door sensors.

With all of that in mind, I think this unit should have a simpler name like SubPump.

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch state(s) (e.g. while in HDF state, we would expect the cap to be open and stowed and we would want to alarm if that was not the case).

Remove extra blank line.

Where is call to HDF controller?

Monitors should come before mode mgmt above.

What about HemoDiaFiltration.h?

What about initHDF?

Where is HemoDiaFiltration.h?

Why does this file name have pound signs pre/post?

This macro is already defined in Common.h.

Align all "=" or none of them.

DD HDF control data published should just be state and set rate. TD HDF data would have volume, etc...

This looks like pump control function. I think TD f/w should be doing this when setting Qsub before sending to DD f/w. Again, I think DD f/w should just be controlling pump to the Qsub rate given by TD f/w.
HDF volume should be calculated by TD f/w by integrating commanded Qsub over time.

Remove blank line.

Refactor so that only one return statement at end of function. This is in our coding standards.

I think TD should be handling all of these rules before setting Qsub and sending to DD.

Generally, DD shouldn't need TMP. TD is calculating TMP. TD is using TMP to calculate Qsub. DD is just getting Qsub from TD and controlling the pump to that rate.

Indent declarations.

How can we help you with this?

Doesn't match file name. Why do we have a redundant file name with ~ suffix for your new units? If these are backup files from your editor, please do not add these to the git repo (delete them before commit).

DD is not calculating the rate I think. TD is sending target HDF rate to DD. So "calculated" should be "requested" or "commanded".

Add space before )

Add blank line before return statement.

Align doxygen comments to right.

Add blank line before banner

· /firmware/App/Controllers/BalancingChamber.c	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/BloodLeakDriver.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Drivers/ConductivityTeensy.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.c	(-2, +2)	| History	| Source	| Diff
… 4 more files in changeset.

]]> Fri, 22 May 2026 11:11:01 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Vendor - TEL - Jashwant Gantyada Closed LEAHI-DD-FIRMWARE-LDT-3963-1 ]]> Fri, 22 May 2026 10:50:41 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3963-1 LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3: ]]> Thu, 21 May 2026 15:36:44 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/changelog/dd-firmware?cs=94691a0258fe496cfcdc4aaeaa2a5efba4a843ba https://devapps.diality.us/changelog/dd-firmware?cs=94691a0258fe496cfcdc4aaeaa2a5efba4a843ba Vendor - TEL - Jashwant Gantyada committed 94691a0 on branch LDT-3272-software-update---dd-firmware, LDT-3958-dialysate-temperature---fw-impl and 9 more in dd-firmware LDT-3963 addressed code review comments

· /firmware/App/Drivers/ConductivitySensors.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Services/SystemCommDD.c	(-1, +1)	| History	| Source	| Diff

]]>