No, it won't cause an error. The execute() function checks for the leahi-common folder existence first, if it does not exists, it returns, skipping the whole update process.
Not everyone have access to that folder and a whl file don't need to run the update every time, it's more like for those who develop the code.

Also if it's not at the very beginning, the enums will be processed in the next imports, and updating them afterwards is meaningless as it won't reflect in the running code. The files needs to be updated before any other object tries to call them to make an instance.

This will be called when a user imports leahi-dialin, right? ( import leahi-dialin ) and thus cause a traceback cause the user wont have the path to the header files required for this execute call.

suggest keeping the call in if _name_ == '_main_': of enum_update and running that

fixed

Fix typo

· /.gitignore	(-0, +1)	| History	| Source	| Diff
· /leahi_dialin/__init__.py	(-0, +4)	| History	| Source	| Diff
· /leahi_dialin/common/__init__.py	(-3, +1)	| History	| Source	| Diff
· /leahi_dialin/common/alarm_defs.py	(-210, +307)	| History	| Source	| Diff
· /leahi_dialin/common/fp_defs.py	(-1, +2)	| History	| Source	| Diff
· /leahi_dialin/common/msg_defs.py	(-59, +74)	| History	| Source	| Diff
· /leahi_dialin/common/msg_ids.py	(-553, +491)	| History	| Source	| Diff
· /leahi_dialin/dd/dialysate_delivery.py	(-7, +7)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/dd_test_configs.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/dd/modules/ultrafiltration.py	(-1, +0)	| History	| Source	| Diff
· /leahi_dialin/fp/filtration_purification.py	(-7, +7)	| History	| Source	| Diff
· /leahi_dialin/td/modules/syringe_pump.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/td/treatment_delivery.py	(-9, +9)	| History	| Source	| Diff
· /leahi_dialin/utils/enum_updater.py	(-0, +151)	| History	| Source
· /requirements.txt	(-0, +1)	| History	| Source	| Diff

]]> Wed, 23 Apr 2025 16:29:37 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 Michael Garthwaite Closed LEAHI-DIALIN-LEAH-261-1 ]]> Wed, 23 Apr 2025 16:02:54 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 Tiffany Mejia and Sean Nash finished reviewing LEAHI-DIALIN-LEAH-261-1 LEAHI-DIALIN-LEAH-261_FW RO Flow Sensor Driver ]]> Wed, 23 Apr 2025 15:16:55 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 Michael Garthwaite started review LEAHI-DIALIN-LEAH-261-1 ]]> Wed, 23 Apr 2025 14:26:07 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21977 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1/#c21977 Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LEAH-261-1

fixed. Thanks!

Remove extra blank line.

function header?

We should remove DG references throughout. If f/w doesn't call for some of these yet, lets just remove them for now.

Renamed RO class and sub modules to use FP to be in line with sub system names

· /leahi_dialin/__init__.py	(-1, +1)	| History	| Source	| Diff
· /leahi_dialin/fp/__init__.py	(-0, +1)	| History	| Source
· /leahi_dialin/fp/filtration_purification.py	(-0, +250)	| History	| Source
· /leahi_dialin/fp/modules/__init__.py	(-0, +0)	| History	| Source
· /leahi_dialin/fp/modules/boost_pump.py	(-0, +256)	| History	| Source
· /leahi_dialin/fp/modules/conductivity_sensors.py	(-0, +230)	| History	| Source
· /leahi_dialin/fp/modules/constants.py	(-0, +18)	| History	| Source
· /leahi_dialin/fp/modules/flow_sensors.py	(-0, +175)	| History	| Source
· /leahi_dialin/fp/modules/levels.py	(-0, +135)	| History	| Source
· /leahi_dialin/fp/modules/pressure_sensors.py	(-0, +220)	| History	| Source
· /leahi_dialin/fp/modules/valves.py	(-0, +294)	| History	| Source
· /leahi_dialin/protocols/CAN.py	(-10, +10)	| History	| Source	| Diff
· /leahi_dialin/ro/__init__.py	(-1, +0)	| History	| Source	| Diff
· /leahi_dialin/ro/modules/__init__.py	(-0, +0)	| History	| Source	| Diff
· /leahi_dialin/ro/modules/boost_pump.py	(-255, +0)	| History	| Source	| Diff
… 9 more files in changeset.

]]> Fri, 14 Feb 2025 09:26:45 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-261-1 Dara Navaei started review LEAHI-DIALIN-LEAH-261-1 ]]> Wed, 22 Jan 2025 14:11:07 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2 Michael Garthwaite Closed LEAHI-DIALIN-LEAH-136-2 ]]> Wed, 22 Jan 2025 14:10:58 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-139-2 Michael Garthwaite Closed LEAHI-DIALIN-LEAH-139-2 ]]> Wed, 22 Jan 2025 14:06:01 -0800 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-142-2 Michael Garthwaite Closed LEAHI-DIALIN-LEAH-142-2 ]]> Wed, 22 Jan 2025 13:48:09 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21089 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-2/#c21089 Sean Nash commented on LEAHI-DIALIN-LEAH-136-2

File is reverse_osmosis.py. I actually don't like the file name. Prefer something like filtration_purification.py. Still ok with RO for folders and class names I think - though Jenna uses IOFP.

Match DD op modes in f/w.

DG to DD.

Remove.

Remove.

Remove.

Remove.

Remove.

Remove chem disinfect. Leahi not currently slated to have a chem disinfect.